[V5] afterFetch hook, TypeError

[remidosol]

Hello there 👋

I'm running test on AdonisJS 5. Now I'm gonna mention some errors.
I've run HTTP tests for CRUD operations and I've reached Update tests. i.e., I send PUT requests to my update function in Controller. There is no problem about relationships.

I used update function that comes after query() function and updateOrCreate function for updating, result was the same at both.

I've got errors when the following line that is in controller's update function been executed:

let advertisement = await user.related('advertisements').query().where('id', advertisement_id).first()

I'm using an afterFetch hook for preloading specified as following:

@afterFetch()
  public static async preloadAllForMultiple (advertisements: Advertisement[]) {
    try {
      for (let advertisement of advertisements) { // this trouble about model(advertisement) type has started here 
        await advertisement.preload((preloader)=>{
          preloader
            .preload('user') 
            .preload('category')
            .preload('advertisementSuperFeatures') // next trouble has started here
            .preload('advertisementLocation')
        })
      }
    } catch (err) {
      console.log(err.message)
      console.log(err.stack)
    }
  }

And I get the following error when I run tests:

advertisement.preload is not a function
TypeError: advertisement.preload is not a function
    at Function.preloadAllForMultiple (C:\...\app\Models\Advertisement.ts:92:29)
    at Hooks.exec (C:\...\node_modules\@poppinss\hooks\build\src\Hooks\index.js:129:23)
    at HasManyQueryBuilder.exec (C:\...\node_modules\@adonisjs\lucid\build\src\Orm\QueryBuilder\index.js:471:37)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at AdvertisementsController.update (C:\...\app\Controllers\Http\AdvertisementsController.ts:205:9)
    at Object.PreCompiler.runRouteHandler [as fn] (C:\...\node_modules\@adonisjs\http-server\build\src\Server\PreCompiler\index.js:46:31)
    at Server.handle (C:\...\node_modules\@adonisjs\http-server\build\src\Server\index.js:138:13)

Also I've a model named as AdvertisementSuperFeature and there is another strange error. A part of the model and its afterFetch hook:

@column({ columnName: 'advertisement_id', serializeAs: 'advertisementId' }) 
  public advertisementId: number

  @column({ columnName: 'feature_id', serializeAs: 'featureId' })
  public featureId: number
  
  @column({ columnName: 'feature_detail_id', serializeAs: 'featureDetailId' })
  public featureDetailId: number | undefined | null
  
  @column({ serializeAs: 'value' })
  public value: string | undefined | null

  @belongsTo(() => Advertisement)
  public advertisement: BelongsTo<typeof Advertisement>

  @belongsTo(() => Feature, {foreignKey: 'featureId'})
  public feature: BelongsTo<typeof Feature>
  
  @belongsTo(() => FeatureDetail, {foreignKey: 'featureDetailId'})
  public featureDetail: BelongsTo<typeof FeatureDetail>

@afterFetch()
  public static async preloadSuperFeaturesMultiple (adSuperFeatures: AdvertisementSuperFeature[]) {
    try {
      
      for (let adSuperFeature of adSuperFeatures){

        if (adSuperFeature.$attributes.featureDetailId !== null // I'm controlling it here
        && adSuperFeature.$attributes.featureDetailId !== undefined // and here
        ){
          await adSuperFeature.preload('featureDetail', (preloader)=>{
            preloader.preload('feature')
          })
        }else if (
          adSuperFeature.$attributes.featureDetailId === null // I'm controlling it here again
        || adSuperFeature.$attributes.featureDetailId === undefined // and here again
        ){
          await adSuperFeature.preload('feature')
        }
      }
    } catch (err) {
      console.log(err.message)
      console.log(err.stack)
    }
  }

And its error:

Cannot read property 'featureDetailId' of undefined
TypeError: Cannot read property 'featureDetailId' of undefined
    at Function.preloadSuperFeaturesMultiple (C:\...\app\Models\AdvertisementSuperFeature.ts:83:36)
    at Hooks.exec (C:\...\node_modules\@poppinss\hooks\build\src\Hooks\index.js:129:23)
    at HasManyQueryBuilder.exec (C:\...\node_modules\@adonisjs\lucid\build\src\Orm\QueryBuilder\index.js:471:37)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at AdvertisementsController.update (C:\...\app\Controllers\Http\AdvertisementsController.ts:270:15)
    at Object.PreCompiler.runRouteHandler [as fn] (C:\...\node_modules\@adonisjs\http-server\build\src\Server\PreCompiler\index.js:46:31)
    at Server.handle (C:\...\node_modules\@adonisjs\http-server\build\src\Server\index.js:138:13)

BOMB: When I check the DB, althought errors, result is that I expected.

It's look like I'm in trouble with hooks 🤣
What should I do?

[thetutlage]

You can do some initial debugging to see the values you receive inside your hooks. For example: Console log the advertisements value and share its output