[V5] Problem with auth api

[Reptiluka]

Hi !
I followed the steps in https://preview.adonisjs.com/guides/auth/api-guard/
And after /login in Postman, i got this :

With bad credentials : "message": "Invalid user credentials"
So, it's ok.

With the good credentials :

{
    "message": "Cannot find module 'phc-argon2'\nRequire stack:\n- D:\\dev\\test\\proj\\api\\node_modules\\@adonisjs\\hash\\build\\src\\Drivers\\Argon.js\n- D:\\dev\\test\\proj\\api\\node_modules\\@adonisjs\\hash\\build\\src\\Hash\\index.js\n- D:\\dev\\test\\proj\\api\\node_modules\\@adonisjs\\hash\\build\\providers\\HashProvider.js\n- D:\\dev\\test\\proj\\api\\node_modules\\@poppinss\\utils\\build\\src\\esmRequire.js\n- D:\\dev\\test\\proj\\api\\node_modules\\@poppinss\\utils\\build\\index.js\n- D:\\dev\\test\\proj\\api\\node_modules\\@adonisjs\\core\\build\\src\\Ignitor\\Bootstrapper\\index.js\n- D:\\dev\\test\\proj\\api\\node_modules\\@adonisjs\\core\\build\\src\\Ignitor\\Ace\\AppCommands.js\n- D:\\dev\\test\\proj\\api\\node_modules\\@adonisjs\\core\\build\\src\\Ignitor\\Ace\\index.js\n- D:\\dev\\test\\proj\\api\\node_modules\\@adonisjs\\core\\build\\src\\Ignitor\\index.js\n- D:\\dev\\test\\proj\\api\\build\\server.js",
    "stack": "Error: Cannot find module 'phc-argon2'\nRequire stack:\n- D:\\dev\\test\\proj\\api\\node_modules\\@adonisjs\\hash\\build\\src\\Drivers\\Argon.js\n- D:\\dev\\test\\proj\\api\\node_modules\\@adonisjs\\hash\\build\\src\\Hash\\index.js\n- D:\\dev\\test\\proj\\api\\node_modules\\@adonisjs\\hash\\build\\providers\\HashProvider.js\n- D:\\dev\\test\\proj\\api\\node_modules\\@poppinss\\utils\\build\\src\\esmRequire.js\n- D:\\dev\\test\\proj\\api\\node_modules\\@poppinss\\utils\\build\\index.js\n- D:\\dev\\test\\proj\\api\\node_modules\\@adonisjs\\core\\build\\src\\Ignitor\\Bootstrapper\\index.js\n- D:\\dev\\test\\proj\\api\\node_modules\\@adonisjs\\core\\build\\src\\Ignitor\\Ace\\AppCommands.js\n- D:\\dev\\test\\proj\\api\\node_modules\\@adonisjs\\core\\build\\src\\Ignitor\\Ace\\index.js\n- D:\\dev\\test\\proj\\api\\node_modules\\@adonisjs\\core\\build\\src\\Ignitor\\index.js\n- D:\\dev\\test\\proj\\api\\build\\server.js\n    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:982:15)\n    at Function.Module._load (internal/modules/cjs/loader.js:864:27)\n    at Module.require (internal/modules/cjs/loader.js:1044:19)\n    at require (internal/modules/cjs/helpers.js:77:18)\n    at Object.<anonymous> (D:\\dev\\test\\proj\\api\\node_modules\\@adonisjs\\hash\\build\\src\\Drivers\\Argon.js:17:38)\n    at Module._compile (internal/modules/cjs/loader.js:1158:30)\n    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1178:10)\n    at Module.load (internal/modules/cjs/loader.js:1002:32)\n    at Function.Module._load (internal/modules/cjs/loader.js:901:14)\n    at Module.require (internal/modules/cjs/loader.js:1044:19)\n    at require (internal/modules/cjs/helpers.js:77:18)\n    at Hash.createArgon2 (D:\\dev\\test\\proj\\api\\node_modules\\@adonisjs\\hash\\build\\src\\Hash\\index.js:73:27)\n    at Hash.makeDriver (D:\\dev\\test\\proj\\api\\node_modules\\@poppinss\\manager\\build\\src\\Manager.js:92:83)\n    at Hash.use (D:\\dev\\test\\proj\\api\\node_modules\\@poppinss\\manager\\build\\src\\Manager.js:124:21)\n    at Hash.use (D:\\dev\\test\\proj\\api\\node_modules\\@adonisjs\\hash\\build\\src\\Hash\\index.js:143:47)\n    at Hash.verify (D:\\dev\\test\\proj\\api\\node_modules\\@adonisjs\\hash\\build\\src\\Hash\\index.js:125:21)",
    "code": "MODULE_NOT_FOUND"
}

I need help 🙂

[thetutlage]

Yup, you need to install the phc-argon2, which is required to hash the user passwords.

Remember we don't install drivers by default and must be installed by you.

[thetutlage]

The package we are using internally uses bcrypt.js. However, we hash values as per PHC format and you can read more about it here https://github.com/P-H-C/phc-string-format/blob/master/phc-sf-spec.md. In short, the PHC format allows migrating old hashes when the configuration is changed.

Regarding, why not install the dependency by default?

In that case you will end up installing unncessary dependencies in your app. For example: If you are using bcrypt, then why there is argon installed as well? Now apply this to the database. You are using PostgreSQL, but AdonisJS has installed all the database drivers.

So you are the one who has to install the dependency for the driver you decided to use in your app.

[Reptiluka]

Ok, thank you !
We can maybe take in note to add the command line in the api guard doc 🙂

[rodolphonetto]

WAS MY FAULT, sorry !
I did something wrong when added a new User in the database...
In the right way, $argon2 is present and return now the correct token.

But I got the same question I write before, why we don't use something like bcrypt or something else instead of this custom package ??
Thanks :)

What you were doing wrong? I have the same error and saw that the passwords are saved in plain text =/ how did you solved it?

[EDIT]

I've found on the hooks docs how to hash the password, If I not wrong in adonis v4 it was default.

[Reptiluka]

When you create the api guard, it ask you to create the User model.

Normally you will have this inside :

  @beforeSave()
  public static async hashPassword (user: User) {
    if (user.$dirty.password) {
      user.password = await Hash.make(user.password)
    }
  }

With that, on saving it will be correct :)

[rodolphonetto]

Thank you