Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image support #8

Open
newsch opened this issue Jun 26, 2023 · 1 comment
Open

Image support #8

newsch opened this issue Jun 26, 2023 · 1 comment

Comments

@newsch
Copy link
Collaborator

newsch commented Jun 26, 2023

Now that the article sources contain image elements, we can display them in the app.

We need a plan that will:

  • preserve any necessary styling of the elements
  • convert the image urls from relative to absolute
  • keep the images hidden/unloaded by default
  • allow the user to enable image loading dynamically in the apps

Presumably we can mark the elements as hidden or similar, and have a piece of JS to toggle it that is loaded in the app webviews based on a user preference.

@biodranik
Copy link
Member

There is a setting in Organic Maps for Mobile Internet with the following options:

  • Always use
  • Always ask
  • Never use

We can leverage it and handle images accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants