Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Buttons do not have a discernible name #726

Open
sovetski opened this issue Aug 28, 2024 · 3 comments
Open

[Feat]: Buttons do not have a discernible name #726

sovetski opened this issue Aug 28, 2024 · 3 comments
Labels
enhancement New feature or request triage yet to be reviewed

Comments

@sovetski
Copy link

Description

If you check with Lighthouse, you will see this error: Links do not have a discernible name

Proposed solution

As suggested here: https://dequeuniversity.com/rules/axe/4.1/link-name

<a href="taxhike.html" aria-label="Read more about Seminole tax hike">[Read more...]</a>

Additional details

No response

@sovetski sovetski added enhancement New feature or request triage yet to be reviewed labels Aug 28, 2024
@alxndr-w
Copy link

alxndr-w commented Aug 29, 2024

https://cookieconsent.orestbida.com/reference/configuration-reference.html#translation-consentmodal

translations: {
    'en': {
        consentModal: {
            label: 'Cookie Consent',
            title: 'We use cookies!',
            description: 'Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua',
            acceptAllBtn: 'Accept all',
            acceptNecessaryBtn: 'Accept necessary',
            showPreferencesBtn: 'Manage individual preferences',
            footer: `
                <a href="#path-to-impressum.html" target="_blank">Impressum</a>
                <a href="#path-to-privacy-policy.html" target="_blank">Privacy Policy</a>
            `
        }
    }
}

The Footer can be customized like you want it. However, the docs could follow best practice as well.

@sovetski
Copy link
Author

https://cookieconsent.orestbida.com/reference/configuration-reference.html#translation-consentmodal


translations: {

    'en': {

        consentModal: {

            label: 'Cookie Consent',

            title: 'We use cookies!',

            description: 'Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua',

            acceptAllBtn: 'Accept all',

            acceptNecessaryBtn: 'Accept necessary',

            showPreferencesBtn: 'Manage individual preferences',

            footer: `

                <a href="#path-to-impressum.html" target="_blank">Impressum</a>

                <a href="#path-to-privacy-policy.html" target="_blank">Privacy Policy</a>

            `

        }

    }

}

The Footer can be customized like you want it. However, the docs could follow best practice as well.

Footer yes but not buttons like "Manage individual preferences" 😕

@alxndr-w
Copy link

Ok, good point - I think you need to reflect this for the issue's title. I read "Links", not "Buttons" (or at least "Anchors") and my first thoughts have been "Hyperlinks, Imprint, Privacy Policy".

@sovetski sovetski changed the title [Feat]: Links do not have a discernible name [Feat]: Buttons do not have a discernible name Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage yet to be reviewed
Projects
None yet
Development

No branches or pull requests

2 participants