Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security setting should be validated when connecting #46

Open
mateogianolio opened this issue Jan 24, 2024 · 0 comments
Open

Security setting should be validated when connecting #46

mateogianolio opened this issue Jan 24, 2024 · 0 comments
Labels
android enhancement New feature or request

Comments

@mateogianolio
Copy link
Member

They implement the security check in the example app after connecting (https://github.com/espressif/esp-idf-provisioning-android/blob/master/app/src/main/java/com/espressif/ui/activities/AddDeviceActivity.java#L699-L753) but not in the library itself. So if you try to connect to an ESP device configured with security level 1 or 2 using ESPSecurity.unsecure it will not give you an error until later, which can be very confusing/frustrating.

@mateogianolio mateogianolio added enhancement New feature or request android labels Jan 24, 2024
@mateogianolio mateogianolio changed the title [android] Security setting should be validated when connecting Security setting should be validated when connecting Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant