Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow the contract UpdateMappingPair #33

Merged
merged 7 commits into from
Nov 30, 2024
Merged

feat: allow the contract UpdateMappingPair #33

merged 7 commits into from
Nov 30, 2024

Conversation

meomeocoj
Copy link
Member

What is this Pr?

  • Create Denom by pattern factory/token_factory_address/originAddress from Gravity.
  • Auto update mapping if not exist in storage
  • Add permission to env.contract execute UpdateMappingPair

trung2891
trung2891 approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@trung2891 trung2891 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ducphamle2
ducphamle2 approved these changes Nov 30, 2024
View reviewed changes
Copy link
Collaborator

@ducphamle2 ducphamle2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ducphamle2 ducphamle2 merged commit 9e367bb into master Nov 30, 2024
2 of 4 checks passed
@ducphamle2 ducphamle2 deleted the feat/permission-less branch November 30, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trung2891 trung2891 trung2891 approved these changes

@ducphamle2 ducphamle2 ducphamle2 approved these changes

@tubackkhoa tubackkhoa tubackkhoa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@meomeocoj @tubackkhoa @ducphamle2 @trung2891