You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just tried using SimpleTextDataSource with a custom preprocessor but ended up creating a custom subclass of TextDataSource just for this.
I think it would be great if the class SimpleTextDataSource would accept a list of DocumentPreprocessor in its constructors' arguments. The parent class has these arguments.
The text was updated successfully, but these errors were encountered:
We can add that, though SimpleTextDataSource constrains the input format for the text to an internal format we'd been using for years and we had expected that most users would prefer to write their own TextDataSource implementation for their own data rather than change their data to our half-baked format. If it's easier to change the data then we can expose the document preprocessors.
We should note in the docs that the expected path for more complicated text is to subclass TextDataSource and customize the read method.
I just tried using SimpleTextDataSource with a custom preprocessor but ended up creating a custom subclass of TextDataSource just for this.
I think it would be great if the class SimpleTextDataSource would accept a list of DocumentPreprocessor in its constructors' arguments. The parent class has these arguments.
The text was updated successfully, but these errors were encountered: