Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C-ATF processing and ORACC "ox" ATF processor rules integration #66

Open
epageperron opened this issue Oct 10, 2017 · 6 comments
Open

Comments

@epageperron
Copy link
Collaborator

epageperron commented Oct 10, 2017

As part of the MTAAC project, we are processing C-ATF data from the CDLI database. PyOracc looks like the tool that best fits most of our criteria to perform the job so we are planning on extending it to fully support C-ATF, partly basing ourselves on rules from @stinney 's ATF Processor. As such, we would be interested in working directly in a dev branch of your repository. We can also fork and create pull requests. Please let me know if there is an interest on your side.
Thank you,
Émilie

MTAAC: https://cdli-gh.github.io/mtaac
CDLI: https://cdli.ucla.edu
Team: /cdli-gh/mtaac-cdli-engineers

@raquelalegre
Copy link
Contributor

Hi @epageperron ! Apologies for taking long to reply to your request. I was on leave and I'm still trying to catch up with email and work. It is very exciting to have someone reusing our code and contributing to it!

I think the best approach for your work would be to fork this repo, and then create pull requests (ideally linked to issues so we can trace back in the future if needed). You can assign the PRs to me or one of my colleagues (@sgrieve or @ageorgou). We have configured automatic testing, so that'll help us make sure the new changes don't break existing functionality, and at the same time we can learn from each other when reviewing your contributions.

Please let us know if you need any guidance. We haven't touched much of this code in a long time, but we can hopefully be of help! We could set up a Skype call to talk more about this if you need. Just let us know what works best for you.

@raquelalegre
Copy link
Contributor

I have just created a new branch called c-atf (https://github.com/oracc/pyoracc/tree/c-atf) with the same content master has right now. If you fork the repo, you could create PRs to that branch, so we'll be maintaining at the same time the master branch that is used by Nammu, and your latest stable changes in the c-atf branch. Is that OK with you?

@epageperron
Copy link
Collaborator Author

Sounds perfect, thank you !

@epageperron
Copy link
Collaborator Author

Could you please also invite @starlordphr ?

@raquelalegre
Copy link
Contributor

Done! :)

@epageperron
Copy link
Collaborator Author

Many thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants