Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix value of urlPattern in RegexParser #413

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pisces
Copy link

@pisces pisces commented Mar 30, 2022

Summary

  • Fixed the problem that other string after url are recognized as url
  • Add a file RegexParserTest.swift

Screenshot

Before After

@rromanchuk
Copy link

@pisces i just noticed that deep links like my-bundle-id://resource/id aren't picked up by the urlPattern, i tend to use them a lot in customer support context while on device, more reliable "user proofing" than a universal link.

Anyways, i guess i can add a custom handler. That NSRegularExpression escaping in the regexp string for URL makes it so much harder to decompose

@pisces
Copy link
Author

pisces commented Apr 2, 2022

@rromanchuk
I think the existing url pattern doesn't support custom scheme, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants