From 04e7c04101d37ae800c47fea603520fcb606dc4a Mon Sep 17 00:00:00 2001 From: Jonathan Leitschuh Date: Thu, 8 Sep 2022 21:47:00 +0000 Subject: [PATCH] vuln-fix: Zip Slip Vulnerability This fixes a Zip-Slip vulnerability. This change does one of two things. This change either 1. Inserts a guard to protect against Zip Slip. OR 2. Replaces `dir.getCanonicalPath().startsWith(parent.getCanonicalPath())`, which is vulnerable to partial path traversal attacks, with the more secure `dir.getCanonicalFile().toPath().startsWith(parent.getCanonicalFile().toPath())`. For number 2, consider `"/usr/outnot".startsWith("/usr/out")`. The check is bypassed although `/outnot` is not under the `/out` directory. It's important to understand that the terminating slash may be removed when using various `String` representations of the `File` object. For example, on Linux, `println(new File("/var"))` will print `/var`, but `println(new File("/var", "/")` will print `/var/`; however, `println(new File("/var", "/").getCanonicalPath())` will print `/var`. Weakness: CWE-22: Improper Limitation of a Pathname to a Restricted Directory ('Path Traversal') Severity: High CVSSS: 7.4 Detection: CodeQL (https://codeql.github.com/codeql-query-help/java/java-zipslip/) & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.ZipSlip) Reported-by: Jonathan Leitschuh Signed-off-by: Jonathan Leitschuh Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/16 Co-authored-by: Moderne --- .../eclipse/builder/EclipseInstallationBuilder.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/containers/pax-exam-container-eclipse/src/main/java/org/ops4j/pax/exam/container/eclipse/builder/EclipseInstallationBuilder.java b/containers/pax-exam-container-eclipse/src/main/java/org/ops4j/pax/exam/container/eclipse/builder/EclipseInstallationBuilder.java index 82084902f..af24f4fa7 100644 --- a/containers/pax-exam-container-eclipse/src/main/java/org/ops4j/pax/exam/container/eclipse/builder/EclipseInstallationBuilder.java +++ b/containers/pax-exam-container-eclipse/src/main/java/org/ops4j/pax/exam/container/eclipse/builder/EclipseInstallationBuilder.java @@ -97,7 +97,10 @@ private void parseStream(InputStream stream) throws IOException { ZipEntry entry; while ((entry = zip.getNextEntry()) != null) { String name = entry.getName(); - File file = new File(tempFolder, name); + File file = new File(tempFolder, name); + if (!file.toPath().normalize().startsWith(tempFolder.toPath().normalize())) { + throw new IOException("Bad zip entry"); + } file.deleteOnExit(); if (entry.isDirectory()) { FileUtils.forceMkdir(file);