Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve version handling in KarafManipulatorFactory [PAXEXAM-924] #1005

Open
ops4j-issues opened this issue Dec 10, 2018 · 0 comments
Open
Labels

Comments

@ops4j-issues
Copy link

Martin Lichtin created PAXEXAM-924

https://groups.google.com/d/msg/ops4j/Ic7J0XUNCLk/yLNAVGebDgAJ

It makes sense IMHO. Can you please create a Jira about that, I will improve the versioning management.

Thanks,
Regards
JB
On 10/12/2018 13:04, Martin Lichtin wrote:
> I'd like to to use Pax-Exam with a custom-built Karaf that uses a custom versioning.
> Problem is with this code here in KarafManipulatorFactory
>
> if (dots < 3)

{ > version = new Version(karafVersion.replaceFirst("-", ".")); > }

>
> It fails if one provides a version such as "1.4-SNAPSHOT". It should not do this "replaceFirst".
>
> Also, is it possible to get rid of this code here?
>
> if (version.getMajor() < 2 || version.getMajor() == 2 && version.getMinor() < 2)

{ > throw new IllegalArgumentException("Karaf versions < 2.2.0 are not supported"); > }

>


Affects: 4.13.1
Votes: 0, Watches: 1

@ops4j-issues ops4j-issues added the type: improvement Improvement label Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant