Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create message shortcut makes more changes than just adding a message #101

Open
rulfo71 opened this issue Sep 13, 2024 · 7 comments
Open

Comments

@rulfo71
Copy link

rulfo71 commented Sep 13, 2024

hey!

been finding this behaviour with the Create Message shortcut

Before adding a new message:

image

after creating a message "some message":

image

looks like it's using an old version of my en-US.json instead the actual one.
as you can see i have now a lot of changes and i also lost my last "Management" message

Thanks in advance!

Copy link
Contributor

thanks for raising this issue – does this also happen with extract message or only with the create message option?

@rulfo71
Copy link
Author

rulfo71 commented Sep 13, 2024

hey, thanks to you for answering!
also with extract message.

Evidence:

Before extract message:
image

After:
image

let me know if i can help with anything!

@felixhaeberle
Copy link
Contributor

felixhaeberle commented Sep 15, 2024

Is the content simply resorted or does it happen that messages/strings are getting lost?
Can you further share your project.inlang/settings.json file?

@rulfo71
Copy link
Author

rulfo71 commented Sep 17, 2024

some content is resorted yes but also messages/strings getting lost

{
  "$schema": "https://inlang.com/schema/project-settings",
  "sourceLanguageTag": "en-US",
  "languageTags": [
    "en-US",
    "ja-JP"
  ],
  "modules": [
    "https://cdn.jsdelivr.net/npm/@inlang/message-lint-rule-empty-pattern@latest/dist/index.js",
    "https://cdn.jsdelivr.net/npm/@inlang/message-lint-rule-missing-translation@latest/dist/index.js",
    "https://cdn.jsdelivr.net/npm/@inlang/message-lint-rule-without-source@latest/dist/index.js",
    "https://cdn.jsdelivr.net/npm/@inlang/plugin-message-format@latest/dist/index.js",
    "https://cdn.jsdelivr.net/npm/@inlang/plugin-m-function-matcher@latest/dist/index.js",
    "https://cdn.jsdelivr.net/npm/@inlang/message-lint-rule-snake-case-id@latest/dist/index.js",
    "https://cdn.jsdelivr.net/npm/@inlang/message-lint-rule-identical-pattern@latest/dist/index.js"
  ],
  "plugin.inlang.messageFormat": {
    "pathPattern": "./messages/{languageTag}.json"
  }
}

Copy link
Contributor

This all looks normal. We are currently reworking Sherlock and will have a release by next week. The new release should likely fix this behavior.

Copy link
Contributor

I'l ping the Sherlock Discord with the new release so make sure to join our Discord to get notified!:)

@rulfo71
Copy link
Author

rulfo71 commented Sep 29, 2024

sure, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants