Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add backwards compat in Sherlock for SDK v1 & v2 #17

Open
felixhaeberle opened this issue Sep 5, 2024 — with Linear · 3 comments
Open

add backwards compat in Sherlock for SDK v1 & v2 #17

felixhaeberle opened this issue Sep 5, 2024 — with Linear · 3 comments
Assignees

Comments

Copy link

Description

Several properties & APIs have been changed in SDK v2, making Sherlock responsible for migrating them properly where it uses them. For example, the usage of customApi vs the new meta object or languageTags getting replaced by locales

Proposal

Add backwards compat in code and plan how to phase out the SDK v1 syntax rather soonr than later.

@felixhaeberle felixhaeberle self-assigned this Sep 5, 2024
Copy link
Author

look after how the plugin interface and the renaming of bundleId to messageId influences the behavior

Copy link
Author

this is an ongoing task where tests need to be established for sherlock to work for sdk v1 input, so this goal is to create unit tests which successfully load & emit a sdk v2 project from an sdk v1 "interface" / data

TODO:

  • create sdk v1 mock data for a unit test within sherlock running on sdk v2

Copy link
Member

Language tags are migrated by the SDK to locales. The only thing Sherlock needs to do is call customAPI (because no app other than sherlock used it). The rest is the SDKs job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants