Fix #5431 : Todo Checks Should Check Exclusively Against Issues #5564

subhajitxyz · 2024-11-03T04:18:00Z

Explanation

Fix #5431
This pull request fixes issue by implementing the following changes:

Filters out pull requests from the "open issues" list.
Ensures all "To-Do" checks will pass only for open issues (not for prs).

Essential Checklist

The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
Any changes to scripts/assets files have their rationale included in the PR explanation.
The PR follows the style guide.
The PR does not contain any unnecessary code changes from Android Studio (reference).
The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Develop (fork) Branch Update

Develop (fork) Branch Update #2

Develop (fork) Branch Update

Develop(fork) branch update

Develop (fork) Branch Update

…ies (oppia#5526)  ## Explanation  Fixes oppia#5404 This PR migrates deprecated `onBackPressed` usage to `OnBackPressedDispatcher` callback in the following activities and presenters. - ProfileEditActivity - ProfileEditActivityPresenter - QuestionPlayerActivityPresenter - WalkthroughFinalFragmentPresenter ## Essential Checklist  - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). ## For UI-specific PRs only  If your PR includes UI-related changes, then: - Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes - For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see [RTL guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines)) - Add a video showing the full UX flow with a screen reader enabled (see [accessibility guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide)) - For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included - Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing --------- Co-authored-by: Adhiambo Peres <[email protected]> Co-authored-by: Mr. 17 <[email protected]>

…ity (oppia#5548)  ## Explanation  Fixes oppia#5404 This PR migrates deprecated `onBackPressed `usage to `OnBackPressedDispatcher` callback in the RevisonCardActivity and RevisionCardActivityPresenter. ## Essential Checklist  - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). ## For UI-specific PRs only  If your PR includes UI-related changes, then: - Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes - For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see [RTL guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines)) - Add a video showing the full UX flow with a screen reader enabled (see [accessibility guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide)) - For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included - Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Develop (fork) Branch Update

Develop (fork) branch update

github-actions · 2024-11-03T04:42:39Z

Coverage Report

Results

Number of files assessed: 1
Overall Coverage: 0.00%
Coverage Analysis: PASS ✅

Exempted coverage

Files exempted from coverage

File	Exemption Reason
GitHubService.kt scripts/src/java/org/oppia/android/scripts/common/remote/GitHubService.kt	This file is exempted from having a test file; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

github-actions · 2024-11-03T05:41:52Z

Coverage Report

Results

Number of files assessed: 2
Overall Coverage: 83.05%
Coverage Analysis: PASS ✅

Passing coverage

Files with passing code coverage

File	Coverage	Lines Hit	Status	Min Required
ApplicationLifecycleObserver.kt domain/src/main/java/org/oppia/android/domain/oppialogger/analytics/ApplicationLifecycleObserver.kt	83.05%	98 / 118	✅	70%

Exempted coverage

Files exempted from coverage

File	Exemption Reason
GitHubService.kt scripts/src/java/org/oppia/android/scripts/common/remote/GitHubService.kt	This file is exempted from having a test file; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

github-actions · 2024-11-03T06:10:39Z

Coverage Report

Results

Number of files assessed: 1
Overall Coverage: 0.00%
Coverage Analysis: PASS ✅

Exempted coverage

Files exempted from coverage

File	Exemption Reason
GitHubService.kt scripts/src/java/org/oppia/android/scripts/common/remote/GitHubService.kt	This file is exempted from having a test file; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

subhajitxyz · 2024-11-03T06:20:49Z

PTAL , @adhiamboperes .

adhiamboperes

Thanks @subhajitxyz! PTAL at my comment inline.

scripts/src/java/org/oppia/android/scripts/common/remote/GitHubService.kt

github-actions · 2024-11-07T04:04:25Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 5212 bytes (Added)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 2171 bytes (Added)

Method count: 259592 (old), 259758 (new), 166 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6816 (old), 6816 (new), 0 (No change)

Anim: 43 (old), 43 (new), 0 (No change)
Animator: 26 (old), 26 (new), 0 (No change)
Array: 15 (old), 15 (new), 0 (No change)
Attr: 922 (old), 922 (new), 0 (No change)
Bool: 9 (old), 9 (new), 0 (No change)
Color: 967 (old), 967 (new), 0 (No change)
Dimen: 1048 (old), 1048 (new), 0 (No change)
Drawable: 380 (old), 380 (new), 0 (No change)
Id: 1275 (old), 1275 (new), 0 (No change)
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 380 (old), 380 (new), 0 (No change)
Menu: 3 (old), 3 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 850 (old), 850 (new), 0 (No change)
Style: 831 (old), 831 (new), 0 (No change)
Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 5216 bytes (Added)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 3872 bytes (Added)
Method count: 259592 (old), 259758 (new), 166 (Added)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 1 bytes (Removed)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 1 bytes (Added)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 1 bytes (Removed)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 0 bytes (No change)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 1 bytes (Removed)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 136 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 139 bytes (Added)

Method count: 116052 (old), 116054 (new), 2 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5784 (new), 0 (No change)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 342 (new), 0 (No change)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 783 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 140 bytes (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 1240 bytes (Added)
Method count: 116052 (old), 116054 (new), 2 (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 1 bytes (Removed)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 2 bytes (Removed)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 3 bytes (Added)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 1 bytes (Removed)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 1 bytes (Added)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 1 bytes (Added)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 416 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 3421 bytes (Removed)

Method count: 116058 (old), 116060 (new), 2 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5784 (new), 0 (No change)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 342 (new), 0 (No change)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 783 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 420 bytes (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 1478 bytes (Removed)
Method count: 116058 (old), 116060 (new), 2 (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 2 bytes (Removed)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 1 bytes (Added)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 1 bytes (Removed)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 320 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 983 bytes (Removed)

Method count: 116058 (old), 116060 (new), 2 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5784 (new), 0 (No change)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 342 (new), 0 (No change)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 783 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 320 bytes (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 849 bytes (Removed)
Method count: 116058 (old), 116060 (new), 2 (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 1 bytes (Added)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 1 bytes (Removed)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 1 bytes (Added)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 2 bytes (Added)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 1 bytes (Removed)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

github-actions · 2024-11-11T16:18:45Z

Coverage Report

Results

Number of files assessed: 119
Overall Coverage: 76.76%
Coverage Analysis: PASS ✅

Passing coverage

Files with passing code coverage

File	Coverage	Lines Hit	Status	Min Required
EventBundleCreator.kt utility/src/main/java/org/oppia/android/util/logging/EventBundleCreator.kt	75.93%	328 / 432	✅	70%
EventTypeToHumanReadableNameConverter.kt utility/src/main/java/org/oppia/android/util/logging/EventTypeToHumanReadableNameConverter.kt	100.00%	52 / 52	✅	70%
ActivityLanguageLocaleHandler.kt app/src/main/java/org/oppia/android/app/translation/ActivityLanguageLocaleHandler.kt	100.00%	11 / 11	✅	70%
AppLanguageWatcherMixin.kt app/src/main/java/org/oppia/android/app/translation/AppLanguageWatcherMixin.kt	72.22%	26 / 36	✅	70%
ActivityRouter.kt app/src/main/java/org/oppia/android/app/activity/route/ActivityRouter.kt	100.00%	12 / 12	✅	70%
GitHubClient.kt scripts/src/java/org/oppia/android/scripts/common/GitHubClient.kt	100.00%	45 / 45	✅	70%
TodoOpenCheck.kt scripts/src/java/org/oppia/android/scripts/todo/TodoOpenCheck.kt	92.45%	98 / 106	✅	70%
ActivityIntentFactories.kt app/src/main/java/org/oppia/android/app/activity/ActivityIntentFactories.kt	0.00%	0 / 0	✅	0% *
InitializeDefaultLocaleRule.kt testing/src/main/java/org/oppia/android/testing/junit/InitializeDefaultLocaleRule.kt	38.24%	39 / 102	✅	38% *

* represents tests with custom overridden pass/fail coverage thresholds

Exempted coverage

Files exempted from coverage

File	Exemption Reason
LogReportingModule.kt utility/src/main/java/org/oppia/android/util/logging/firebase/LogReportingModule.kt	This file is exempted from having a test file; skipping coverage check.
SpotlightFragment.kt app/src/main/java/org/oppia/android/app/spotlight/SpotlightFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
PoliciesFragment.kt app/src/main/java/org/oppia/android/app/policies/PoliciesFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
PoliciesActivity.kt app/src/main/java/org/oppia/android/app/policies/PoliciesActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
MyDownloadsActivity.kt app/src/main/java/org/oppia/android/app/mydownloads/MyDownloadsActivity.kt	This file is exempted from having a test file; skipping coverage check.
MyDownloadsFragment.kt app/src/main/java/org/oppia/android/app/mydownloads/MyDownloadsFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
StoryActivity.kt app/src/main/java/org/oppia/android/app/story/StoryActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
StoryFragment.kt app/src/main/java/org/oppia/android/app/story/StoryFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
CompletedStoryListActivity.kt app/src/main/java/org/oppia/android/app/completedstorylist/CompletedStoryListActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
AppLanguageActivity.kt app/src/main/java/org/oppia/android/app/options/AppLanguageActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
OptionsActivity.kt app/src/main/java/org/oppia/android/app/options/OptionsActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
AudioLanguageFragment.kt app/src/main/java/org/oppia/android/app/options/AudioLanguageFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ReadingTextSizeActivity.kt app/src/main/java/org/oppia/android/app/options/ReadingTextSizeActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
OptionsFragment.kt app/src/main/java/org/oppia/android/app/options/OptionsFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
AppLanguageFragment.kt app/src/main/java/org/oppia/android/app/options/AppLanguageFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
AudioLanguageActivity.kt app/src/main/java/org/oppia/android/app/options/AudioLanguageActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ReadingTextSizeFragment.kt app/src/main/java/org/oppia/android/app/options/ReadingTextSizeFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
AppLanguageResourceHandler.kt app/src/main/java/org/oppia/android/app/translation/AppLanguageResourceHandler.kt	This file is incompatible with code coverage tooling; skipping coverage check.
MathExpressionInteractionsView.kt app/src/main/java/org/oppia/android/app/customview/interaction/MathExpressionInteractionsView.kt	This file is incompatible with code coverage tooling; skipping coverage check.
LessonThumbnailImageView.kt app/src/main/java/org/oppia/android/app/customview/LessonThumbnailImageView.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ForcedAppDeprecationNoticeDialogFragment.kt app/src/main/java/org/oppia/android/app/notice/ForcedAppDeprecationNoticeDialogFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
GeneralAvailabilityUpgradeNoticeDialogFragment.kt app/src/main/java/org/oppia/android/app/notice/GeneralAvailabilityUpgradeNoticeDialogFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
OsDeprecationNoticeDialogFragment.kt app/src/main/java/org/oppia/android/app/notice/OsDeprecationNoticeDialogFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
BetaNoticeDialogFragment.kt app/src/main/java/org/oppia/android/app/notice/BetaNoticeDialogFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
OptionalAppDeprecationNoticeDialogFragment.kt app/src/main/java/org/oppia/android/app/notice/OptionalAppDeprecationNoticeDialogFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
MathExpressionAccessibilityUtil.kt app/src/main/java/org/oppia/android/app/utility/math/MathExpressionAccessibilityUtil.kt	This file is incompatible with code coverage tooling; skipping coverage check.
RatioExtensions.kt app/src/main/java/org/oppia/android/app/utility/RatioExtensions.kt	This file is incompatible with code coverage tooling; skipping coverage check.
DateTimeUtil.kt app/src/main/java/org/oppia/android/app/utility/datetime/DateTimeUtil.kt	This file is incompatible with code coverage tooling; skipping coverage check.
StateFragment.kt app/src/main/java/org/oppia/android/app/player/state/StateFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
BottomSheetOptionsMenu.kt app/src/main/java/org/oppia/android/app/player/exploration/BottomSheetOptionsMenu.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ExplorationActivity.kt app/src/main/java/org/oppia/android/app/player/exploration/ExplorationActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
AudioFragment.kt app/src/main/java/org/oppia/android/app/player/audio/AudioFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
AlphaApplicationComponent.kt app/src/main/java/org/oppia/android/app/application/alpha/AlphaApplicationComponent.kt	This file is exempted from having a test file; skipping coverage check.
GaApplicationComponent.kt app/src/main/java/org/oppia/android/app/application/ga/GaApplicationComponent.kt	This file is exempted from having a test file; skipping coverage check.
DeveloperApplicationComponent.kt app/src/main/java/org/oppia/android/app/application/dev/DeveloperApplicationComponent.kt	This file is exempted from having a test file; skipping coverage check.
BetaApplicationComponent.kt app/src/main/java/org/oppia/android/app/application/beta/BetaApplicationComponent.kt	This file is exempted from having a test file; skipping coverage check.
ResumeLessonActivity.kt app/src/main/java/org/oppia/android/app/resumelesson/ResumeLessonActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ResumeLessonFragment.kt app/src/main/java/org/oppia/android/app/resumelesson/ResumeLessonFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ActivityRouterModule.kt app/src/main/java/org/oppia/android/app/activity/route/ActivityRouterModule.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ConceptCardFragment.kt app/src/main/java/org/oppia/android/app/topic/conceptcard/ConceptCardFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
TopicActivity.kt app/src/main/java/org/oppia/android/app/topic/TopicActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
TopicInfoFragment.kt app/src/main/java/org/oppia/android/app/topic/info/TopicInfoFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
RevisionCardActivity.kt app/src/main/java/org/oppia/android/app/topic/revisioncard/RevisionCardActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
RevisionCardFragment.kt app/src/main/java/org/oppia/android/app/topic/revisioncard/RevisionCardFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
TopicPracticeFragment.kt app/src/main/java/org/oppia/android/app/topic/practice/TopicPracticeFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
TopicFragment.kt app/src/main/java/org/oppia/android/app/topic/TopicFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
QuestionPlayerActivity.kt app/src/main/java/org/oppia/android/app/topic/questionplayer/QuestionPlayerActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
TopicRevisionFragment.kt app/src/main/java/org/oppia/android/app/topic/revision/TopicRevisionFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
TopicLessonsFragment.kt app/src/main/java/org/oppia/android/app/topic/lessons/TopicLessonsFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
HomeActivity.kt app/src/main/java/org/oppia/android/app/home/HomeActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
WelcomeViewModel.kt app/src/main/java/org/oppia/android/app/home/WelcomeViewModel.kt	This file is incompatible with code coverage tooling; skipping coverage check.
PromotedStoryViewModel.kt app/src/main/java/org/oppia/android/app/home/promotedlist/PromotedStoryViewModel.kt	This file is incompatible with code coverage tooling; skipping coverage check.
PromotedStoryListViewModel.kt app/src/main/java/org/oppia/android/app/home/promotedlist/PromotedStoryListViewModel.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfileProgressFragment.kt app/src/main/java/org/oppia/android/app/profileprogress/ProfileProgressFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfilePictureActivity.kt app/src/main/java/org/oppia/android/app/profileprogress/ProfilePictureActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfileProgressActivity.kt app/src/main/java/org/oppia/android/app/profileprogress/ProfileProgressActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
BindableAdapter.kt app/src/main/java/org/oppia/android/app/recyclerview/BindableAdapter.kt	This file is incompatible with code coverage tooling; skipping coverage check.
OngoingTopicListActivity.kt app/src/main/java/org/oppia/android/app/ongoingtopiclist/OngoingTopicListActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
HelpFragment.kt app/src/main/java/org/oppia/android/app/help/HelpFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
HelpActivity.kt app/src/main/java/org/oppia/android/app/help/HelpActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
WalkthroughActivity.kt app/src/main/java/org/oppia/android/app/walkthrough/WalkthroughActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
StringToRatioParser.kt app/src/main/java/org/oppia/android/app/parser/StringToRatioParser.kt	This file is incompatible with code coverage tooling; skipping coverage check.
FractionParsingUiError.kt app/src/main/java/org/oppia/android/app/parser/FractionParsingUiError.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfileRenameFragment.kt app/src/main/java/org/oppia/android/app/settings/profile/ProfileRenameFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfileListActivity.kt app/src/main/java/org/oppia/android/app/settings/profile/ProfileListActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfileEditFragment.kt app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditFragment.kt	This file is exempted from having a test file; skipping coverage check.
ProfileListFragment.kt app/src/main/java/org/oppia/android/app/settings/profile/ProfileListFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfileEditActivity.kt app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfileResetPinActivity.kt app/src/main/java/org/oppia/android/app/settings/profile/ProfileResetPinActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfileResetPinFragment.kt app/src/main/java/org/oppia/android/app/settings/profile/ProfileResetPinFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfileRenameActivity.kt app/src/main/java/org/oppia/android/app/settings/profile/ProfileRenameActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
SurveyFragment.kt app/src/main/java/org/oppia/android/app/survey/SurveyFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
SurveyActivity.kt app/src/main/java/org/oppia/android/app/survey/SurveyActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ClassroomListFragment.kt app/src/main/java/org/oppia/android/app/classroom/ClassroomListFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ClassroomListActivity.kt app/src/main/java/org/oppia/android/app/classroom/ClassroomListActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
OnboardingFragment.kt app/src/main/java/org/oppia/android/app/onboarding/OnboardingFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
CreateProfileActivity.kt app/src/main/java/org/oppia/android/app/onboarding/CreateProfileActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
OnboardingProfileTypeActivity.kt app/src/main/java/org/oppia/android/app/onboarding/OnboardingProfileTypeActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
IntroFragment.kt app/src/main/java/org/oppia/android/app/onboarding/IntroFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
OnboardingActivity.kt app/src/main/java/org/oppia/android/app/onboarding/OnboardingActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
IntroActivity.kt app/src/main/java/org/oppia/android/app/onboarding/IntroActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
OnboardingProfileTypeFragment.kt app/src/main/java/org/oppia/android/app/onboarding/OnboardingProfileTypeFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
CreateProfileFragment.kt app/src/main/java/org/oppia/android/app/onboarding/CreateProfileFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
RatioInputInteractionViewTestActivity.kt app/src/main/java/org/oppia/android/app/testing/RatioInputInteractionViewTestActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
DragDropTestActivity.kt app/src/main/java/org/oppia/android/app/testing/DragDropTestActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
TestFontScaleConfigurationUtilActivity.kt app/src/main/java/org/oppia/android/app/testing/TestFontScaleConfigurationUtilActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
TestActivity.kt app/src/main/java/org/oppia/android/app/testing/activity/TestActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
FractionInputInteractionViewTestActivity.kt app/src/main/java/org/oppia/android/app/testing/FractionInputInteractionViewTestActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
TopicTestActivityForStory.kt app/src/main/java/org/oppia/android/app/testing/TopicTestActivityForStory.kt	This file is incompatible with code coverage tooling; skipping coverage check.
InputInteractionViewTestActivity.kt app/src/main/java/org/oppia/android/app/testing/InputInteractionViewTestActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
TextInputInteractionViewTestActivity.kt app/src/main/java/org/oppia/android/app/testing/TextInputInteractionViewTestActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
AdminPinActivity.kt app/src/main/java/org/oppia/android/app/profile/AdminPinActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfileChooserFragment.kt app/src/main/java/org/oppia/android/app/profile/ProfileChooserFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
AdminAuthActivity.kt app/src/main/java/org/oppia/android/app/profile/AdminAuthActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfileChooserActivity.kt app/src/main/java/org/oppia/android/app/profile/ProfileChooserActivity.kt	This file is exempted from having a test file; skipping coverage check.
PinPasswordActivity.kt app/src/main/java/org/oppia/android/app/profile/PinPasswordActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
AddProfileActivity.kt app/src/main/java/org/oppia/android/app/profile/AddProfileActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
SplashActivity.kt app/src/main/java/org/oppia/android/app/splash/SplashActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfileAndDeviceIdFragment.kt app/src/main/java/org/oppia/android/app/administratorcontrols/learneranalytics/ProfileAndDeviceIdFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfileAndDeviceIdActivity.kt app/src/main/java/org/oppia/android/app/administratorcontrols/learneranalytics/ProfileAndDeviceIdActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
AdministratorControlsActivity.kt app/src/main/java/org/oppia/android/app/administratorcontrols/AdministratorControlsActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
AdministratorControlsFragment.kt app/src/main/java/org/oppia/android/app/administratorcontrols/AdministratorControlsFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
DeveloperOptionsActivity.kt app/src/main/java/org/oppia/android/app/devoptions/DeveloperOptionsActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
DeveloperOptionsFragment.kt app/src/main/java/org/oppia/android/app/devoptions/DeveloperOptionsFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ForceNetworkTypeFragment.kt app/src/main/java/org/oppia/android/app/devoptions/forcenetworktype/ForceNetworkTypeFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ForceNetworkTypeActivity.kt app/src/main/java/org/oppia/android/app/devoptions/forcenetworktype/ForceNetworkTypeActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
MathExpressionParserActivity.kt app/src/main/java/org/oppia/android/app/devoptions/mathexpressionparser/MathExpressionParserActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
MathExpressionParserFragment.kt app/src/main/java/org/oppia/android/app/devoptions/mathexpressionparser/MathExpressionParserFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
TestApplicationComponent.kt instrumentation/src/java/org/oppia/android/instrumentation/application/TestApplicationComponent.kt	This file is exempted from having a test file; skipping coverage check.
GitHubIssue.kt scripts/src/java/org/oppia/android/scripts/common/model/GitHubIssue.kt	This file is exempted from having a test file; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

github-actions · 2024-11-11T16:44:56Z

Coverage Report

Results

Number of files assessed: 3
Overall Coverage: 94.70%
Coverage Analysis: PASS ✅

Passing coverage

Files with passing code coverage

File	Coverage	Lines Hit	Status	Min Required
GitHubClient.kt scripts/src/java/org/oppia/android/scripts/common/GitHubClient.kt	100.00%	45 / 45	✅	70%
TodoOpenCheck.kt scripts/src/java/org/oppia/android/scripts/todo/TodoOpenCheck.kt	92.45%	98 / 106	✅	70%

Exempted coverage

Files exempted from coverage

File	Exemption Reason
GitHubIssue.kt scripts/src/java/org/oppia/android/scripts/common/model/GitHubIssue.kt	This file is exempted from having a test file; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

github-actions · 2024-11-11T17:28:14Z

Coverage Report

Results

Number of files assessed: 3
Overall Coverage: 94.70%
Coverage Analysis: PASS ✅

Passing coverage

Files with passing code coverage

File	Coverage	Lines Hit	Status	Min Required
GitHubClient.kt scripts/src/java/org/oppia/android/scripts/common/GitHubClient.kt	100.00%	45 / 45	✅	70%
TodoOpenCheck.kt scripts/src/java/org/oppia/android/scripts/todo/TodoOpenCheck.kt	92.45%	98 / 106	✅	70%

Exempted coverage

Files exempted from coverage

File	Exemption Reason
GitHubIssue.kt scripts/src/java/org/oppia/android/scripts/common/model/GitHubIssue.kt	This file is exempted from having a test file; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

subhajitxyz · 2024-11-11T17:49:38Z

PTAL, @adhiamboperes .

oppiabot · 2024-11-11T17:52:42Z

Unassigning @subhajitxyz since a re-review was requested. @subhajitxyz, please make sure you have addressed all review comments. Thanks!

adhiamboperes

@subhajitxyz, just had one clarification. PTAL.

scripts/src/java/org/oppia/android/scripts/common/GitHubClient.kt

github-actions · 2024-11-13T04:05:22Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 1004 bytes (Added)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 1182 bytes (Added)

Method count: 259594 (old), 259592 (new), 2 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6816 (old), 6816 (new), 0 (No change)

Anim: 43 (old), 43 (new), 0 (No change)
Animator: 26 (old), 26 (new), 0 (No change)
Array: 15 (old), 15 (new), 0 (No change)
Attr: 922 (old), 922 (new), 0 (No change)
Bool: 9 (old), 9 (new), 0 (No change)
Color: 967 (old), 967 (new), 0 (No change)
Dimen: 1048 (old), 1048 (new), 0 (No change)
Drawable: 380 (old), 380 (new), 0 (No change)
Id: 1275 (old), 1275 (new), 0 (No change)
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 380 (old), 380 (new), 0 (No change)
Menu: 3 (old), 3 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 850 (old), 850 (new), 0 (No change)
Style: 831 (old), 831 (new), 0 (No change)
Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 1008 bytes (Added)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 2127 bytes (Added)
Method count: 259594 (old), 259592 (new), 2 (Removed)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 0 bytes (No change)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 100 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 390 bytes (Removed)

Method count: 116054 (old), 116052 (new), 2 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5784 (new), 0 (No change)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 342 (new), 0 (No change)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 783 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 104 bytes (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 2683 bytes (Removed)
Method count: 116054 (old), 116052 (new), 2 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 8 bytes (Added)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 2221 bytes (Added)

Method count: 116060 (old), 116058 (new), 2 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5784 (new), 0 (No change)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 342 (new), 0 (No change)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 783 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 12 bytes (Added)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 1190 bytes (Added)
Method count: 116060 (old), 116058 (new), 2 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 4 bytes (Added)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 3010 bytes (Added)

Method count: 116060 (old), 116058 (new), 2 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5784 (new), 0 (No change)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 342 (new), 0 (No change)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 783 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 4 bytes (Added)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 1157 bytes (Added)
Method count: 116060 (old), 116058 (new), 2 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

subhajitxyz · 2024-11-16T05:06:31Z

@adhiamboperes , PTAL.

oppiabot · 2024-11-16T05:09:35Z

Unassigning @subhajitxyz since a re-review was requested. @subhajitxyz, please make sure you have addressed all review comments. Thanks!

adhiamboperes

Thanks @subhajitxyz. This generally looks good to me.

adhiamboperes · 2024-11-19T14:57:54Z

@subhajitxyz, could you please update the PR description with an overview of your fix, then sync with develop.

oppiabot · 2024-11-19T14:59:52Z

Hi @subhajitxyz, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!

github-actions · 2024-11-19T15:52:03Z

Coverage Report

Results

Number of files assessed: 3
Overall Coverage: 94.70%
Coverage Analysis: PASS ✅

Passing coverage

Files with passing code coverage

File	Coverage	Lines Hit	Status	Min Required
GitHubClient.kt scripts/src/java/org/oppia/android/scripts/common/GitHubClient.kt	100.00%	45 / 45	✅	70%
TodoOpenCheck.kt scripts/src/java/org/oppia/android/scripts/todo/TodoOpenCheck.kt	92.45%	98 / 106	✅	70%

Exempted coverage

Files exempted from coverage

File	Exemption Reason
GitHubIssue.kt scripts/src/java/org/oppia/android/scripts/common/model/GitHubIssue.kt	This file is exempted from having a test file; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

subhajitxyz · 2024-11-19T15:58:05Z

Done.

subhajitxyz and others added 15 commits July 23, 2024 12:12

Merge pull request #1 from oppia/develop

d819e70

Develop (fork) Branch Update

Merge branch 'oppia:develop' into develop

c6f54ea

Merge remote-tracking branch 'upstream/develop' into develop

d44015b

Merge pull request #2 from oppia/develop

d604bc2

Develop (fork) Branch Update #2

Merge pull request #3 from oppia/develop

cc0ddef

Develop (fork) Branch Update

Merge pull request #4 from oppia/develop

52c6bb1

Develop(fork) branch update

Merge remote-tracking branch 'upstream/develop' into develop

773c810

Merge pull request #5 from oppia/develop

56af5ae

Develop (fork) Branch Update

Merge pull request #6 from oppia/develop

3883f70

Develop (fork) Branch Update

Merge branch 'oppia:develop' into develop

b4ad7a3

Merge pull request #8 from oppia/develop

238645d

Develop (fork) Branch Update

Merge pull request #9 from oppia/develop

5a546b9

Develop (fork) branch update

add pull=false

63d5e5c

subhajitxyz requested a review from a team as a code owner November 3, 2024 04:18

subhajitxyz requested a review from adhiamboperes November 3, 2024 04:18

add pr in todo for testing

5806dc7

subhajitxyz requested a review from a team as a code owner November 3, 2024 05:08

correct the existing todo

c2862f3

oppiabot bot assigned adhiamboperes Nov 3, 2024

adhiamboperes requested changes Nov 4, 2024

View reviewed changes

scripts/src/java/org/oppia/android/scripts/common/remote/GitHubService.kt Outdated Show resolved Hide resolved

adhiamboperes assigned subhajitxyz and unassigned adhiamboperes Nov 4, 2024

add test for check pr

594459c

subhajitxyz added 3 commits November 11, 2024 13:50

fix exemptions

2bd406a

add lines in exemptions

277fabb

correct Kdoc and test

2c505b0

Merge branch 'develop' into fix-todo-checks

4c93f26

remove unnessery comments

e8e2212

oppiabot bot assigned adhiamboperes and unassigned subhajitxyz Nov 11, 2024

adhiamboperes reviewed Nov 12, 2024

View reviewed changes

scripts/src/java/org/oppia/android/scripts/common/GitHubClient.kt Show resolved Hide resolved

adhiamboperes assigned subhajitxyz and unassigned adhiamboperes Nov 12, 2024

oppiabot bot assigned adhiamboperes and unassigned subhajitxyz Nov 16, 2024

adhiamboperes approved these changes Nov 19, 2024

View reviewed changes

adhiamboperes assigned subhajitxyz and unassigned adhiamboperes Nov 19, 2024

oppiabot bot added the PR: LGTM label Nov 19, 2024

Merge branch 'develop' into fix-todo-checks

0b8ef62

adhiamboperes merged commit 2f68639 into oppia:develop Nov 19, 2024
31 checks passed

Fix #5431 : Todo Checks Should Check Exclusively Against Issues #5564

Fix #5431 : Todo Checks Should Check Exclusively Against Issues #5564

Conversation

subhajitxyz commented Nov 3, 2024 • edited Loading

Explanation

Essential Checklist

For UI-specific PRs only

github-actions bot commented Nov 3, 2024

Coverage Report

Results

Exempted coverage

github-actions bot commented Nov 3, 2024

Coverage Report

Results

Passing coverage

Exempted coverage

github-actions bot commented Nov 3, 2024

Coverage Report

Results

Exempted coverage

subhajitxyz commented Nov 3, 2024

adhiamboperes left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 7, 2024

APK & AAB differences analysis

Dev

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Alpha

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Beta

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Ga

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

github-actions bot commented Nov 11, 2024

Coverage Report

Results

Passing coverage

Exempted coverage

github-actions bot commented Nov 11, 2024

Coverage Report

Results

Passing coverage

Exempted coverage

github-actions bot commented Nov 11, 2024

subhajitxyz commented Nov 3, 2024 •

edited

Loading