-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #4072 and Fix Part of #4938: Revised profile chooser UI #5468
base: develop
Are you sure you want to change the base?
Conversation
…reen # Conflicts: # app/src/main/res/values/styles.xml # app/src/sharedTest/java/org/oppia/android/app/onboarding/CreateProfileFragmentTest.kt
…n' into onboarding-audio-language-screen
…le-domain-config # Conflicts: # app/src/main/java/org/oppia/android/app/onboarding/CreateProfileFragmentPresenter.kt # app/src/main/java/org/oppia/android/app/options/AudioLanguageFragment.kt # app/src/main/java/org/oppia/android/app/splash/SplashActivityPresenter.kt
…le-domain-config # Conflicts: # model/src/main/proto/oppia_logger.proto # testing/src/main/java/org/oppia/android/testing/logging/EventLogSubject.kt # utility/src/main/java/org/oppia/android/util/logging/EventBundleCreator.kt
…ser-ui-views # Conflicts: # app/src/main/java/org/oppia/android/app/profile/ProfileChooserFragmentPresenter.kt # app/src/sharedTest/java/org/oppia/android/app/onboarding/CreateProfileFragmentTest.kt # app/src/sharedTest/java/org/oppia/android/app/profile/ProfileChooserFragmentTest.kt # model/src/main/proto/arguments.proto
Coverage ReportResultsNumber of files assessed: 18 Exempted coverageFiles exempted from coverage
|
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 19 MiB (old), 19 MiB (new), 43 KiB (Added) APK download size (estimated): 17 MiB (old), 17 MiB (new), 33 KiB (Added) Method count: 260154 (old), 260451 (new), 297 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6816 (old), 6860 (new), 44 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 18 MiB (old), 18 MiB (new), 42 KiB (Added)
Configuration hdpiAPK file size: 50 KiB (old), 50 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 49 KiB (old), 49 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 45 KiB (old), 45 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 86 KiB (old), 86 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 57 KiB (old), 57 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 60 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 31 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 24 KiB (Added) Method count: 116245 (old), 116427 (new), 182 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5784 (old), 5819 (new), 35 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 11 MiB (old), 11 MiB (new), 30 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) BetaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 31 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 26 KiB (Added) Method count: 116251 (old), 116433 (new), 182 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5784 (old), 5819 (new), 35 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 11 MiB (old), 11 MiB (new), 30 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) GaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 31 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 25 KiB (Added) Method count: 116251 (old), 116433 (new), 182 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5784 (old), 5819 (new), 35 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 11 MiB (old), 11 MiB (new), 30 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) |
1 similar comment
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 19 MiB (old), 19 MiB (new), 43 KiB (Added) APK download size (estimated): 17 MiB (old), 17 MiB (new), 33 KiB (Added) Method count: 260154 (old), 260451 (new), 297 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6816 (old), 6860 (new), 44 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 18 MiB (old), 18 MiB (new), 42 KiB (Added)
Configuration hdpiAPK file size: 50 KiB (old), 50 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 49 KiB (old), 49 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 45 KiB (old), 45 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 86 KiB (old), 86 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 57 KiB (old), 57 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 60 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 31 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 24 KiB (Added) Method count: 116245 (old), 116427 (new), 182 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5784 (old), 5819 (new), 35 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 11 MiB (old), 11 MiB (new), 30 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) BetaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 31 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 26 KiB (Added) Method count: 116251 (old), 116433 (new), 182 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5784 (old), 5819 (new), 35 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 11 MiB (old), 11 MiB (new), 30 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) GaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 31 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 25 KiB (Added) Method count: 116251 (old), 116433 (new), 182 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5784 (old), 5819 (new), 35 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 11 MiB (old), 11 MiB (new), 30 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) |
Will need to take a look at this next week. @theMr17 might you have capacity to take a review pass on this PR? |
Hi @adhiamboperes, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 19 MiB (old), 19 MiB (new), 41 KiB (Added) APK download size (estimated): 17 MiB (old), 17 MiB (new), 32 KiB (Added) Method count: 260157 (old), 260451 (new), 294 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6816 (old), 6860 (new), 44 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 18 MiB (old), 18 MiB (new), 40 KiB (Added)
Configuration hdpiAPK file size: 50 KiB (old), 50 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 49 KiB (old), 49 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 45 KiB (old), 45 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 86 KiB (old), 86 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 57 KiB (old), 57 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 60 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 30 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 25 KiB (Added) Method count: 116247 (old), 116427 (new), 180 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5784 (old), 5819 (new), 35 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 11 MiB (old), 11 MiB (new), 29 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) BetaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 30 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 25 KiB (Added) Method count: 116253 (old), 116433 (new), 180 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5784 (old), 5819 (new), 35 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 11 MiB (old), 11 MiB (new), 29 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) GaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 30 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 25 KiB (Added) Method count: 116253 (old), 116433 (new), 180 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5784 (old), 5819 (new), 35 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 11 MiB (old), 11 MiB (new), 29 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) |
1 similar comment
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 19 MiB (old), 19 MiB (new), 41 KiB (Added) APK download size (estimated): 17 MiB (old), 17 MiB (new), 32 KiB (Added) Method count: 260157 (old), 260451 (new), 294 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6816 (old), 6860 (new), 44 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 18 MiB (old), 18 MiB (new), 40 KiB (Added)
Configuration hdpiAPK file size: 50 KiB (old), 50 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 49 KiB (old), 49 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 45 KiB (old), 45 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 86 KiB (old), 86 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 57 KiB (old), 57 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 60 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 30 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 25 KiB (Added) Method count: 116247 (old), 116427 (new), 180 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5784 (old), 5819 (new), 35 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 11 MiB (old), 11 MiB (new), 29 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) BetaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 30 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 25 KiB (Added) Method count: 116253 (old), 116433 (new), 180 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5784 (old), 5819 (new), 35 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 11 MiB (old), 11 MiB (new), 29 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) GaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 30 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 25 KiB (Added) Method count: 116253 (old), 116433 (new), 180 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5784 (old), 5819 (new), 35 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 11 MiB (old), 11 MiB (new), 29 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adhiamboperes, and apologies for the delayed review. I have left some comments, PTAL.
Additionally, I’m unsure why the old presenter is named v1
. Shouldn’t it be the other way around?
@@ -23,4 +23,3 @@ android.enableJetifier=false | |||
kotlin.code.style=official | |||
# Needed to enable Android data binding. | |||
android.databinding.enableV2=true | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert this formatting change.
.setProfileNickname(testProfileNickname) | ||
.setParentScreen(IntroActivityParams.ParentScreen.CREATE_PROFILE_SCREEN) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testProfileNickname
is being indirectly tested by testFragment_explanationText_isDisplayed
. Is there a way to verify the parent screen as well?
/** The ViewModel for [ProfileChooserFragment]. */ | ||
/** The ViewModel for [ProfileActionChooserFragment]. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the ProfileActionChooserFragment
going to be introduced in another PR? I couldn't find it.
profileManagementController.loginToProfile(profile.id).toLiveData().observe( | ||
fragment, | ||
{ | ||
if (it is AsyncResult.Success) { | ||
if (enableMultipleClassrooms.value) { | ||
activity.startActivity( | ||
ClassroomListActivity.createClassroomListActivity(activity, profile.id) | ||
) | ||
} else { | ||
activity.startActivity( | ||
HomeActivity.createHomeActivity(activity, profile.id) | ||
) | ||
} | ||
} | ||
} | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lambda argument can be moved out of the observe
function. Ditto for other observers in the both the old and new presenters.
@@ -857,7 +858,7 @@ class ProfileManagementController @Inject constructor( | |||
profileId: ProfileId, | |||
profileType: ProfileType, | |||
avatarImagePath: Uri?, | |||
colorRgb: Int, | |||
colorRgb: Int?, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Under what circumstances could colorRgb
be null?
) | ||
) | ||
} else { | ||
activity.startActivity( | ||
AdminAuthActivity.createAdminAuthActivityIntent( | ||
activity, | ||
chooserViewModel.adminPin, | ||
chooserViewModel.adminProfileId.internalId, | ||
0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0, | |
profileId = 0, |
Nit.
) | ||
binding.apply { | ||
|
||
binding = ProfileSelectionFragmentBinding.inflate(inflater, container, false).apply { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
binding = ProfileSelectionFragmentBinding.inflate(inflater, container, false).apply { | |
binding = ProfileSelectionFragmentBinding.inflate(inflater, container, /* attachToRoot= */ false).apply { |
Nit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a separate landscape layout for this? It seems the primary difference lies only in the root layout.
<ImageView | ||
android:id="@+id/profile_chooser_setting_icon" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the screenshots, it seems we need to add some left margin to the icon on the portrait layout, perhaps the same amount as the bottom margin.
Unassigning @theMr17 since the review is done. |
Hi @adhiamboperes, it looks like some changes were requested on this pull request by @theMr17. PTAL. Thanks! |
# Conflicts: # app/src/main/java/org/oppia/android/app/drawer/ExitProfileDialogFragment.kt
# Conflicts: # app/src/main/java/org/oppia/android/app/classroom/ClassroomListFragmentPresenter.kt # app/src/main/java/org/oppia/android/app/home/HomeFragmentPresenter.kt # app/src/main/java/org/oppia/android/app/onboarding/IntroFragmentPresenter.kt # app/src/main/java/org/oppia/android/app/profile/ProfileChooserFragmentPresenter.kt # app/src/main/java/org/oppia/android/app/splash/SplashActivityPresenter.kt # app/src/sharedTest/java/org/oppia/android/app/classroom/ClassroomListFragmentTest.kt # app/src/sharedTest/java/org/oppia/android/app/profile/ProfileChooserFragmentTest.kt # app/src/sharedTest/java/org/oppia/android/app/splash/SplashActivityTest.kt # app/src/test/java/org/oppia/android/app/home/HomeActivityLocalTest.kt # domain/src/test/java/org/oppia/android/domain/profile/ProfileManagementControllerTest.kt # testing/src/main/java/org/oppia/android/testing/profile/ProfileTestHelper.kt
Coverage ReportResultsNumber of files assessed: 18 Exempted coverageFiles exempted from coverage
|
Explanation
Fixes #4072.
The selected image uri created by
com.miui.gallery
app in Xiaomi devices has a different format from the android recommended uri, and is therefore not parsed correctly. Changing the name of the stored file, to be generated using a random UUID, fixes the issue. Please see #4072 (comment) for more information.Fixes Part of #4938: Creates the new Profile chooser UI.
The portrait mode layout is a grid layout recylerview, while landscape mode utilizes a custom recyclerview to create a carousel. This design choice is kind of inconsistent, but more intuitive for users in landscape mode.
ProfileChooserFragmentPresenter
handles the data binding and UI interactions for both layouts.Care has been taken to ensure the existing profile behaviour e.g. random color selection and 10 profiles limit have been retained.
Additionally, a new
ParentScreen
enum has been created for the onboarding IntroActivity to control when to show the step count. Per PRD, the step count should not show for additional learners.Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: