Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4072 and Fix Part of #4938: Revised profile chooser UI #5468

Open
wants to merge 391 commits into
base: develop
Choose a base branch
from

Conversation

adhiamboperes
Copy link
Collaborator

@adhiamboperes adhiamboperes commented Jul 25, 2024

Explanation

Fixes #4072.
The selected image uri created by com.miui.gallery app in Xiaomi devices has a different format from the android recommended uri, and is therefore not parsed correctly. Changing the name of the stored file, to be generated using a random UUID, fixes the issue. Please see #4072 (comment) for more information.

Fixes Part of #4938: Creates the new Profile chooser UI.
The portrait mode layout is a grid layout recylerview, while landscape mode utilizes a custom recyclerview to create a carousel. This design choice is kind of inconsistent, but more intuitive for users in landscape mode. ProfileChooserFragmentPresenter handles the data binding and UI interactions for both layouts.

Care has been taken to ensure the existing profile behaviour e.g. random color selection and 10 profiles limit have been retained.

Additionally, a new ParentScreen enum has been created for the onboarding IntroActivity to control when to show the step count. Per PRD, the step count should not show for additional learners.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
Portrait Landscape
Screenshot_1724374363 Screenshot_1724374381
Screenshot_1724806380 Screenshot_1724806726

…reen

# Conflicts:
#	app/src/main/res/values/styles.xml
#	app/src/sharedTest/java/org/oppia/android/app/onboarding/CreateProfileFragmentTest.kt
…le-domain-config

# Conflicts:
#	app/src/main/java/org/oppia/android/app/onboarding/CreateProfileFragmentPresenter.kt
#	app/src/main/java/org/oppia/android/app/options/AudioLanguageFragment.kt
#	app/src/main/java/org/oppia/android/app/splash/SplashActivityPresenter.kt
…le-domain-config

# Conflicts:
#	model/src/main/proto/oppia_logger.proto
#	testing/src/main/java/org/oppia/android/testing/logging/EventLogSubject.kt
#	utility/src/main/java/org/oppia/android/util/logging/EventBundleCreator.kt
…ser-ui-views

# Conflicts:
#	app/src/main/java/org/oppia/android/app/profile/ProfileChooserFragmentPresenter.kt
#	app/src/sharedTest/java/org/oppia/android/app/onboarding/CreateProfileFragmentTest.kt
#	app/src/sharedTest/java/org/oppia/android/app/profile/ProfileChooserFragmentTest.kt
#	model/src/main/proto/arguments.proto
Copy link

github-actions bot commented Nov 8, 2024

Coverage Report

Results

Number of files assessed: 18
Overall Coverage: 0.00%
Coverage Analysis: PASS

Exempted coverage

Files exempted from coverage
File Exemption Reason
ViewBindingShimImpl.ktapp/src/main/java/org/oppia/android/app/shim/ViewBindingShimImpl.kt
This file is exempted from having a test file; skipping coverage check.
ViewBindingShim.ktapp/src/main/java/org/oppia/android/app/shim/ViewBindingShim.kt
This file is exempted from having a test file; skipping coverage check.
ViewComponentImpl.ktapp/src/main/java/org/oppia/android/app/view/ViewComponentImpl.kt
This file is exempted from having a test file; skipping coverage check.
StartSnapHelper.ktapp/src/main/java/org/oppia/android/app/recyclerview/StartSnapHelper.kt
This file is exempted from having a test file; skipping coverage check.
CreateProfileFragmentPresenter.ktapp/src/main/java/org/oppia/android/app/onboarding/CreateProfileFragmentPresenter.kt
This file is exempted from having a test file; skipping coverage check.
IntroActivityPresenter.ktapp/src/main/java/org/oppia/android/app/onboarding/IntroActivityPresenter.kt
This file is exempted from having a test file; skipping coverage check.
IntroFragment.ktapp/src/main/java/org/oppia/android/app/onboarding/IntroFragment.kt
This file is incompatible with code coverage tooling; skipping coverage check.
IntroFragmentPresenter.ktapp/src/main/java/org/oppia/android/app/onboarding/IntroFragmentPresenter.kt
This file is exempted from having a test file; skipping coverage check.
IntroActivity.ktapp/src/main/java/org/oppia/android/app/onboarding/IntroActivity.kt
This file is incompatible with code coverage tooling; skipping coverage check.
CreateProfileFragment.ktapp/src/main/java/org/oppia/android/app/onboarding/CreateProfileFragment.kt
This file is incompatible with code coverage tooling; skipping coverage check.
ProfileChooserFragment.ktapp/src/main/java/org/oppia/android/app/profile/ProfileChooserFragment.kt
This file is incompatible with code coverage tooling; skipping coverage check.
ProfileChooserFragmentPresenter.ktapp/src/main/java/org/oppia/android/app/profile/ProfileChooserFragmentPresenter.kt
This file is exempted from having a test file; skipping coverage check.
ProfileItemViewModel.ktapp/src/main/java/org/oppia/android/app/profile/ProfileItemViewModel.kt
This file is exempted from having a test file; skipping coverage check.
ProfileChooserViewModel.ktapp/src/main/java/org/oppia/android/app/profile/ProfileChooserViewModel.kt
This file is exempted from having a test file; skipping coverage check.
ProfileListView.ktapp/src/main/java/org/oppia/android/app/profile/ProfileListView.kt
This file is exempted from having a test file; skipping coverage check.
ProfileChooserFragmentPresenterV1.ktapp/src/main/java/org/oppia/android/app/profile/ProfileChooserFragmentPresenterV1.kt
This file is exempted from having a test file; skipping coverage check.
ProfileClickListener.ktapp/src/main/java/org/oppia/android/app/profile/ProfileClickListener.kt
This file is exempted from having a test file; skipping coverage check.
ProfileManagementController.ktdomain/src/main/java/org/oppia/android/domain/profile/ProfileManagementController.kt
This file is incompatible with code coverage tooling; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

Copy link

github-actions bot commented Nov 9, 2024

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 43 KiB (Added)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 33 KiB (Added)

Method count: 260154 (old), 260451 (new), 297 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6816 (old), 6860 (new), 44 (Added)

  • Anim: 43 (old), 43 (new), 0 (No change)
  • Animator: 26 (old), 26 (new), 0 (No change)
  • Array: 15 (old), 15 (new), 0 (No change)
  • Attr: 922 (old), 922 (new), 0 (No change)
  • Bool: 9 (old), 9 (new), 0 (No change)
  • Color: 967 (old), 975 (new), 8 (Added):
    • color/color_def_charcoal (added)
    • color/color_def_ivory (added)
    • color/color_palette_profile_selection_background_color (added)
    • color/color_palette_profile_selection_profile_icon_background_color (added)
    • color/component_color_profile_icon_stroke_color (added)
    • And 3 others
  • Dimen: 1048 (old), 1064 (new), 16 (Added):
    • dimen/profile_item_profile_icon_size (added)
    • dimen/profile_item_profile_picture_stroke_width (added)
    • dimen/profile_selection_activity_profile_icon_size (added)
    • dimen/profile_selection_fragment_header_text_size (added)
    • dimen/profile_selection_fragment_icon_margin (added)
    • And 11 others
  • Drawable: 380 (old), 383 (new), 3 (Added):
    • drawable/ic_add (added)
    • drawable/ic_chevron_left (added)
    • drawable/ic_chevron_right (added)
  • Id: 1275 (old), 1285 (new), 10 (Added):
    • id/add_profile_button (added)
    • id/add_profile_prompt (added)
    • id/profile_avatar (added)
    • id/profile_item_container (added)
    • id/profile_list_scroll_left (added)
    • And 5 others
  • Integer: 37 (old), 37 (new), 0 (No change)
  • Interpolator: 11 (old), 11 (new), 0 (No change)
  • Layout: 380 (old), 382 (new), 2 (Added):
    • layout/profile_item (added)
    • layout/profile_selection_fragment (added)
  • Menu: 3 (old), 3 (new), 0 (No change)
  • Mipmap: 1 (old), 1 (new), 0 (No change)
  • Plurals: 10 (old), 10 (new), 0 (No change)
  • Raw: 2 (old), 2 (new), 0 (No change)
  • String: 850 (old), 855 (new), 5 (Added):
    • string/profile_selection_add_icon_description (added)
    • string/profile_selection_add_profile_text (added)
    • string/profile_selection_admin_label (added)
    • string/profile_selection_header (added)
    • string/profile_selection_profile_icon_description (added)
  • Style: 831 (old), 831 (new), 0 (No change)
  • Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

  • hdpi (same)
  • ldpi (same)
  • mdpi (same)
  • tvdpi (same)
  • xhdpi (same)
  • xxhdpi (same)
  • xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 42 KiB (Added)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 35 KiB (Added)
Method count: 260154 (old), 260451 (new), 297 (Added)
Resources: 6766 (old), 6810 (new), 44 (Added)

  • Color: 967 (old), 975 (new), 8 (Added)
  • Dimen: 1044 (old), 1060 (new), 16 (Added)
  • Drawable: 335 (old), 338 (new), 3 (Added)
  • Id: 1275 (old), 1285 (new), 10 (Added)
  • Layout: 380 (old), 382 (new), 2 (Added)
  • String: 850 (old), 855 (new), 5 (Added)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 36 bytes (Added)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 2 bytes (Added)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 48 bytes (Added)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 48 bytes (Added)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 60 bytes (Added)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 1 bytes (Removed)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 36 bytes (Added)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 1 bytes (Removed)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 48 bytes (Added)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 1 bytes (Added)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 60 bytes (Added)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 5 bytes (Removed)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 31 KiB (Added)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 24 KiB (Added)

Method count: 116245 (old), 116427 (new), 182 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5819 (new), 35 (Added)

  • Anim: 33 (old), 33 (new), 0 (No change)
  • Animator: 24 (old), 24 (new), 0 (No change)
  • Array: 14 (old), 14 (new), 0 (No change)
  • Attr: 888 (old), 888 (new), 0 (No change)
  • Bool: 8 (old), 8 (new), 0 (No change)
  • Color: 820 (old), 826 (new), 6 (Added):
    • color/color_def_charcoal (added)
    • color/color_def_ivory (added)
    • color/color_palette_profile_selection_background_color (added)
    • color/component_color_profile_icon_stroke_color (added)
    • color/component_color_profile_selection_background_color (added)
    • And 1 other
  • Dimen: 780 (old), 791 (new), 11 (Added):
    • dimen/profile_item_profile_icon_size (added)
    • dimen/profile_item_profile_picture_stroke_width (added)
    • dimen/profile_selection_fragment_header_text_size (added)
    • dimen/profile_selection_fragment_icon_margin (added)
    • dimen/profile_selection_fragment_icon_padding (added)
    • And 6 others
  • Drawable: 342 (old), 345 (new), 3 (Added):
    • drawable/ic_add (added)
    • drawable/ic_chevron_left (added)
    • drawable/ic_chevron_right (added)
  • Id: 1221 (old), 1231 (new), 10 (Added):
    • id/add_profile_button (added)
    • id/add_profile_prompt (added)
    • id/profile_avatar (added)
    • id/profile_item_container (added)
    • id/profile_list_scroll_left (added)
    • And 5 others
  • Integer: 32 (old), 32 (new), 0 (No change)
  • Interpolator: 11 (old), 11 (new), 0 (No change)
  • Layout: 343 (old), 345 (new), 2 (Added):
    • layout/profile_item (added)
    • layout/profile_selection_fragment (added)
  • Menu: 1 (old), 1 (new), 0 (No change)
  • Mipmap: 1 (old), 1 (new), 0 (No change)
  • Plurals: 10 (old), 10 (new), 0 (No change)
  • String: 783 (old), 786 (new), 3 (Added):
    • string/profile_selection_add_profile_text (added)
    • string/profile_selection_header (added)
    • string/profile_selection_profile_icon_description (added)
  • Style: 472 (old), 472 (new), 0 (No change)
  • Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

  • hdpi (same)
  • ldpi (same)
  • mdpi (same)
  • tvdpi (same)
  • xhdpi (same)
  • xxhdpi (same)
  • xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 30 KiB (Added)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 22 KiB (Added)
Method count: 116245 (old), 116427 (new), 182 (Added)
Resources: 5741 (old), 5776 (new), 35 (Added)

  • Color: 820 (old), 826 (new), 6 (Added)
  • Dimen: 778 (old), 789 (new), 11 (Added)
  • Drawable: 302 (old), 305 (new), 3 (Added)
  • Id: 1221 (old), 1231 (new), 10 (Added)
  • Layout: 343 (old), 345 (new), 2 (Added)
  • String: 783 (old), 786 (new), 3 (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 31 KiB (Added)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 26 KiB (Added)

Method count: 116251 (old), 116433 (new), 182 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5819 (new), 35 (Added)

  • Anim: 33 (old), 33 (new), 0 (No change)
  • Animator: 24 (old), 24 (new), 0 (No change)
  • Array: 14 (old), 14 (new), 0 (No change)
  • Attr: 888 (old), 888 (new), 0 (No change)
  • Bool: 8 (old), 8 (new), 0 (No change)
  • Color: 820 (old), 826 (new), 6 (Added):
    • color/color_def_charcoal (added)
    • color/color_def_ivory (added)
    • color/color_palette_profile_selection_background_color (added)
    • color/component_color_profile_icon_stroke_color (added)
    • color/component_color_profile_selection_background_color (added)
    • And 1 other
  • Dimen: 780 (old), 791 (new), 11 (Added):
    • dimen/profile_item_profile_icon_size (added)
    • dimen/profile_item_profile_picture_stroke_width (added)
    • dimen/profile_selection_fragment_header_text_size (added)
    • dimen/profile_selection_fragment_icon_margin (added)
    • dimen/profile_selection_fragment_icon_padding (added)
    • And 6 others
  • Drawable: 342 (old), 345 (new), 3 (Added):
    • drawable/ic_add (added)
    • drawable/ic_chevron_left (added)
    • drawable/ic_chevron_right (added)
  • Id: 1221 (old), 1231 (new), 10 (Added):
    • id/add_profile_button (added)
    • id/add_profile_prompt (added)
    • id/profile_avatar (added)
    • id/profile_item_container (added)
    • id/profile_list_scroll_left (added)
    • And 5 others
  • Integer: 32 (old), 32 (new), 0 (No change)
  • Interpolator: 11 (old), 11 (new), 0 (No change)
  • Layout: 343 (old), 345 (new), 2 (Added):
    • layout/profile_item (added)
    • layout/profile_selection_fragment (added)
  • Menu: 1 (old), 1 (new), 0 (No change)
  • Mipmap: 1 (old), 1 (new), 0 (No change)
  • Plurals: 10 (old), 10 (new), 0 (No change)
  • String: 783 (old), 786 (new), 3 (Added):
    • string/profile_selection_add_profile_text (added)
    • string/profile_selection_header (added)
    • string/profile_selection_profile_icon_description (added)
  • Style: 472 (old), 472 (new), 0 (No change)
  • Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

  • hdpi (same)
  • ldpi (same)
  • mdpi (same)
  • tvdpi (same)
  • xhdpi (same)
  • xxhdpi (same)
  • xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 30 KiB (Added)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 26 KiB (Added)
Method count: 116251 (old), 116433 (new), 182 (Added)
Resources: 5741 (old), 5776 (new), 35 (Added)

  • Color: 820 (old), 826 (new), 6 (Added)
  • Dimen: 778 (old), 789 (new), 11 (Added)
  • Drawable: 302 (old), 305 (new), 3 (Added)
  • Id: 1221 (old), 1231 (new), 10 (Added)
  • Layout: 343 (old), 345 (new), 2 (Added)
  • String: 783 (old), 786 (new), 3 (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 31 KiB (Added)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 25 KiB (Added)

Method count: 116251 (old), 116433 (new), 182 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5819 (new), 35 (Added)

  • Anim: 33 (old), 33 (new), 0 (No change)
  • Animator: 24 (old), 24 (new), 0 (No change)
  • Array: 14 (old), 14 (new), 0 (No change)
  • Attr: 888 (old), 888 (new), 0 (No change)
  • Bool: 8 (old), 8 (new), 0 (No change)
  • Color: 820 (old), 826 (new), 6 (Added):
    • color/color_def_charcoal (added)
    • color/color_def_ivory (added)
    • color/color_palette_profile_selection_background_color (added)
    • color/component_color_profile_icon_stroke_color (added)
    • color/component_color_profile_selection_background_color (added)
    • And 1 other
  • Dimen: 780 (old), 791 (new), 11 (Added):
    • dimen/profile_item_profile_icon_size (added)
    • dimen/profile_item_profile_picture_stroke_width (added)
    • dimen/profile_selection_fragment_header_text_size (added)
    • dimen/profile_selection_fragment_icon_margin (added)
    • dimen/profile_selection_fragment_icon_padding (added)
    • And 6 others
  • Drawable: 342 (old), 345 (new), 3 (Added):
    • drawable/ic_add (added)
    • drawable/ic_chevron_left (added)
    • drawable/ic_chevron_right (added)
  • Id: 1221 (old), 1231 (new), 10 (Added):
    • id/add_profile_button (added)
    • id/add_profile_prompt (added)
    • id/profile_avatar (added)
    • id/profile_item_container (added)
    • id/profile_list_scroll_left (added)
    • And 5 others
  • Integer: 32 (old), 32 (new), 0 (No change)
  • Interpolator: 11 (old), 11 (new), 0 (No change)
  • Layout: 343 (old), 345 (new), 2 (Added):
    • layout/profile_item (added)
    • layout/profile_selection_fragment (added)
  • Menu: 1 (old), 1 (new), 0 (No change)
  • Mipmap: 1 (old), 1 (new), 0 (No change)
  • Plurals: 10 (old), 10 (new), 0 (No change)
  • String: 783 (old), 786 (new), 3 (Added):
    • string/profile_selection_add_profile_text (added)
    • string/profile_selection_header (added)
    • string/profile_selection_profile_icon_description (added)
  • Style: 472 (old), 472 (new), 0 (No change)
  • Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

  • hdpi (same)
  • ldpi (same)
  • mdpi (same)
  • tvdpi (same)
  • xhdpi (same)
  • xxhdpi (same)
  • xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 30 KiB (Added)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 25 KiB (Added)
Method count: 116251 (old), 116433 (new), 182 (Added)
Resources: 5741 (old), 5776 (new), 35 (Added)

  • Color: 820 (old), 826 (new), 6 (Added)
  • Dimen: 778 (old), 789 (new), 11 (Added)
  • Drawable: 302 (old), 305 (new), 3 (Added)
  • Id: 1221 (old), 1231 (new), 10 (Added)
  • Layout: 343 (old), 345 (new), 2 (Added)
  • String: 783 (old), 786 (new), 3 (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

1 similar comment
Copy link

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 43 KiB (Added)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 33 KiB (Added)

Method count: 260154 (old), 260451 (new), 297 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6816 (old), 6860 (new), 44 (Added)

  • Anim: 43 (old), 43 (new), 0 (No change)
  • Animator: 26 (old), 26 (new), 0 (No change)
  • Array: 15 (old), 15 (new), 0 (No change)
  • Attr: 922 (old), 922 (new), 0 (No change)
  • Bool: 9 (old), 9 (new), 0 (No change)
  • Color: 967 (old), 975 (new), 8 (Added):
    • color/color_def_charcoal (added)
    • color/color_def_ivory (added)
    • color/color_palette_profile_selection_background_color (added)
    • color/color_palette_profile_selection_profile_icon_background_color (added)
    • color/component_color_profile_icon_stroke_color (added)
    • And 3 others
  • Dimen: 1048 (old), 1064 (new), 16 (Added):
    • dimen/profile_item_profile_icon_size (added)
    • dimen/profile_item_profile_picture_stroke_width (added)
    • dimen/profile_selection_activity_profile_icon_size (added)
    • dimen/profile_selection_fragment_header_text_size (added)
    • dimen/profile_selection_fragment_icon_margin (added)
    • And 11 others
  • Drawable: 380 (old), 383 (new), 3 (Added):
    • drawable/ic_add (added)
    • drawable/ic_chevron_left (added)
    • drawable/ic_chevron_right (added)
  • Id: 1275 (old), 1285 (new), 10 (Added):
    • id/add_profile_button (added)
    • id/add_profile_prompt (added)
    • id/profile_avatar (added)
    • id/profile_item_container (added)
    • id/profile_list_scroll_left (added)
    • And 5 others
  • Integer: 37 (old), 37 (new), 0 (No change)
  • Interpolator: 11 (old), 11 (new), 0 (No change)
  • Layout: 380 (old), 382 (new), 2 (Added):
    • layout/profile_item (added)
    • layout/profile_selection_fragment (added)
  • Menu: 3 (old), 3 (new), 0 (No change)
  • Mipmap: 1 (old), 1 (new), 0 (No change)
  • Plurals: 10 (old), 10 (new), 0 (No change)
  • Raw: 2 (old), 2 (new), 0 (No change)
  • String: 850 (old), 855 (new), 5 (Added):
    • string/profile_selection_add_icon_description (added)
    • string/profile_selection_add_profile_text (added)
    • string/profile_selection_admin_label (added)
    • string/profile_selection_header (added)
    • string/profile_selection_profile_icon_description (added)
  • Style: 831 (old), 831 (new), 0 (No change)
  • Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

  • hdpi (same)
  • ldpi (same)
  • mdpi (same)
  • tvdpi (same)
  • xhdpi (same)
  • xxhdpi (same)
  • xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 42 KiB (Added)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 35 KiB (Added)
Method count: 260154 (old), 260451 (new), 297 (Added)
Resources: 6766 (old), 6810 (new), 44 (Added)

  • Color: 967 (old), 975 (new), 8 (Added)
  • Dimen: 1044 (old), 1060 (new), 16 (Added)
  • Drawable: 335 (old), 338 (new), 3 (Added)
  • Id: 1275 (old), 1285 (new), 10 (Added)
  • Layout: 380 (old), 382 (new), 2 (Added)
  • String: 850 (old), 855 (new), 5 (Added)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 36 bytes (Added)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 2 bytes (Added)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 48 bytes (Added)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 48 bytes (Added)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 60 bytes (Added)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 1 bytes (Removed)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 36 bytes (Added)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 1 bytes (Removed)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 48 bytes (Added)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 1 bytes (Added)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 60 bytes (Added)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 5 bytes (Removed)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 31 KiB (Added)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 24 KiB (Added)

Method count: 116245 (old), 116427 (new), 182 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5819 (new), 35 (Added)

  • Anim: 33 (old), 33 (new), 0 (No change)
  • Animator: 24 (old), 24 (new), 0 (No change)
  • Array: 14 (old), 14 (new), 0 (No change)
  • Attr: 888 (old), 888 (new), 0 (No change)
  • Bool: 8 (old), 8 (new), 0 (No change)
  • Color: 820 (old), 826 (new), 6 (Added):
    • color/color_def_charcoal (added)
    • color/color_def_ivory (added)
    • color/color_palette_profile_selection_background_color (added)
    • color/component_color_profile_icon_stroke_color (added)
    • color/component_color_profile_selection_background_color (added)
    • And 1 other
  • Dimen: 780 (old), 791 (new), 11 (Added):
    • dimen/profile_item_profile_icon_size (added)
    • dimen/profile_item_profile_picture_stroke_width (added)
    • dimen/profile_selection_fragment_header_text_size (added)
    • dimen/profile_selection_fragment_icon_margin (added)
    • dimen/profile_selection_fragment_icon_padding (added)
    • And 6 others
  • Drawable: 342 (old), 345 (new), 3 (Added):
    • drawable/ic_add (added)
    • drawable/ic_chevron_left (added)
    • drawable/ic_chevron_right (added)
  • Id: 1221 (old), 1231 (new), 10 (Added):
    • id/add_profile_button (added)
    • id/add_profile_prompt (added)
    • id/profile_avatar (added)
    • id/profile_item_container (added)
    • id/profile_list_scroll_left (added)
    • And 5 others
  • Integer: 32 (old), 32 (new), 0 (No change)
  • Interpolator: 11 (old), 11 (new), 0 (No change)
  • Layout: 343 (old), 345 (new), 2 (Added):
    • layout/profile_item (added)
    • layout/profile_selection_fragment (added)
  • Menu: 1 (old), 1 (new), 0 (No change)
  • Mipmap: 1 (old), 1 (new), 0 (No change)
  • Plurals: 10 (old), 10 (new), 0 (No change)
  • String: 783 (old), 786 (new), 3 (Added):
    • string/profile_selection_add_profile_text (added)
    • string/profile_selection_header (added)
    • string/profile_selection_profile_icon_description (added)
  • Style: 472 (old), 472 (new), 0 (No change)
  • Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

  • hdpi (same)
  • ldpi (same)
  • mdpi (same)
  • tvdpi (same)
  • xhdpi (same)
  • xxhdpi (same)
  • xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 30 KiB (Added)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 22 KiB (Added)
Method count: 116245 (old), 116427 (new), 182 (Added)
Resources: 5741 (old), 5776 (new), 35 (Added)

  • Color: 820 (old), 826 (new), 6 (Added)
  • Dimen: 778 (old), 789 (new), 11 (Added)
  • Drawable: 302 (old), 305 (new), 3 (Added)
  • Id: 1221 (old), 1231 (new), 10 (Added)
  • Layout: 343 (old), 345 (new), 2 (Added)
  • String: 783 (old), 786 (new), 3 (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 31 KiB (Added)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 26 KiB (Added)

Method count: 116251 (old), 116433 (new), 182 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5819 (new), 35 (Added)

  • Anim: 33 (old), 33 (new), 0 (No change)
  • Animator: 24 (old), 24 (new), 0 (No change)
  • Array: 14 (old), 14 (new), 0 (No change)
  • Attr: 888 (old), 888 (new), 0 (No change)
  • Bool: 8 (old), 8 (new), 0 (No change)
  • Color: 820 (old), 826 (new), 6 (Added):
    • color/color_def_charcoal (added)
    • color/color_def_ivory (added)
    • color/color_palette_profile_selection_background_color (added)
    • color/component_color_profile_icon_stroke_color (added)
    • color/component_color_profile_selection_background_color (added)
    • And 1 other
  • Dimen: 780 (old), 791 (new), 11 (Added):
    • dimen/profile_item_profile_icon_size (added)
    • dimen/profile_item_profile_picture_stroke_width (added)
    • dimen/profile_selection_fragment_header_text_size (added)
    • dimen/profile_selection_fragment_icon_margin (added)
    • dimen/profile_selection_fragment_icon_padding (added)
    • And 6 others
  • Drawable: 342 (old), 345 (new), 3 (Added):
    • drawable/ic_add (added)
    • drawable/ic_chevron_left (added)
    • drawable/ic_chevron_right (added)
  • Id: 1221 (old), 1231 (new), 10 (Added):
    • id/add_profile_button (added)
    • id/add_profile_prompt (added)
    • id/profile_avatar (added)
    • id/profile_item_container (added)
    • id/profile_list_scroll_left (added)
    • And 5 others
  • Integer: 32 (old), 32 (new), 0 (No change)
  • Interpolator: 11 (old), 11 (new), 0 (No change)
  • Layout: 343 (old), 345 (new), 2 (Added):
    • layout/profile_item (added)
    • layout/profile_selection_fragment (added)
  • Menu: 1 (old), 1 (new), 0 (No change)
  • Mipmap: 1 (old), 1 (new), 0 (No change)
  • Plurals: 10 (old), 10 (new), 0 (No change)
  • String: 783 (old), 786 (new), 3 (Added):
    • string/profile_selection_add_profile_text (added)
    • string/profile_selection_header (added)
    • string/profile_selection_profile_icon_description (added)
  • Style: 472 (old), 472 (new), 0 (No change)
  • Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

  • hdpi (same)
  • ldpi (same)
  • mdpi (same)
  • tvdpi (same)
  • xhdpi (same)
  • xxhdpi (same)
  • xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 30 KiB (Added)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 26 KiB (Added)
Method count: 116251 (old), 116433 (new), 182 (Added)
Resources: 5741 (old), 5776 (new), 35 (Added)

  • Color: 820 (old), 826 (new), 6 (Added)
  • Dimen: 778 (old), 789 (new), 11 (Added)
  • Drawable: 302 (old), 305 (new), 3 (Added)
  • Id: 1221 (old), 1231 (new), 10 (Added)
  • Layout: 343 (old), 345 (new), 2 (Added)
  • String: 783 (old), 786 (new), 3 (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 31 KiB (Added)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 25 KiB (Added)

Method count: 116251 (old), 116433 (new), 182 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5819 (new), 35 (Added)

  • Anim: 33 (old), 33 (new), 0 (No change)
  • Animator: 24 (old), 24 (new), 0 (No change)
  • Array: 14 (old), 14 (new), 0 (No change)
  • Attr: 888 (old), 888 (new), 0 (No change)
  • Bool: 8 (old), 8 (new), 0 (No change)
  • Color: 820 (old), 826 (new), 6 (Added):
    • color/color_def_charcoal (added)
    • color/color_def_ivory (added)
    • color/color_palette_profile_selection_background_color (added)
    • color/component_color_profile_icon_stroke_color (added)
    • color/component_color_profile_selection_background_color (added)
    • And 1 other
  • Dimen: 780 (old), 791 (new), 11 (Added):
    • dimen/profile_item_profile_icon_size (added)
    • dimen/profile_item_profile_picture_stroke_width (added)
    • dimen/profile_selection_fragment_header_text_size (added)
    • dimen/profile_selection_fragment_icon_margin (added)
    • dimen/profile_selection_fragment_icon_padding (added)
    • And 6 others
  • Drawable: 342 (old), 345 (new), 3 (Added):
    • drawable/ic_add (added)
    • drawable/ic_chevron_left (added)
    • drawable/ic_chevron_right (added)
  • Id: 1221 (old), 1231 (new), 10 (Added):
    • id/add_profile_button (added)
    • id/add_profile_prompt (added)
    • id/profile_avatar (added)
    • id/profile_item_container (added)
    • id/profile_list_scroll_left (added)
    • And 5 others
  • Integer: 32 (old), 32 (new), 0 (No change)
  • Interpolator: 11 (old), 11 (new), 0 (No change)
  • Layout: 343 (old), 345 (new), 2 (Added):
    • layout/profile_item (added)
    • layout/profile_selection_fragment (added)
  • Menu: 1 (old), 1 (new), 0 (No change)
  • Mipmap: 1 (old), 1 (new), 0 (No change)
  • Plurals: 10 (old), 10 (new), 0 (No change)
  • String: 783 (old), 786 (new), 3 (Added):
    • string/profile_selection_add_profile_text (added)
    • string/profile_selection_header (added)
    • string/profile_selection_profile_icon_description (added)
  • Style: 472 (old), 472 (new), 0 (No change)
  • Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

  • hdpi (same)
  • ldpi (same)
  • mdpi (same)
  • tvdpi (same)
  • xhdpi (same)
  • xxhdpi (same)
  • xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 30 KiB (Added)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 25 KiB (Added)
Method count: 116251 (old), 116433 (new), 182 (Added)
Resources: 5741 (old), 5776 (new), 35 (Added)

  • Color: 820 (old), 826 (new), 6 (Added)
  • Dimen: 778 (old), 789 (new), 11 (Added)
  • Drawable: 302 (old), 305 (new), 3 (Added)
  • Id: 1221 (old), 1231 (new), 10 (Added)
  • Layout: 343 (old), 345 (new), 2 (Added)
  • String: 783 (old), 786 (new), 3 (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

@BenHenning
Copy link
Member

Will need to take a look at this next week.

@theMr17 might you have capacity to take a review pass on this PR?

Copy link

oppiabot bot commented Nov 22, 2024

Hi @adhiamboperes, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Nov 22, 2024
Copy link

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 41 KiB (Added)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 32 KiB (Added)

Method count: 260157 (old), 260451 (new), 294 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6816 (old), 6860 (new), 44 (Added)

  • Anim: 43 (old), 43 (new), 0 (No change)
  • Animator: 26 (old), 26 (new), 0 (No change)
  • Array: 15 (old), 15 (new), 0 (No change)
  • Attr: 922 (old), 922 (new), 0 (No change)
  • Bool: 9 (old), 9 (new), 0 (No change)
  • Color: 967 (old), 975 (new), 8 (Added):
    • color/color_def_charcoal (added)
    • color/color_def_ivory (added)
    • color/color_palette_profile_selection_background_color (added)
    • color/color_palette_profile_selection_profile_icon_background_color (added)
    • color/component_color_profile_icon_stroke_color (added)
    • And 3 others
  • Dimen: 1048 (old), 1064 (new), 16 (Added):
    • dimen/profile_item_profile_icon_size (added)
    • dimen/profile_item_profile_picture_stroke_width (added)
    • dimen/profile_selection_activity_profile_icon_size (added)
    • dimen/profile_selection_fragment_header_text_size (added)
    • dimen/profile_selection_fragment_icon_margin (added)
    • And 11 others
  • Drawable: 380 (old), 383 (new), 3 (Added):
    • drawable/ic_add (added)
    • drawable/ic_chevron_left (added)
    • drawable/ic_chevron_right (added)
  • Id: 1275 (old), 1285 (new), 10 (Added):
    • id/add_profile_button (added)
    • id/add_profile_prompt (added)
    • id/profile_avatar (added)
    • id/profile_item_container (added)
    • id/profile_list_scroll_left (added)
    • And 5 others
  • Integer: 37 (old), 37 (new), 0 (No change)
  • Interpolator: 11 (old), 11 (new), 0 (No change)
  • Layout: 380 (old), 382 (new), 2 (Added):
    • layout/profile_item (added)
    • layout/profile_selection_fragment (added)
  • Menu: 3 (old), 3 (new), 0 (No change)
  • Mipmap: 1 (old), 1 (new), 0 (No change)
  • Plurals: 10 (old), 10 (new), 0 (No change)
  • Raw: 2 (old), 2 (new), 0 (No change)
  • String: 850 (old), 855 (new), 5 (Added):
    • string/profile_selection_add_icon_description (added)
    • string/profile_selection_add_profile_text (added)
    • string/profile_selection_admin_label (added)
    • string/profile_selection_header (added)
    • string/profile_selection_profile_icon_description (added)
  • Style: 831 (old), 831 (new), 0 (No change)
  • Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

  • hdpi (same)
  • ldpi (same)
  • mdpi (same)
  • tvdpi (same)
  • xhdpi (same)
  • xxhdpi (same)
  • xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 40 KiB (Added)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 31 KiB (Added)
Method count: 260157 (old), 260451 (new), 294 (Added)
Resources: 6766 (old), 6810 (new), 44 (Added)

  • Color: 967 (old), 975 (new), 8 (Added)
  • Dimen: 1044 (old), 1060 (new), 16 (Added)
  • Drawable: 335 (old), 338 (new), 3 (Added)
  • Id: 1275 (old), 1285 (new), 10 (Added)
  • Layout: 380 (old), 382 (new), 2 (Added)
  • String: 850 (old), 855 (new), 5 (Added)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 36 bytes (Added)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 2 bytes (Added)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 48 bytes (Added)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 48 bytes (Added)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 60 bytes (Added)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 1 bytes (Removed)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 36 bytes (Added)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 1 bytes (Removed)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 48 bytes (Added)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 1 bytes (Added)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 60 bytes (Added)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 5 bytes (Removed)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 30 KiB (Added)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 25 KiB (Added)

Method count: 116247 (old), 116427 (new), 180 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5819 (new), 35 (Added)

  • Anim: 33 (old), 33 (new), 0 (No change)
  • Animator: 24 (old), 24 (new), 0 (No change)
  • Array: 14 (old), 14 (new), 0 (No change)
  • Attr: 888 (old), 888 (new), 0 (No change)
  • Bool: 8 (old), 8 (new), 0 (No change)
  • Color: 820 (old), 826 (new), 6 (Added):
    • color/color_def_charcoal (added)
    • color/color_def_ivory (added)
    • color/color_palette_profile_selection_background_color (added)
    • color/component_color_profile_icon_stroke_color (added)
    • color/component_color_profile_selection_background_color (added)
    • And 1 other
  • Dimen: 780 (old), 791 (new), 11 (Added):
    • dimen/profile_item_profile_icon_size (added)
    • dimen/profile_item_profile_picture_stroke_width (added)
    • dimen/profile_selection_fragment_header_text_size (added)
    • dimen/profile_selection_fragment_icon_margin (added)
    • dimen/profile_selection_fragment_icon_padding (added)
    • And 6 others
  • Drawable: 342 (old), 345 (new), 3 (Added):
    • drawable/ic_add (added)
    • drawable/ic_chevron_left (added)
    • drawable/ic_chevron_right (added)
  • Id: 1221 (old), 1231 (new), 10 (Added):
    • id/add_profile_button (added)
    • id/add_profile_prompt (added)
    • id/profile_avatar (added)
    • id/profile_item_container (added)
    • id/profile_list_scroll_left (added)
    • And 5 others
  • Integer: 32 (old), 32 (new), 0 (No change)
  • Interpolator: 11 (old), 11 (new), 0 (No change)
  • Layout: 343 (old), 345 (new), 2 (Added):
    • layout/profile_item (added)
    • layout/profile_selection_fragment (added)
  • Menu: 1 (old), 1 (new), 0 (No change)
  • Mipmap: 1 (old), 1 (new), 0 (No change)
  • Plurals: 10 (old), 10 (new), 0 (No change)
  • String: 783 (old), 786 (new), 3 (Added):
    • string/profile_selection_add_profile_text (added)
    • string/profile_selection_header (added)
    • string/profile_selection_profile_icon_description (added)
  • Style: 472 (old), 472 (new), 0 (No change)
  • Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

  • hdpi (same)
  • ldpi (same)
  • mdpi (same)
  • tvdpi (same)
  • xhdpi (same)
  • xxhdpi (same)
  • xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 29 KiB (Added)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 22 KiB (Added)
Method count: 116247 (old), 116427 (new), 180 (Added)
Resources: 5741 (old), 5776 (new), 35 (Added)

  • Color: 820 (old), 826 (new), 6 (Added)
  • Dimen: 778 (old), 789 (new), 11 (Added)
  • Drawable: 302 (old), 305 (new), 3 (Added)
  • Id: 1221 (old), 1231 (new), 10 (Added)
  • Layout: 343 (old), 345 (new), 2 (Added)
  • String: 783 (old), 786 (new), 3 (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 30 KiB (Added)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 25 KiB (Added)

Method count: 116253 (old), 116433 (new), 180 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5819 (new), 35 (Added)

  • Anim: 33 (old), 33 (new), 0 (No change)
  • Animator: 24 (old), 24 (new), 0 (No change)
  • Array: 14 (old), 14 (new), 0 (No change)
  • Attr: 888 (old), 888 (new), 0 (No change)
  • Bool: 8 (old), 8 (new), 0 (No change)
  • Color: 820 (old), 826 (new), 6 (Added):
    • color/color_def_charcoal (added)
    • color/color_def_ivory (added)
    • color/color_palette_profile_selection_background_color (added)
    • color/component_color_profile_icon_stroke_color (added)
    • color/component_color_profile_selection_background_color (added)
    • And 1 other
  • Dimen: 780 (old), 791 (new), 11 (Added):
    • dimen/profile_item_profile_icon_size (added)
    • dimen/profile_item_profile_picture_stroke_width (added)
    • dimen/profile_selection_fragment_header_text_size (added)
    • dimen/profile_selection_fragment_icon_margin (added)
    • dimen/profile_selection_fragment_icon_padding (added)
    • And 6 others
  • Drawable: 342 (old), 345 (new), 3 (Added):
    • drawable/ic_add (added)
    • drawable/ic_chevron_left (added)
    • drawable/ic_chevron_right (added)
  • Id: 1221 (old), 1231 (new), 10 (Added):
    • id/add_profile_button (added)
    • id/add_profile_prompt (added)
    • id/profile_avatar (added)
    • id/profile_item_container (added)
    • id/profile_list_scroll_left (added)
    • And 5 others
  • Integer: 32 (old), 32 (new), 0 (No change)
  • Interpolator: 11 (old), 11 (new), 0 (No change)
  • Layout: 343 (old), 345 (new), 2 (Added):
    • layout/profile_item (added)
    • layout/profile_selection_fragment (added)
  • Menu: 1 (old), 1 (new), 0 (No change)
  • Mipmap: 1 (old), 1 (new), 0 (No change)
  • Plurals: 10 (old), 10 (new), 0 (No change)
  • String: 783 (old), 786 (new), 3 (Added):
    • string/profile_selection_add_profile_text (added)
    • string/profile_selection_header (added)
    • string/profile_selection_profile_icon_description (added)
  • Style: 472 (old), 472 (new), 0 (No change)
  • Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

  • hdpi (same)
  • ldpi (same)
  • mdpi (same)
  • tvdpi (same)
  • xhdpi (same)
  • xxhdpi (same)
  • xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 29 KiB (Added)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 22 KiB (Added)
Method count: 116253 (old), 116433 (new), 180 (Added)
Resources: 5741 (old), 5776 (new), 35 (Added)

  • Color: 820 (old), 826 (new), 6 (Added)
  • Dimen: 778 (old), 789 (new), 11 (Added)
  • Drawable: 302 (old), 305 (new), 3 (Added)
  • Id: 1221 (old), 1231 (new), 10 (Added)
  • Layout: 343 (old), 345 (new), 2 (Added)
  • String: 783 (old), 786 (new), 3 (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 30 KiB (Added)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 25 KiB (Added)

Method count: 116253 (old), 116433 (new), 180 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5819 (new), 35 (Added)

  • Anim: 33 (old), 33 (new), 0 (No change)
  • Animator: 24 (old), 24 (new), 0 (No change)
  • Array: 14 (old), 14 (new), 0 (No change)
  • Attr: 888 (old), 888 (new), 0 (No change)
  • Bool: 8 (old), 8 (new), 0 (No change)
  • Color: 820 (old), 826 (new), 6 (Added):
    • color/color_def_charcoal (added)
    • color/color_def_ivory (added)
    • color/color_palette_profile_selection_background_color (added)
    • color/component_color_profile_icon_stroke_color (added)
    • color/component_color_profile_selection_background_color (added)
    • And 1 other
  • Dimen: 780 (old), 791 (new), 11 (Added):
    • dimen/profile_item_profile_icon_size (added)
    • dimen/profile_item_profile_picture_stroke_width (added)
    • dimen/profile_selection_fragment_header_text_size (added)
    • dimen/profile_selection_fragment_icon_margin (added)
    • dimen/profile_selection_fragment_icon_padding (added)
    • And 6 others
  • Drawable: 342 (old), 345 (new), 3 (Added):
    • drawable/ic_add (added)
    • drawable/ic_chevron_left (added)
    • drawable/ic_chevron_right (added)
  • Id: 1221 (old), 1231 (new), 10 (Added):
    • id/add_profile_button (added)
    • id/add_profile_prompt (added)
    • id/profile_avatar (added)
    • id/profile_item_container (added)
    • id/profile_list_scroll_left (added)
    • And 5 others
  • Integer: 32 (old), 32 (new), 0 (No change)
  • Interpolator: 11 (old), 11 (new), 0 (No change)
  • Layout: 343 (old), 345 (new), 2 (Added):
    • layout/profile_item (added)
    • layout/profile_selection_fragment (added)
  • Menu: 1 (old), 1 (new), 0 (No change)
  • Mipmap: 1 (old), 1 (new), 0 (No change)
  • Plurals: 10 (old), 10 (new), 0 (No change)
  • String: 783 (old), 786 (new), 3 (Added):
    • string/profile_selection_add_profile_text (added)
    • string/profile_selection_header (added)
    • string/profile_selection_profile_icon_description (added)
  • Style: 472 (old), 472 (new), 0 (No change)
  • Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

  • hdpi (same)
  • ldpi (same)
  • mdpi (same)
  • tvdpi (same)
  • xhdpi (same)
  • xxhdpi (same)
  • xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 29 KiB (Added)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 23 KiB (Added)
Method count: 116253 (old), 116433 (new), 180 (Added)
Resources: 5741 (old), 5776 (new), 35 (Added)

  • Color: 820 (old), 826 (new), 6 (Added)
  • Dimen: 778 (old), 789 (new), 11 (Added)
  • Drawable: 302 (old), 305 (new), 3 (Added)
  • Id: 1221 (old), 1231 (new), 10 (Added)
  • Layout: 343 (old), 345 (new), 2 (Added)
  • String: 783 (old), 786 (new), 3 (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

1 similar comment
Copy link

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 41 KiB (Added)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 32 KiB (Added)

Method count: 260157 (old), 260451 (new), 294 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6816 (old), 6860 (new), 44 (Added)

  • Anim: 43 (old), 43 (new), 0 (No change)
  • Animator: 26 (old), 26 (new), 0 (No change)
  • Array: 15 (old), 15 (new), 0 (No change)
  • Attr: 922 (old), 922 (new), 0 (No change)
  • Bool: 9 (old), 9 (new), 0 (No change)
  • Color: 967 (old), 975 (new), 8 (Added):
    • color/color_def_charcoal (added)
    • color/color_def_ivory (added)
    • color/color_palette_profile_selection_background_color (added)
    • color/color_palette_profile_selection_profile_icon_background_color (added)
    • color/component_color_profile_icon_stroke_color (added)
    • And 3 others
  • Dimen: 1048 (old), 1064 (new), 16 (Added):
    • dimen/profile_item_profile_icon_size (added)
    • dimen/profile_item_profile_picture_stroke_width (added)
    • dimen/profile_selection_activity_profile_icon_size (added)
    • dimen/profile_selection_fragment_header_text_size (added)
    • dimen/profile_selection_fragment_icon_margin (added)
    • And 11 others
  • Drawable: 380 (old), 383 (new), 3 (Added):
    • drawable/ic_add (added)
    • drawable/ic_chevron_left (added)
    • drawable/ic_chevron_right (added)
  • Id: 1275 (old), 1285 (new), 10 (Added):
    • id/add_profile_button (added)
    • id/add_profile_prompt (added)
    • id/profile_avatar (added)
    • id/profile_item_container (added)
    • id/profile_list_scroll_left (added)
    • And 5 others
  • Integer: 37 (old), 37 (new), 0 (No change)
  • Interpolator: 11 (old), 11 (new), 0 (No change)
  • Layout: 380 (old), 382 (new), 2 (Added):
    • layout/profile_item (added)
    • layout/profile_selection_fragment (added)
  • Menu: 3 (old), 3 (new), 0 (No change)
  • Mipmap: 1 (old), 1 (new), 0 (No change)
  • Plurals: 10 (old), 10 (new), 0 (No change)
  • Raw: 2 (old), 2 (new), 0 (No change)
  • String: 850 (old), 855 (new), 5 (Added):
    • string/profile_selection_add_icon_description (added)
    • string/profile_selection_add_profile_text (added)
    • string/profile_selection_admin_label (added)
    • string/profile_selection_header (added)
    • string/profile_selection_profile_icon_description (added)
  • Style: 831 (old), 831 (new), 0 (No change)
  • Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

  • hdpi (same)
  • ldpi (same)
  • mdpi (same)
  • tvdpi (same)
  • xhdpi (same)
  • xxhdpi (same)
  • xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 40 KiB (Added)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 31 KiB (Added)
Method count: 260157 (old), 260451 (new), 294 (Added)
Resources: 6766 (old), 6810 (new), 44 (Added)

  • Color: 967 (old), 975 (new), 8 (Added)
  • Dimen: 1044 (old), 1060 (new), 16 (Added)
  • Drawable: 335 (old), 338 (new), 3 (Added)
  • Id: 1275 (old), 1285 (new), 10 (Added)
  • Layout: 380 (old), 382 (new), 2 (Added)
  • String: 850 (old), 855 (new), 5 (Added)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 36 bytes (Added)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 2 bytes (Added)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 48 bytes (Added)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 48 bytes (Added)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 60 bytes (Added)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 1 bytes (Removed)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 36 bytes (Added)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 1 bytes (Removed)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 48 bytes (Added)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 1 bytes (Added)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 60 bytes (Added)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 5 bytes (Removed)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 30 KiB (Added)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 25 KiB (Added)

Method count: 116247 (old), 116427 (new), 180 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5819 (new), 35 (Added)

  • Anim: 33 (old), 33 (new), 0 (No change)
  • Animator: 24 (old), 24 (new), 0 (No change)
  • Array: 14 (old), 14 (new), 0 (No change)
  • Attr: 888 (old), 888 (new), 0 (No change)
  • Bool: 8 (old), 8 (new), 0 (No change)
  • Color: 820 (old), 826 (new), 6 (Added):
    • color/color_def_charcoal (added)
    • color/color_def_ivory (added)
    • color/color_palette_profile_selection_background_color (added)
    • color/component_color_profile_icon_stroke_color (added)
    • color/component_color_profile_selection_background_color (added)
    • And 1 other
  • Dimen: 780 (old), 791 (new), 11 (Added):
    • dimen/profile_item_profile_icon_size (added)
    • dimen/profile_item_profile_picture_stroke_width (added)
    • dimen/profile_selection_fragment_header_text_size (added)
    • dimen/profile_selection_fragment_icon_margin (added)
    • dimen/profile_selection_fragment_icon_padding (added)
    • And 6 others
  • Drawable: 342 (old), 345 (new), 3 (Added):
    • drawable/ic_add (added)
    • drawable/ic_chevron_left (added)
    • drawable/ic_chevron_right (added)
  • Id: 1221 (old), 1231 (new), 10 (Added):
    • id/add_profile_button (added)
    • id/add_profile_prompt (added)
    • id/profile_avatar (added)
    • id/profile_item_container (added)
    • id/profile_list_scroll_left (added)
    • And 5 others
  • Integer: 32 (old), 32 (new), 0 (No change)
  • Interpolator: 11 (old), 11 (new), 0 (No change)
  • Layout: 343 (old), 345 (new), 2 (Added):
    • layout/profile_item (added)
    • layout/profile_selection_fragment (added)
  • Menu: 1 (old), 1 (new), 0 (No change)
  • Mipmap: 1 (old), 1 (new), 0 (No change)
  • Plurals: 10 (old), 10 (new), 0 (No change)
  • String: 783 (old), 786 (new), 3 (Added):
    • string/profile_selection_add_profile_text (added)
    • string/profile_selection_header (added)
    • string/profile_selection_profile_icon_description (added)
  • Style: 472 (old), 472 (new), 0 (No change)
  • Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

  • hdpi (same)
  • ldpi (same)
  • mdpi (same)
  • tvdpi (same)
  • xhdpi (same)
  • xxhdpi (same)
  • xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 29 KiB (Added)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 22 KiB (Added)
Method count: 116247 (old), 116427 (new), 180 (Added)
Resources: 5741 (old), 5776 (new), 35 (Added)

  • Color: 820 (old), 826 (new), 6 (Added)
  • Dimen: 778 (old), 789 (new), 11 (Added)
  • Drawable: 302 (old), 305 (new), 3 (Added)
  • Id: 1221 (old), 1231 (new), 10 (Added)
  • Layout: 343 (old), 345 (new), 2 (Added)
  • String: 783 (old), 786 (new), 3 (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 30 KiB (Added)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 25 KiB (Added)

Method count: 116253 (old), 116433 (new), 180 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5819 (new), 35 (Added)

  • Anim: 33 (old), 33 (new), 0 (No change)
  • Animator: 24 (old), 24 (new), 0 (No change)
  • Array: 14 (old), 14 (new), 0 (No change)
  • Attr: 888 (old), 888 (new), 0 (No change)
  • Bool: 8 (old), 8 (new), 0 (No change)
  • Color: 820 (old), 826 (new), 6 (Added):
    • color/color_def_charcoal (added)
    • color/color_def_ivory (added)
    • color/color_palette_profile_selection_background_color (added)
    • color/component_color_profile_icon_stroke_color (added)
    • color/component_color_profile_selection_background_color (added)
    • And 1 other
  • Dimen: 780 (old), 791 (new), 11 (Added):
    • dimen/profile_item_profile_icon_size (added)
    • dimen/profile_item_profile_picture_stroke_width (added)
    • dimen/profile_selection_fragment_header_text_size (added)
    • dimen/profile_selection_fragment_icon_margin (added)
    • dimen/profile_selection_fragment_icon_padding (added)
    • And 6 others
  • Drawable: 342 (old), 345 (new), 3 (Added):
    • drawable/ic_add (added)
    • drawable/ic_chevron_left (added)
    • drawable/ic_chevron_right (added)
  • Id: 1221 (old), 1231 (new), 10 (Added):
    • id/add_profile_button (added)
    • id/add_profile_prompt (added)
    • id/profile_avatar (added)
    • id/profile_item_container (added)
    • id/profile_list_scroll_left (added)
    • And 5 others
  • Integer: 32 (old), 32 (new), 0 (No change)
  • Interpolator: 11 (old), 11 (new), 0 (No change)
  • Layout: 343 (old), 345 (new), 2 (Added):
    • layout/profile_item (added)
    • layout/profile_selection_fragment (added)
  • Menu: 1 (old), 1 (new), 0 (No change)
  • Mipmap: 1 (old), 1 (new), 0 (No change)
  • Plurals: 10 (old), 10 (new), 0 (No change)
  • String: 783 (old), 786 (new), 3 (Added):
    • string/profile_selection_add_profile_text (added)
    • string/profile_selection_header (added)
    • string/profile_selection_profile_icon_description (added)
  • Style: 472 (old), 472 (new), 0 (No change)
  • Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

  • hdpi (same)
  • ldpi (same)
  • mdpi (same)
  • tvdpi (same)
  • xhdpi (same)
  • xxhdpi (same)
  • xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 29 KiB (Added)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 22 KiB (Added)
Method count: 116253 (old), 116433 (new), 180 (Added)
Resources: 5741 (old), 5776 (new), 35 (Added)

  • Color: 820 (old), 826 (new), 6 (Added)
  • Dimen: 778 (old), 789 (new), 11 (Added)
  • Drawable: 302 (old), 305 (new), 3 (Added)
  • Id: 1221 (old), 1231 (new), 10 (Added)
  • Layout: 343 (old), 345 (new), 2 (Added)
  • String: 783 (old), 786 (new), 3 (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 30 KiB (Added)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 25 KiB (Added)

Method count: 116253 (old), 116433 (new), 180 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5819 (new), 35 (Added)

  • Anim: 33 (old), 33 (new), 0 (No change)
  • Animator: 24 (old), 24 (new), 0 (No change)
  • Array: 14 (old), 14 (new), 0 (No change)
  • Attr: 888 (old), 888 (new), 0 (No change)
  • Bool: 8 (old), 8 (new), 0 (No change)
  • Color: 820 (old), 826 (new), 6 (Added):
    • color/color_def_charcoal (added)
    • color/color_def_ivory (added)
    • color/color_palette_profile_selection_background_color (added)
    • color/component_color_profile_icon_stroke_color (added)
    • color/component_color_profile_selection_background_color (added)
    • And 1 other
  • Dimen: 780 (old), 791 (new), 11 (Added):
    • dimen/profile_item_profile_icon_size (added)
    • dimen/profile_item_profile_picture_stroke_width (added)
    • dimen/profile_selection_fragment_header_text_size (added)
    • dimen/profile_selection_fragment_icon_margin (added)
    • dimen/profile_selection_fragment_icon_padding (added)
    • And 6 others
  • Drawable: 342 (old), 345 (new), 3 (Added):
    • drawable/ic_add (added)
    • drawable/ic_chevron_left (added)
    • drawable/ic_chevron_right (added)
  • Id: 1221 (old), 1231 (new), 10 (Added):
    • id/add_profile_button (added)
    • id/add_profile_prompt (added)
    • id/profile_avatar (added)
    • id/profile_item_container (added)
    • id/profile_list_scroll_left (added)
    • And 5 others
  • Integer: 32 (old), 32 (new), 0 (No change)
  • Interpolator: 11 (old), 11 (new), 0 (No change)
  • Layout: 343 (old), 345 (new), 2 (Added):
    • layout/profile_item (added)
    • layout/profile_selection_fragment (added)
  • Menu: 1 (old), 1 (new), 0 (No change)
  • Mipmap: 1 (old), 1 (new), 0 (No change)
  • Plurals: 10 (old), 10 (new), 0 (No change)
  • String: 783 (old), 786 (new), 3 (Added):
    • string/profile_selection_add_profile_text (added)
    • string/profile_selection_header (added)
    • string/profile_selection_profile_icon_description (added)
  • Style: 472 (old), 472 (new), 0 (No change)
  • Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

  • hdpi (same)
  • ldpi (same)
  • mdpi (same)
  • tvdpi (same)
  • xhdpi (same)
  • xxhdpi (same)
  • xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 29 KiB (Added)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 23 KiB (Added)
Method count: 116253 (old), 116433 (new), 180 (Added)
Resources: 5741 (old), 5776 (new), 35 (Added)

  • Color: 820 (old), 826 (new), 6 (Added)
  • Dimen: 778 (old), 789 (new), 11 (Added)
  • Drawable: 302 (old), 305 (new), 3 (Added)
  • Id: 1221 (old), 1231 (new), 10 (Added)
  • Layout: 343 (old), 345 (new), 2 (Added)
  • String: 783 (old), 786 (new), 3 (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Copy link
Collaborator

@theMr17 theMr17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adhiamboperes, and apologies for the delayed review. I have left some comments, PTAL.

Additionally, I’m unsure why the old presenter is named v1. Shouldn’t it be the other way around?

@@ -23,4 +23,3 @@ android.enableJetifier=false
kotlin.code.style=official
# Needed to enable Android data binding.
android.databinding.enableV2=true

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this formatting change.

Comment on lines 235 to +236
.setProfileNickname(testProfileNickname)
.setParentScreen(IntroActivityParams.ParentScreen.CREATE_PROFILE_SCREEN)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testProfileNickname is being indirectly tested by testFragment_explanationText_isDisplayed. Is there a way to verify the parent screen as well?

Comment on lines -19 to +20
/** The ViewModel for [ProfileChooserFragment]. */
/** The ViewModel for [ProfileActionChooserFragment]. */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the ProfileActionChooserFragment going to be introduced in another PR? I couldn't find it.

Comment on lines +249 to +264
profileManagementController.loginToProfile(profile.id).toLiveData().observe(
fragment,
{
if (it is AsyncResult.Success) {
if (enableMultipleClassrooms.value) {
activity.startActivity(
ClassroomListActivity.createClassroomListActivity(activity, profile.id)
)
} else {
activity.startActivity(
HomeActivity.createHomeActivity(activity, profile.id)
)
}
}
}
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lambda argument can be moved out of the observe function. Ditto for other observers in the both the old and new presenters.

@@ -857,7 +858,7 @@ class ProfileManagementController @Inject constructor(
profileId: ProfileId,
profileType: ProfileType,
avatarImagePath: Uri?,
colorRgb: Int,
colorRgb: Int?,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under what circumstances could colorRgb be null?

)
)
} else {
activity.startActivity(
AdminAuthActivity.createAdminAuthActivityIntent(
activity,
chooserViewModel.adminPin,
chooserViewModel.adminProfileId.internalId,
0,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
0,
profileId = 0,

Nit.

)
binding.apply {

binding = ProfileSelectionFragmentBinding.inflate(inflater, container, false).apply {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
binding = ProfileSelectionFragmentBinding.inflate(inflater, container, false).apply {
binding = ProfileSelectionFragmentBinding.inflate(inflater, container, /* attachToRoot= */ false).apply {

Nit.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a separate landscape layout for this? It seems the primary difference lies only in the root layout.

Comment on lines +67 to +68
<ImageView
android:id="@+id/profile_chooser_setting_icon"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the screenshots, it seems we need to add some left margin to the icon on the portrait layout, perhaps the same amount as the bottom margin.

@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Nov 29, 2024
@oppiabot oppiabot bot unassigned theMr17 Nov 29, 2024
Copy link

oppiabot bot commented Nov 29, 2024

Unassigning @theMr17 since the review is done.

Copy link

oppiabot bot commented Nov 29, 2024

Hi @adhiamboperes, it looks like some changes were requested on this pull request by @theMr17. PTAL. Thanks!

Base automatically changed from onboarding-profile-domain-config to develop November 29, 2024 10:58
# Conflicts:
#	app/src/main/java/org/oppia/android/app/drawer/ExitProfileDialogFragment.kt
# Conflicts:
#	app/src/main/java/org/oppia/android/app/classroom/ClassroomListFragmentPresenter.kt
#	app/src/main/java/org/oppia/android/app/home/HomeFragmentPresenter.kt
#	app/src/main/java/org/oppia/android/app/onboarding/IntroFragmentPresenter.kt
#	app/src/main/java/org/oppia/android/app/profile/ProfileChooserFragmentPresenter.kt
#	app/src/main/java/org/oppia/android/app/splash/SplashActivityPresenter.kt
#	app/src/sharedTest/java/org/oppia/android/app/classroom/ClassroomListFragmentTest.kt
#	app/src/sharedTest/java/org/oppia/android/app/profile/ProfileChooserFragmentTest.kt
#	app/src/sharedTest/java/org/oppia/android/app/splash/SplashActivityTest.kt
#	app/src/test/java/org/oppia/android/app/home/HomeActivityLocalTest.kt
#	domain/src/test/java/org/oppia/android/domain/profile/ProfileManagementControllerTest.kt
#	testing/src/main/java/org/oppia/android/testing/profile/ProfileTestHelper.kt
Copy link

Coverage Report

Results

Number of files assessed: 18
Overall Coverage: 0.00%
Coverage Analysis: PASS

Exempted coverage

Files exempted from coverage
File Exemption Reason
ViewBindingShimImpl.ktapp/src/main/java/org/oppia/android/app/shim/ViewBindingShimImpl.kt
This file is exempted from having a test file; skipping coverage check.
ViewBindingShim.ktapp/src/main/java/org/oppia/android/app/shim/ViewBindingShim.kt
This file is exempted from having a test file; skipping coverage check.
ViewComponentImpl.ktapp/src/main/java/org/oppia/android/app/view/ViewComponentImpl.kt
This file is exempted from having a test file; skipping coverage check.
StartSnapHelper.ktapp/src/main/java/org/oppia/android/app/recyclerview/StartSnapHelper.kt
This file is exempted from having a test file; skipping coverage check.
CreateProfileFragmentPresenter.ktapp/src/main/java/org/oppia/android/app/onboarding/CreateProfileFragmentPresenter.kt
This file is exempted from having a test file; skipping coverage check.
IntroActivityPresenter.ktapp/src/main/java/org/oppia/android/app/onboarding/IntroActivityPresenter.kt
This file is exempted from having a test file; skipping coverage check.
IntroFragment.ktapp/src/main/java/org/oppia/android/app/onboarding/IntroFragment.kt
This file is incompatible with code coverage tooling; skipping coverage check.
IntroFragmentPresenter.ktapp/src/main/java/org/oppia/android/app/onboarding/IntroFragmentPresenter.kt
This file is exempted from having a test file; skipping coverage check.
IntroActivity.ktapp/src/main/java/org/oppia/android/app/onboarding/IntroActivity.kt
This file is incompatible with code coverage tooling; skipping coverage check.
CreateProfileFragment.ktapp/src/main/java/org/oppia/android/app/onboarding/CreateProfileFragment.kt
This file is incompatible with code coverage tooling; skipping coverage check.
ProfileChooserFragment.ktapp/src/main/java/org/oppia/android/app/profile/ProfileChooserFragment.kt
This file is incompatible with code coverage tooling; skipping coverage check.
ProfileChooserFragmentPresenter.ktapp/src/main/java/org/oppia/android/app/profile/ProfileChooserFragmentPresenter.kt
This file is exempted from having a test file; skipping coverage check.
ProfileItemViewModel.ktapp/src/main/java/org/oppia/android/app/profile/ProfileItemViewModel.kt
This file is exempted from having a test file; skipping coverage check.
ProfileChooserViewModel.ktapp/src/main/java/org/oppia/android/app/profile/ProfileChooserViewModel.kt
This file is exempted from having a test file; skipping coverage check.
ProfileListView.ktapp/src/main/java/org/oppia/android/app/profile/ProfileListView.kt
This file is exempted from having a test file; skipping coverage check.
ProfileChooserFragmentPresenterV1.ktapp/src/main/java/org/oppia/android/app/profile/ProfileChooserFragmentPresenterV1.kt
This file is exempted from having a test file; skipping coverage check.
ProfileClickListener.ktapp/src/main/java/org/oppia/android/app/profile/ProfileClickListener.kt
This file is exempted from having a test file; skipping coverage check.
ProfileManagementController.ktdomain/src/main/java/org/oppia/android/domain/profile/ProfileManagementController.kt
This file is incompatible with code coverage tooling; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating multiple user not working with profile pic
4 participants