From bee2b587a1a81c4ca7ae288923aca37f720dc6cf Mon Sep 17 00:00:00 2001 From: Deon Olarewaju Date: Tue, 5 Dec 2023 01:59:58 +0100 Subject: [PATCH] Fix #5231: "Implied quantity lint warning in pt-rBR strings" (#5259) ## Explanation Fix #5231 1. Replaced quantity "one" with %s at warnings of implied quantity in pt-rBR strings. 2. Removed new line formats. Screenshot 2023-12-04 at 21 22 46 Before ![Screenshot 2023-12-04 at 20 50 19](https://github.com/oppia/oppia-android/assets/54560535/a6118bc9-6592-49b8-a17a-e9d0995edda2) After ![Screenshot 2023-12-04 at 20 50 29](https://github.com/oppia/oppia-android/assets/54560535/aefeba2d-9b13-4db2-9a2a-8dd665f8e476) ## Essential Checklist - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). ## For UI-specific PRs only If your PR includes UI-related changes, then: - Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes - For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see [RTL guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines)) - Add a video showing the full UX flow with a screen reader enabled (see [accessibility guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide)) - For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included - Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing --- app/src/main/res/values-pt-rBR/strings.xml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/app/src/main/res/values-pt-rBR/strings.xml b/app/src/main/res/values-pt-rBR/strings.xml index f67bc1b4878..8827a8e5a7d 100644 --- a/app/src/main/res/values-pt-rBR/strings.xml +++ b/app/src/main/res/values-pt-rBR/strings.xml @@ -185,28 +185,28 @@ Correto! Tópico: %s - 1 Capítulo\n - \n %s Capítulos\n + %s Capítulo + %s Capítulos - 1 História\n - \n %s Histórias\n + %s História + %s Histórias %s de %s Capítulo Concluído %s de %s Capítulos Concluídos - 1 Lição\n - \n %s Lições\n + %s Lição + %s Lições - 1 história concluída + %s história concluída %s Histórias concluídas %s Histórias concluídas - 1 Tópico em andamento + %s Tópico em andamento %s Tópicos em andamento %s Tópicos em andamento