New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spans are not sent to Zipkin sender when an error is thrown from a Sidekiq worker #172

Open

ghost opened this issue Mar 11, 2020 · 2 comments

ghost commented Mar 11, 2020

When an error bubbles up from this line the trace spans are never flushed
https://github.com/openzipkin/zipkin-ruby/blob/master/lib/zipkin-tracer/sidekiq/middleware.rb#L31

This results in spans missing from the trace context in a Zipkin UI.

Was this behavior intentional?

Contributor

jfeltesse-mdsol commented Mar 12, 2020

as the author of that middleware, @ayrat555 might be able to answer that question

Contributor

ayrat555 commented Mar 12, 2020

@brandon-zeeb-nw I think rescue (or ensure clause should be added to the middleware and send traces with exceptions there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment