Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X-B3-ParentSpanId should be optional in propagation #1357

Open
gviczai opened this issue Jan 12, 2023 · 0 comments
Open

X-B3-ParentSpanId should be optional in propagation #1357

gviczai opened this issue Jan 12, 2023 · 0 comments
Labels

Comments

@gviczai
Copy link

gviczai commented Jan 12, 2023

When using separate headers (MULTI mode) in request as input to Brave propagation, all the X-B3-TraceId, X-B3-SpanId and X-B3-ParentSpanId headers are mandatory, otherwise not processed, because of this condition triplet:
https://github.com/openzipkin/brave/blob/5.14.1/brave/src/main/java/brave/propagation/B3Propagation.java#L320-L322

Whereas if propagation uses SINGLE mode, it accepts a header like this:
b3: 3918a670ff714ce592959c91b0a8cbcb-e506eba76ec9cfff-1
Which is correct, as of https://github.com/openzipkin/b3-propagation#single-header which states that "...the last two fields are optional".
I think this should be the case when the values arrive as separated headers as well.

@gviczai gviczai added the bug label Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant