Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep track of recipe's changes #498

Open
kelson42 opened this issue Jun 15, 2020 · 8 comments
Open

Keep track of recipe's changes #498

kelson42 opened this issue Jun 15, 2020 · 8 comments

Comments

@kelson42
Copy link
Contributor

kelson42 commented Jun 15, 2020

For the moment, we don't really keep track of changes on recipes (or this is not visible for end-users). We don't have any "audit trail". This has two major consequences:

  • The transparency about who, when, why, what is not secured
  • Considering that this is a tool which is a bit technical, there is no way to learn from the changes that other users made.

It would be great to have a kind of revision log (like on Mediawiki).

Keeping track of each revision in json format and having a diff display between revisions would be really helpful.

I'm in favour as well to keep a big more information about each revision like:

  • Comment about the revision (optional)
  • Author of the revision
  • Date
  • What has been done
@rgaudin
Copy link
Member

rgaudin commented Jun 15, 2020

Would the comment be mandatory? I'd advise not to.

@kelson42
Copy link
Contributor Author

Would the comment be mandatory? I'd advise not to.

Yes, but might help to explain why things have been done. Not always obvious.

@rgaudin
Copy link
Member

rgaudin commented Jun 15, 2020

OK, can't wait to see your ticket asking to make it not-mandatory 😀

@stale
Copy link

stale bot commented Aug 14, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Aug 14, 2020
@kelson42
Copy link
Contributor Author

A system working in a similar manner like the Gandi DNS zone revision system would be fine.

@stale stale bot removed the stale label Mar 23, 2022
@stale
Copy link

stale bot commented Jun 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@kelson42
Copy link
Contributor Author

I think this ticket start to be really super urgent because:

  • We are more and more people editing in the Zimfarm
  • Rules are complext and learning curve is long
  • We need more visibility on who does what to be able to better control/fix/learn

We need IMO this very same feature on the CMS.

In term of architecture I would:

  • Each time a modification is made we should save in addition the username + comment (mandatory)
  • Save full JSON (compressed) of new version of each recipe in a dedicated table
  • Display a new tab "History" on recipes allowing to make a diff
  • We need a global "recent change" system (a feed on it would be even better.

@stale
Copy link

stale bot commented May 26, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants