Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"requested" events are not handled properly #1018

Open
benoit74 opened this issue Sep 19, 2024 · 0 comments
Open

"requested" events are not handled properly #1018

benoit74 opened this issue Sep 19, 2024 · 0 comments
Assignees
Labels

Comments

@benoit74
Copy link
Collaborator

While the task_event_handler method of utils.py is called properly with the requested event type when a task is requested, this type of event is not handled properly.

See e.g. https://kiwixorg.grafana.net/explore?schemaVersion=1&panes=%7B%22yh9%22:%7B%22datasource%22:%22grafanacloud-logs%22,%22queries%22:%5B%7B%22refId%22:%22A%22,%22expr%22:%22%7Bnamespace%3D%5C%22zimit%5C%22%7D%20%7C%20pod%20%3D~%20%60api-deployment.%2A%60%20%7C%3D%20%60Other%20event%60%22,%22queryType%22:%22range%22,%22datasource%22:%7B%22type%22:%22loki%22,%22uid%22:%22grafanacloud-logs%22%7D,%22editorMode%22:%22builder%22%7D%5D,%22range%22:%7B%22from%22:%22now-6h%22,%22to%22:%22now%22%7D%7D%7D&orgId=1


2024-09-19 08:44:01.070	INFO:common.utils:Other event: requested
2024-09-19 08:44:01.070	INFO:common.utils:Other event, task_id: 998ee636-a257-4182-af10-b89c3618e332
2024-09-19 08:44:01.070	INFO:common.utils:Other event, payload keys: []
2024-09-19 11:06:43.148	INFO:common.utils:Other event: requested
2024-09-19 11:06:43.148	INFO:common.utils:Other event, task_id: 6030617d-a1ed-4a36-b682-4039d0bd9a07
2024-09-19 11:06:43.148	INFO:common.utils:Other event, payload keys: []
2024-09-19 11:17:23.238	INFO:common.utils:Other event: requested
2024-09-19 11:17:23.238	INFO:common.utils:Other event, task_id: 072a0e37-dd6b-490b-b7ba-186b6f1e1107
2024-09-19 11:17:23.238	INFO:common.utils:Other event, payload keys: []
2024-09-19 11:34:07.456	INFO:common.utils:Other event: requested
2024-09-19 11:34:07.456	INFO:common.utils:Other event, task_id: d65b1895-b9d3-4f49-a756-bad981776733
2024-09-19 11:34:07.456	INFO:common.utils:Other event, payload keys: []
2024-09-19 12:46:11.937	INFO:common.utils:Other event: requested
2024-09-19 12:46:11.937	INFO:common.utils:Other event, task_id: 6a915bef-64f7-44ae-ad0f-9a54726c027a
2024-09-19 12:46:11.937	INFO:common.utils:Other event, payload keys: []
2024-09-19 13:45:10.774	INFO:common.utils:Other event: requested
2024-09-19 13:45:10.774	INFO:common.utils:Other event, task_id: e706d6bc-004f-49f4-9199-1b82f986c7f5
2024-09-19 13:45:10.774	INFO:common.utils:Other event, payload keys: []
2024-09-19 13:51:04.160	INFO:common.utils:Other event: requested
2024-09-19 13:51:04.160	INFO:common.utils:Other event, task_id: 4e2d7577-8250-4e1e-b31c-b8925975da67
2024-09-19 13:51:04.161	INFO:common.utils:Other event, payload keys: []
2024-09-19 13:57:44.860	INFO:common.utils:Other event: requested
2024-09-19 13:57:44.860	INFO:common.utils:Other event, task_id: 4b8c5230-ba85-42cb-b457-88cf2530a272
2024-09-19 13:57:44.860	INFO:common.utils:Other event, payload keys: []
2024-09-19 14:13:42.870	INFO:common.utils:Other event: requested
2024-09-19 14:13:42.870	INFO:common.utils:Other event, task_id: acd2140a-8e4f-42c2-b157-9a9143c4f201
2024-09-19 14:13:42.871	INFO:common.utils:Other event, payload keys: []
2024-09-19 14:13:52.589	INFO:common.utils:Other event: requested
2024-09-19 14:13:52.589	INFO:common.utils:Other event, task_id: 9f881c2c-bb70-4898-beae-fb993c003d31
2024-09-19 14:13:52.589	INFO:common.utils:Other event, payload keys: []

This has a consequence in zimit-frontend: openzim/zimit-frontend#74

I suggest that we add this event to the list of handlers function, and the function does nothing: no log, no state change, just it exists so that we can enrich it if needed AND notifications are properly called so solve zimit-frontend issue.

@benoit74 benoit74 added the bug label Sep 19, 2024
@benoit74 benoit74 self-assigned this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant