Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zim files created in dev should default to manual refresh #1009

Open
Popolechien opened this issue Aug 12, 2024 · 2 comments
Open

Zim files created in dev should default to manual refresh #1009

Popolechien opened this issue Aug 12, 2024 · 2 comments

Comments

@Popolechien
Copy link
Contributor

The typical manner to create a new recipe is to copy an exisiting one, change the parameters and assign it to dev. It happens quite often that one forgets to change the update settings and leave it to monthly, meaning that if the recipe is not successful and not moved to PROD it may keep on generating new zim files every month, potentially clogging the dev repo (by "not successful" I understand that a zim is produced, but does not meet quality requirements and thus could be considered junk).

Now the typical fix for that would be to say "check your parameters", but I think having a harder check, i.e. the periodicityparameter automatically change to manual as soon as the warehouse path is set to /.hidden/dev would be much more efficient.

@benoit74
Copy link
Collaborator

benoit74 commented Aug 12, 2024

I agree that something needs to be done, but I'm not sure the solution proposed is adequate.

If one forgets to set the periodicity to manual when in dev and the software is modified to do this change automatically, then I'm pretty sure that the periodicity will stay to manual once move to prod, so we will only have moved the problem.

Sorry that this comment does not propose an alternative.

@benoit74
Copy link
Collaborator

Maybe implementing warnings in the UI would help:

  • warn when a recipe is configured in dev and periodicity is not set to manual
  • warn when a recipe is configured in prod and periodicity is manual

I can see many other use cases for such warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants