Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress webm file in media content e2e test #1944

Merged

Conversation

VadimKovalenkoSNF
Copy link
Collaborator

@VadimKovalenkoSNF VadimKovalenkoSNF commented Nov 10, 2023

Workaround for #1943

Problem:
vp9.webm file is no longer present in the I namespace, probably it shouldn't.

Workaround:
Temporarily disabled any vp9.webm checks till the root cause is found.

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (99842b0) 73.27% compared to head (0e7d59a) 76.34%.
Report is 17 commits behind head on main.

❗ Current head 0e7d59a differs from pull request most recent head 5c45741. Consider uploading reports for the commit 5c45741 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1944      +/-   ##
==========================================
+ Coverage   73.27%   76.34%   +3.07%     
==========================================
  Files          39       37       -2     
  Lines        3106     2985     -121     
  Branches      687      653      -34     
==========================================
+ Hits         2276     2279       +3     
+ Misses        711      611     -100     
+ Partials      119       95      -24     
Files Coverage Δ
src/mwoffliner.lib.ts 74.81% <100.00%> (+0.09%) ⬆️
src/util/const.ts 100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42
Copy link
Collaborator

What is the explanation about:

  • The problem?
  • The solution/workaround?

@VadimKovalenkoSNF
Copy link
Collaborator Author

@kelson42 I updated PR description.

@kelson42 kelson42 force-pushed the I1931-suppress-webm-element-in-multimedia-test branch from b0df307 to 0e7d59a Compare November 10, 2023 14:03
Copy link
Collaborator

@kelson42 kelson42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but there is a real bug somehwere either in Mediawiki or in MWoffliner

@kelson42
Copy link
Collaborator

@VadimKovalenkoSNF please fix conflict and merge

@VadimKovalenkoSNF VadimKovalenkoSNF force-pushed the I1931-suppress-webm-element-in-multimedia-test branch 2 times, most recently from 5bd9260 to 476f29d Compare November 13, 2023 19:39
@VadimKovalenkoSNF VadimKovalenkoSNF force-pushed the I1931-suppress-webm-element-in-multimedia-test branch from 476f29d to 5c45741 Compare November 13, 2023 19:50
@VadimKovalenkoSNF VadimKovalenkoSNF merged commit cb4f7a2 into main Nov 13, 2023
4 checks passed
@VadimKovalenkoSNF VadimKovalenkoSNF deleted the I1931-suppress-webm-element-in-multimedia-test branch November 13, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants