Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index pages for suggestions and full-text search #50

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

benoit74
Copy link
Contributor

We need to create redirect entries in the ZIM so that title and content are properly indexed for both suggestions and full-text search to work properly.

@benoit74 benoit74 self-assigned this Oct 29, 2024
@benoit74 benoit74 force-pushed the populate_search_indexes branch from 4b51e41 to 0b33ccb Compare October 29, 2024 07:46
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 46.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 37.79%. Comparing base (bc02d11) to head (e69b833).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
scraper/src/mindtouch2zim/processor.py 28.57% 5 Missing ⚠️
scraper/src/mindtouch2zim/client.py 33.33% 2 Missing ⚠️
scraper/src/mindtouch2zim/html.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
+ Coverage   37.66%   37.79%   +0.12%     
==========================================
  Files           9       10       +1     
  Lines         677      688      +11     
  Branches       84       84              
==========================================
+ Hits          255      260       +5     
- Misses        420      426       +6     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 marked this pull request as ready for review October 29, 2024 07:53
@benoit74 benoit74 requested a review from rgaudin October 29, 2024 07:53
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

scraper/src/mindtouch2zim/processor.py Show resolved Hide resolved
Base automatically changed from retry_web_calls to main October 29, 2024 16:18
@benoit74 benoit74 force-pushed the populate_search_indexes branch from 0b33ccb to e69b833 Compare October 29, 2024 16:22
@benoit74 benoit74 merged commit 607b60f into main Oct 29, 2024
10 checks passed
@benoit74 benoit74 deleted the populate_search_indexes branch October 29, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants