Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore private pages and their children #48

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Ignore private pages and their children #48

merged 1 commit into from
Oct 29, 2024

Conversation

benoit74
Copy link
Contributor

Fix #47

@benoit74 benoit74 self-assigned this Oct 28, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 5.26316% with 18 lines in your changes missing coverage. Please review.

Project coverage is 37.57%. Comparing base (118dab7) to head (d331b1a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
scraper/src/mindtouch2zim/processor.py 5.26% 18 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
- Coverage   38.44%   37.57%   -0.88%     
==========================================
  Files           9        9              
  Lines         658      676      +18     
  Branches       80       84       +4     
==========================================
+ Hits          253      254       +1     
- Misses        403      420      +17     
  Partials        2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 marked this pull request as ready for review October 28, 2024 13:06
@benoit74 benoit74 requested a review from rgaudin October 28, 2024 13:06
rgaudin
rgaudin approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from handle_videos_iframes to main October 29, 2024 15:35
@benoit74 benoit74 merged commit a2b3708 into main Oct 29, 2024
9 of 10 checks passed
@benoit74 benoit74 deleted the private_pages branch October 29, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgaudin rgaudin rgaudin approved these changes

Assignees

@benoit74 benoit74

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not ZIM non-public/private pages and their children
2 participants
@benoit74 @rgaudin