Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle pages title and favicon #41

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Handle pages title and favicon #41

merged 4 commits into from
Oct 28, 2024

Conversation

benoit74
Copy link
Contributor

Fix #23

Changes:

  • add --illustration to pass URL to illustration to use as ZIM illustration and favicon
  • if no --illustration is passed, try to guess best illustration from homepage favicon(s) (preferring apple icon which is bigger than favicons)
  • handle conversion to PNG (including for SVG) and resize to 48x48 for ZIM illustration
  • handle conversion to ICO and resize to 32x32 for favicon
  • add warning about issues on dev server around assets with question mark
  • update page title when navigation in the UI
  • add navigation back to home when main logo is clicked

@benoit74 benoit74 self-assigned this Oct 25, 2024
Base automatically changed from stats_progress to main October 25, 2024 12:15
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 35 lines in your changes missing coverage. Please review.

Project coverage is 39.54%. Comparing base (e03c789) to head (deebfa3).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
scraper/src/mindtouch2zim/processor.py 20.00% 32 Missing ⚠️
scraper/src/mindtouch2zim/client.py 50.00% 2 Missing ⚠️
scraper/src/mindtouch2zim/entrypoint.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
- Coverage   40.54%   39.54%   -1.01%     
==========================================
  Files           8        8              
  Lines         582      612      +30     
  Branches       70       71       +1     
==========================================
+ Hits          236      242       +6     
- Misses        344      368      +24     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 marked this pull request as ready for review October 25, 2024 12:20
@benoit74 benoit74 requested a review from rgaudin October 25, 2024 12:20
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

scraper/src/mindtouch2zim/processor.py Outdated Show resolved Hide resolved
scraper/src/mindtouch2zim/processor.py Outdated Show resolved Hide resolved
@benoit74 benoit74 merged commit a732a8a into main Oct 28, 2024
10 checks passed
@benoit74 benoit74 deleted the title_favicon branch October 28, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set proper title and favicon
2 participants