Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better UI : videos pages #54

Open
benoit74 opened this issue Oct 12, 2023 · 3 comments
Open

Better UI : videos pages #54

benoit74 opened this issue Oct 12, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@benoit74
Copy link
Collaborator

benoit74 commented Oct 12, 2023

This is a subtask of #42

Provide an enhanced UI of videos pages, based on Endless UI (e.g https://key.endlessos.org/en/explore/#/topics/c9d7f950ab6b5a1199e3d6c10d7f0103).

videos assets should be placed in a ./videos subfolder in the ZIM

@benoit74 benoit74 added the enhancement New feature or request label Oct 12, 2023
@benoit74 benoit74 mentioned this issue Oct 19, 2023
@ayushanand308
Copy link

Would like to work on this.

@githyuvi
Copy link
Contributor

githyuvi commented Mar 8, 2024

@benoit74 As per my understanding, for non topic content, each slug is basically a html generated by Jinja.

  1. We need to make additions in scraper to generate jsons for Non topics content which should have urls to the resources
  2. Create Vue components based on endless UI to display them.

Please guide me whether it will be an optimal approach.

@benoit74
Copy link
Collaborator Author

benoit74 commented Mar 8, 2024

@ayushanand308 this is probably not the easier issue to solve, please confirm you've at least achieved to start the scraper in new_ui branch and performed a first run on a selection of nodes of a given channel. You should probably try this on one minimal test channel since this is where you will find all kind of content.

@githyuvi yes, you understood the idea. It is the same idea for all kind of nodes (videos here, but also exercises, HTML5 content, audio, HTML document, and ePub and PDF

You will probably need more than url to the video in the JSON file (e.g. video title, ...), I don't recall the exact final information you will need.

You could either have one JSON per video node as you said (but it means many very small files, but we probably do not care) or we could bundle all of them in a single file (might be too big for nothing when you only want to play one video). To be analyzed / discussed.

@ayushanand308 @githyuvi please synchronize on who will work on which issue, as you see there is many different kind of nodes where the same kind of work is needed, you could definitely split the work. You could probably discuss this together on Kiwix Slack if you want (do not discuss it here please, this issue is not a live chat). @ayushanand308 could even benefit from the good understanding @githyuvi already got on this scraper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants