Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep track of title configuration changes #83

Open
kelson42 opened this issue Jul 3, 2022 · 7 comments
Open

Keep track of title configuration changes #83

kelson42 opened this issue Jul 3, 2022 · 7 comments
Labels
enhancement New feature or request stale
Milestone

Comments

@kelson42
Copy link
Contributor

kelson42 commented Jul 3, 2022

Similar to openzim/zimfarm#498. Wee nee

An other point is that if someone renames a ZIM file in the storage backend we should keep track of that as well... even if the configuration has not formally changed!

@kelson42 kelson42 added the enhancement New feature or request label Jul 3, 2022
@kelson42 kelson42 added this to the M3 milestone Jul 3, 2022
@rgaudin
Copy link
Member

rgaudin commented Jul 3, 2022

First part is understood and much needed but the second part either I did not understand or it's not possible.

If you want the CMS to adjust itself to a file rename on the storage backend, this won't happen.
Once files are managed by cms, files operations should go through cms.

@kelson42
Copy link
Contributor Author

kelson42 commented Jul 3, 2022

The second point is about #82 scenario, so about the CMS. I made a specific point about that because if we only track configuration changes, then such changes on the storage backend won’t be logged/tracked.

@rgaudin
Copy link
Member

rgaudin commented Jul 4, 2022

I understand the need but I believe given our resources, it seems a lot more practical/realistic/safer to just forbid ourselves from manipulating the storage backend directly instead of building/maintaining this.

@kelson42
Copy link
Contributor Author

kelson42 commented Jul 4, 2022

@rgaudin Agree, we still need a trace, a log entry when done from the CMS.

@rgaudin
Copy link
Member

rgaudin commented Jul 4, 2022

@rgaudin Agree, we still need a trace, a log entry when done from the CMS.

Already agreed in the beginning of my first comment… 🤷‍♂️

@kelson42
Copy link
Contributor Author

kelson42 commented Jul 9, 2022

See #76 for event logging

@stale
Copy link

stale bot commented Sep 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

2 participants