Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

udpxy: workaround bug introduced by SSM. #23191

Closed
wants to merge 1 commit into from
Closed

udpxy: workaround bug introduced by SSM. #23191

wants to merge 1 commit into from

Conversation

cgang
Copy link

@cgang cgang commented Jan 30, 2024

There is a bug introduced by SSM support, the source address
is uninitialized if it's not specified in command line argument.
It will cause UDP socket waiting for packet from random address,
and result in timeout in that case.

This patch is trying to workaround the bug in OpenWrt.

Signed-off-by: Gang Chen [email protected]

Maintainer: @neheb
Compile tested: Linksys E8450 mediatek/mt7622 OpenWrt 23.05.2
Run tested: Linksys E8450 mediatek/mt7622 OpenWrt 23.05.2

Description:
This bug can be reproduced with Linksys E8450 mediatek/mt7622 OpenWrt 23.05.2.

There is a bug introduced by SSM support, the source address
is uninitialized if it's not specified in command line argument.
It will cause UDP socket waiting for packet from random address,
and result in timeout in that case.

This patch is trying to workaround the bug in OpenWrt.

Signed-off-by: Gang Chen <[email protected]>
@neheb
Copy link
Contributor

neheb commented Feb 5, 2024

needs a PKG_RELEASE bump

@BKPepe
Copy link
Member

BKPepe commented Feb 7, 2024

  1. Needs Git header (Who is the author, commit description, commit subject), etc.

  2. Why do wee need to have this patch? Upstream it, if possible.

@cgang
Copy link
Author

cgang commented Feb 20, 2024

  1. Needs Git header (Who is the author, commit description, commit subject), etc.

udpxy: workaround bug introduced by SSM.

There is a bug introduced by SSM support, the source address
is uninitialized if it's not specified in command line argument.
It will cause UDP socket waiting for packet from random address,
and result in timeout in that case.

This patch is trying to workaround the bug in OpenWrt.

  1. Why do wee need to have this patch? Upstream it, if possible.

The udpxrec will crash on some device, such as Linksys E8450 without this fix.
I tried to request fix upstream, but looks like udpxy maintanence is inactive for couple of years.
See pcherenkov/udpxy#32

Comment on lines +1 to +2
--- a/chipmunk/udpxrec.c
+++ b/chipmunk/udpxrec.c
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please backport this patch as is from https://patch-diff.githubusercontent.com/raw/pcherenkov/udpxy/pull/32.patch it is possible that it will need to have refresh.

  2. It requires to bump PKG_RELEASE in the Makefile.

@cgang cgang closed this Mar 3, 2024
@cgang
Copy link
Author

cgang commented Mar 3, 2024

Hi @BKPepe
Seems @pcherenkov accept the fix, but I just realize there is a mistake in it.
pcherenkov/udpxy#33
Sorry for the regression issue and need to bother you again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants