tini: Fails to compile with docker and latest OpenWRT snapshot

[schuettecarsten]

FAILED: CMakeFiles/tini.dir/src/tini.c.o
/home/cschuette/openwrt/snapshot/openwrt/staging_dir/host/bin/ccache /home/cschuette/openwrt/snapshot/openwrt/staging_dir/toolchain-aarch64_cortex-a72_gcc-13.2.0_mu
sl/bin/aarch64-openwrt-linux-musl-gcc  -I/home/cschuette/openwrt/snapshot/openwrt/build_dir/target-aarch64_cortex-a72_musl/tini-0.19.0 -Os -pipe -g3 -fno-caller-sav
es -fno-plt -fhonour-copts -ffile-prefix-map=/home/cschuette/openwrt/snapshot/openwrt/build_dir/target-aarch64_cortex-a72_musl/tini-0.19.0=tini-0.19.0 -ffunction-se
ctions -fdata-sections -flto=auto -fno-fat-lto-objects -Wformat -Werror=format-security -fstack-protector -D_FORTIFY_SOURCE=1 -Wl,-z,now -Wl,-z,relro -std=gnu99 -We
rror -Wextra -Wall -pedantic-errors -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -DNDEBUG -MD -MT CMakeFiles/tini.dir/src/tini.c.o -MF CMakeFiles/tini.dir/src/tini.c.o.d -o CMakeFiles/tini.dir/src/tini.c.o -c /home/cschuette/openwrt/snapshot/openwrt/build_dir/target-aarch64_cortex-a72_musl/tini-0.19.0/src/tini.c
src/tini.c: In function 'print_usage':
src/tini.c:227:36: error: implicit declaration of function 'basename' [-Wimplicit-function-declaration]
  227 |         fprintf(file, "%s (%s)\n", basename(name), TINI_VERSION_STRING);
      |                                    ^~~~~~~~
src/tini.c:227:25: error: format '%s' expects argument of type 'char *', but argument 3 has type 'int' [-Werror=format=]
  227 |         fprintf(file, "%s (%s)\n", basename(name), TINI_VERSION_STRING);
      |                        ~^          ~~~~~~~~~~~~~~
      |                         |          |
      |                         char *     int
      |                        %d
src/tini.c:232:32: error: format '%s' expects argument of type 'char *', but argument 3 has type 'int' [-Werror=format=]
  232 |         fprintf(file, "Usage: %s [OPTIONS] PROGRAM -- [ARGS] | --version\n\n", basename(name));
      |                               ~^                                               ~~~~~~~~~~~~~~
      |                                |                                               |
      |                                char *                                          int
      |                               %d
src/tini.c:234:90: error: format '%s' expects argument of type 'char *', but argument 3 has type 'int' [-Werror=format=]
  234 |         fprintf(file, "Execute a program under the supervision of a valid init process (%s)\n\n", basename(name));
      |                                                                                         ~^        ~~~~~~~~~~~~~~
      |                                                                                          |        |
      |                                                                                          char *   int
      |                                                                                         %d
cc1: all warnings being treated as errors
ninja: build stopped: subcommand failed.
make[2]: *** [Makefile:46: /home/cschuette/openwrt/snapshot/openwrt/build_dir/target-aarch64_cortex-a72_musl/tini-0.19.0/.built] Error 1
make[2]: Leaving directory '/home/cschuette/openwrt/snapshot/openwrt/feeds/packages/utils/tini'
time: package/feeds/packages/tini/compile#0.16#0.03#0.18
    ERROR: package/feeds/packages/tini failed to build.
make[1]: *** [package/Makefile:129: package/feeds/packages/tini/compile] Error 1

[pesa1234]

I have same issue... need a fix with musl 1.2.5 openwrt/openwrt@87d7fa8

[schuettecarsten]

#23929

[pesa1234]

#23929

Thanks

[cyqtmxk]

same problem，thanks ！

[anonymous-one]

same :(

[mkevinstever]

Same on X86 target. : (

[anonymous-one]

bump! could we the the patch approved so all those (...many of us) using docker can go back to using the latest snapshots :D

thanks!

[BigSleezy00]

bump! could we the the patch approved so all those (...many of us) using docker can go back to using the latest snapshots :D

thanks!

I'm also in the x86 snapshot boat that's stuck here. My plex box needs the snapshot kernel and I'm dead in the water when I updated. I'm running a 13th gen i3 for the encoding. 23.05 doesn't recognize the igpu unfortunately. Specifically it's dockerd that can't compile without tini. But yeah, tough spot.

[anonymous-one]

what needs to be done for this to get merged? docker fails to install due to the missing dep and has so far close to 2 weeks now :/

[anonymous-one]

looks like we can (probably) close this.

ddd3794

should start seeing this in the builds in a day or two.

[schuettecarsten]

Fixed by ddd3794