Package flags not preserved on upgrade

[jck112]

Currently the auto_installed flag is cleared and the user flag is set whenever a package is upgraded. This prevents upgraded dependent packages from being removed with --autoremove.

For example on a NanoPi R4S running 23.05.2:

1. Installing vim installs the dependencies terminfo and libncurses6.

root@OpenWrt:~# opkg install vim
Installing vim (9.0-1) to root...
Downloading https://downloads.openwrt.org/releases/23.05.2/packages/aarch64_generic/packages/vim_9.0-1_aarch64_generic.ipk
Installing terminfo (6.4-2) to root...
Downloading https://downloads.openwrt.org/releases/23.05.2/packages/aarch64_generic/base/terminfo_6.4-2_aarch64_generic.ipk
Installing libncurses6 (6.4-2) to root...
Downloading https://downloads.openwrt.org/releases/23.05.2/packages/aarch64_generic/base/libncurses6_6.4-2_aarch64_generic.ipk
Configuring terminfo.
Configuring libncurses6.
Configuring vim.

2. Initially vim has the user flag, while terminfo and libncurses6 correctly have only the auto_installed flag.

root@OpenWrt:~# sed -n '/Package: vim/,/^$/p' /usr/lib/opkg/status
Package: vim
Version: 9.0-1
Depends: libc, libncurses6
Status: install user installed
Architecture: aarch64_generic
Conffiles:
 /usr/share/vim/vimrc 3fb5e600a6c725eaf881eb70c7615d845b532ba6ee3a4b6b6786e7c19237ef92
Installed-Time: 1705510911

root@OpenWrt:~# sed -n '/Package: terminfo/,/^$/p' /usr/lib/opkg/status
Package: terminfo
Version: 6.4-2
Depends: libc
Status: install ok installed
Architecture: aarch64_generic
Installed-Time: 1705510911
Auto-Installed: yes

root@OpenWrt:~# sed -n '/Package: libncurses6/,/^$/p' /usr/lib/opkg/status
Package: libncurses6
ABIVersion: 6
Version: 6.4-2
Depends: libc, terminfo
Provides: libncursesw, libncurses, libncursesw6
Status: install ok installed
Architecture: aarch64_generic
Installed-Time: 1705510911
Auto-Installed: yes

3. At this point running opkg remove --autoremove vim will successfully remove vim and its dependencies terminfo and libncurses6.

root@OpenWrt:~# opkg remove --autoremove vim
Removing package vim from root...
libncurses6 was autoinstalled and is now orphaned, removing.
Removing package libncurses6 from root...
terminfo was autoinstalled and is now orphaned, removing.
Removing package terminfo from root...

4. However if we upgrade terminfo first, we can see the user flag is added and the auto_installed flag is removed.

root@OpenWrt:~# opkg upgrade terminfo
Upgrading terminfo on root from 6.4-1 to 6.4-2...
Downloading https://downloads.openwrt.org/releases/23.05.2/packages/aarch64_generic/base/terminfo_6.4-2_aarch64_generic.ipk
Configuring terminfo.

root@OpenWrt:~# sed -n '/Package: terminfo/,/^$/p' /usr/lib/opkg/status
Package: terminfo
Version: 6.4-2
Depends: libc
Status: install user installed
Architecture: aarch64_generic
Installed-Time: 1705511717

5. Now if we run opkg remove --autoremove vim then vim and libncurses6 will be removed and its dependency terminfo will be left installed.

root@OpenWrt:~# opkg remove --autoremove vim
Removing package vim from root...
libncurses6 was autoinstalled and is now orphaned, removing.
Removing package libncurses6 from root...