Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary !isValid check, add reason to verificationResult #2075

Closed
DJHunn39 opened this issue Oct 29, 2024 · 0 comments · Fixed by #2076
Closed

Remove unnecessary !isValid check, add reason to verificationResult #2075

DJHunn39 opened this issue Oct 29, 2024 · 0 comments · Fixed by #2076

Comments

@DJHunn39
Copy link
Contributor

DJHunn39 commented Oct 29, 2024

There's an old FIXME in place here. The PR it refers to has been merged, so it can be removed.

It would also be helpful to include a reason property in the object returned by a PresentationVerificationCallback function, such that it will be included in the message of the error thrown by the Sphereon library here. This is, in a way, related to #144, but the changes required to just supply a reason to OID4VC can be made in @credo-ts.

These adjustments were discussed with @TimoGlastra in a meeting, though that was some time ago.

I have a branch with proposed changes ready to go, I'll open a PR shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant