From 110437887256a7c33843e346e28302d8b62a5056 Mon Sep 17 00:00:00 2001 From: "Jason C. Leach" Date: Thu, 7 Dec 2023 10:36:32 -0800 Subject: [PATCH 1/2] fix: long accessibility label Signed-off-by: Jason C. Leach --- packages/legacy/core/App/navigators/TabStack.tsx | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/legacy/core/App/navigators/TabStack.tsx b/packages/legacy/core/App/navigators/TabStack.tsx index dccaedcc08..079edb1717 100644 --- a/packages/legacy/core/App/navigators/TabStack.tsx +++ b/packages/legacy/core/App/navigators/TabStack.tsx @@ -78,9 +78,7 @@ const TabStack: React.FC = () => { ), tabBarShowLabel: false, - tabBarAccessibilityLabel: `${t('TabStack.Home')} (${ - total === 1 ? t('Home.OneNotification') : t('Home.CountNotifications', { count: total || 0 }) - })`, + tabBarAccessibilityLabel: `${t('TabStack.Home')} (${total ?? 0})`, tabBarTestID: testIdWithKey(t('TabStack.Home')), tabBarBadge: total || undefined, tabBarBadgeStyle: { From e56d1f3083adfceb7a944e0ba46bb44fb8bc0531 Mon Sep 17 00:00:00 2001 From: "Jason C. Leach" Date: Thu, 7 Dec 2023 10:39:14 -0800 Subject: [PATCH 2/2] fix: unused strings Signed-off-by: Jason C. Leach --- packages/legacy/core/App/localization/en/index.ts | 2 -- packages/legacy/core/App/localization/fr/index.ts | 2 -- 2 files changed, 4 deletions(-) diff --git a/packages/legacy/core/App/localization/en/index.ts b/packages/legacy/core/App/localization/en/index.ts index 6c4126b938..caf9da17dd 100644 --- a/packages/legacy/core/App/localization/en/index.ts +++ b/packages/legacy/core/App/localization/en/index.ts @@ -325,8 +325,6 @@ const translation = { "Welcome": "Welcome", "Notification": "Notification", "Notifications": "Notifications", - "OneNotification": "1 Notification", - "CountNotifications": "{{ count }} Notifications", "NoNewUpdates": "You have no new notifications.", "NoCredentials": "You have no credentials in your wallet.", "SeeAll": "See all", diff --git a/packages/legacy/core/App/localization/fr/index.ts b/packages/legacy/core/App/localization/fr/index.ts index bedd832fff..c4b73dc11d 100644 --- a/packages/legacy/core/App/localization/fr/index.ts +++ b/packages/legacy/core/App/localization/fr/index.ts @@ -324,8 +324,6 @@ const translation = { "Welcome": "Bienvenue", "Notification": "Notification", "Notifications": "Notifications", - "OneNotification": "1 Notification", - "CountNotifications": "{{ count }} Notification", "NoNewUpdates": "Vous n'avez pas de nouvelles notifications.", "NoCredentials": "Vous n'avez pas de justificatifs dans votre portefeuille.", "SeeAll": "Voir tout",