From 046df75b18e6a2f3c7fcd2383bf5779e9193fb94 Mon Sep 17 00:00:00 2001 From: Bryce McMath <32586431+bryce-mcmath@users.noreply.github.com> Date: Fri, 10 Nov 2023 16:09:19 -0800 Subject: [PATCH] chore: upgrade node version to 18.18 (#1024) Signed-off-by: Bryce McMath --- .github/actions/setup-node/action.yml | 2 +- .github/workflows/main.yaml | 8 ++++++++ .github/workflows/publish.yaml | 4 ++++ .github/workflows/quality.yml | 8 ++++++++ DEVELOPER.md | 2 +- DEVELOPER_MACOS_arm64.md | 4 ++-- package.json | 2 +- 7 files changed, 25 insertions(+), 5 deletions(-) diff --git a/.github/actions/setup-node/action.yml b/.github/actions/setup-node/action.yml index 8b5f9ae439..b0cc982011 100644 --- a/.github/actions/setup-node/action.yml +++ b/.github/actions/setup-node/action.yml @@ -7,7 +7,7 @@ inputs: node-version: description: Node version to use required: false - default: '16.15.0' + default: '18.18.2' runs: using: composite diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml index c4c3a775a2..a7e3f614f1 100644 --- a/.github/workflows/main.yaml +++ b/.github/workflows/main.yaml @@ -23,6 +23,10 @@ jobs: steps: - uses: actions/checkout@v3 + - uses: actions/setup-python@v4 + with: + python-version: '3.11' + - name: Setup NodeJS uses: ./.github/actions/setup-node @@ -103,6 +107,10 @@ jobs: steps: - uses: actions/checkout@v3 + - uses: actions/setup-python@v4 + with: + python-version: '3.11' + - name: Setup NodeJS uses: ./.github/actions/setup-node diff --git a/.github/workflows/publish.yaml b/.github/workflows/publish.yaml index 08cf0d3906..d7e5eff2d8 100644 --- a/.github/workflows/publish.yaml +++ b/.github/workflows/publish.yaml @@ -20,6 +20,10 @@ jobs: with: fetch-depth: 0 + - uses: actions/setup-python@v4 + with: + python-version: '3.11' + - name: Setup NodeJS uses: ./.github/actions/setup-node diff --git a/.github/workflows/quality.yml b/.github/workflows/quality.yml index 05559519c5..58337e87a4 100644 --- a/.github/workflows/quality.yml +++ b/.github/workflows/quality.yml @@ -15,6 +15,10 @@ jobs: - name: Checkout aries-mobile-agent-react-native uses: actions/checkout@v3 + - uses: actions/setup-python@v4 + with: + python-version: '3.11' + - name: Setup NodeJS uses: ./.github/actions/setup-node @@ -41,6 +45,10 @@ jobs: - name: Checkout aries-mobile-agent-react-native uses: actions/checkout@v3 + - uses: actions/setup-python@v4 + with: + python-version: '3.11' + - name: Setup NodeJS uses: ./.github/actions/setup-node diff --git a/DEVELOPER.md b/DEVELOPER.md index 1f62c44df6..045fe641f0 100644 --- a/DEVELOPER.md +++ b/DEVELOPER.md @@ -25,7 +25,7 @@ This is a [yarn](https://yarnpkg.com) based project, not [npm](https://www.npmjs ```sh npm install -g yarn -nvm install 16.15 +nvm install 18.18 ``` This project will need to run on an iOS device or Android device or emulator. While it is recommended to test your software on both, especially if you're contributing back to the project, for demonstration purposes you can choose one or the other. diff --git a/DEVELOPER_MACOS_arm64.md b/DEVELOPER_MACOS_arm64.md index 1e8fab35c1..c38d814c49 100644 --- a/DEVELOPER_MACOS_arm64.md +++ b/DEVELOPER_MACOS_arm64.md @@ -31,12 +31,12 @@ ``` 1. Install Node ```sh - nvm install 16.15.0 + nvm install 18.18.2 ``` Activate node version by adding the following to your `~/.zprofile` ```sh source $(brew --prefix nvm)/nvm.sh - nvm use 16.15.0 + nvm use 18.18.2 ``` 1. Install Yarn ```sh diff --git a/package.json b/package.json index 2bd9e1b7b9..4a5de473df 100644 --- a/package.json +++ b/package.json @@ -41,7 +41,7 @@ "typescript": "^5.0.4" }, "engines": { - "node": ">=16.15.0 <18.0.0", + "node": ">=18.18.2 <20.0.0", "yarn": "^3.3.1" }, "resolutions": {