Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"only http is supported" but URL is HTTPS #1004

Open
reedy opened this issue Apr 28, 2024 · 1 comment
Open

"only http is supported" but URL is HTTPS #1004

reedy opened this issue Apr 28, 2024 · 1 comment

Comments

@reedy
Copy link
Contributor

reedy commented Apr 28, 2024

// Flash HTTP:
mru = MyConfig.GetParamValue("ota", "http.mru");
c.input_text("HTTP URL", "flash_http", mru.c_str(),
"optional: URL of firmware file",
"<p>Leave empty to download the latest firmware from the update server. "
"Note: currently only http is supported.</p>", "list=\"urls\"");

Screenshot 2024-04-28 at 01 55 21

It says only HTTP is supported, but the URL is HTTPS, and seems to work fine.

Does the comment just need updating?

@dexterbg
Copy link
Member

The OvmsHttpClient class still has no HTTPS support. It will accept a https:// URL to be tolerant to user errors, but nevertheless perform the request via HTTP.

else if (url.compare(0, 8, "https://", 8) == 0)
{
url = url.substr(8);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants