From fb628aa550ee7750b81f745406c6d58f3126e896 Mon Sep 17 00:00:00 2001 From: Kit Ewbank Date: Wed, 20 Sep 2023 14:28:15 -0400 Subject: [PATCH 01/15] r/aws_s3control_storage_lens_configuration: Skip sweeper in US GovCloud. --- internal/service/s3control/sweep.go | 4 ++++ names/names.go | 3 +++ 2 files changed, 7 insertions(+) diff --git a/internal/service/s3control/sweep.go b/internal/service/s3control/sweep.go index f7f25eb501d..b9bc807265e 100644 --- a/internal/service/s3control/sweep.go +++ b/internal/service/s3control/sweep.go @@ -188,6 +188,10 @@ func sweepObjectLambdaAccessPoints(region string) error { func sweepStorageLensConfigurations(region string) error { ctx := sweep.Context(region) + if region == names.USGovEast1RegionID || region == names.USGovWest1RegionID { + log.Printf("[WARN] Skipping S3 Storage Lens Configuration sweep for region: %s", region) + return nil + } client, err := sweep.SharedRegionalSweepClient(ctx, region) if err != nil { return fmt.Errorf("error getting client: %s", err) diff --git a/names/names.go b/names/names.go index d523cd58973..bde23755044 100644 --- a/names/names.go +++ b/names/names.go @@ -79,6 +79,9 @@ const ( const ( USEast1RegionID = "us-east-1" // US East (N. Virginia). USWest2RegionID = "us-west-2" // US West (Oregon). + + USGovEast1RegionID = "us-gov-east-1" // AWS GovCloud (US-East). + USGovWest1RegionID = "us-gov-west-1" // AWS GovCloud (US-West). ) // Type ServiceDatum corresponds closely to columns in `names_data.csv` and are From 647ebc75519b8243e37c01aea81cba02658d75fe Mon Sep 17 00:00:00 2001 From: Kit Ewbank Date: Wed, 20 Sep 2023 15:34:20 -0400 Subject: [PATCH 02/15] r/aws_elasticsearch_domain: Only sweep Elasticsearch domains. --- internal/service/elasticsearch/sweep.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/internal/service/elasticsearch/sweep.go b/internal/service/elasticsearch/sweep.go index 4e8ba7123fa..d500a737bcf 100644 --- a/internal/service/elasticsearch/sweep.go +++ b/internal/service/elasticsearch/sweep.go @@ -65,6 +65,11 @@ func sweepDomains(region string) error { name := aws.StringValue(domainInfo.DomainName) + if engineType := aws.StringValue(domainInfo.EngineType); engineType != elasticsearchservice.EngineTypeElasticsearch { + log.Printf("[WARN] Skipping Elasticsearch Domain %s: EngineType = %s", name, engineType) + continue + } + // Elasticsearch Domains have regularly gotten stuck in a "being deleted" state // e.g. Deleted and Processing are both true for days in the API // Filter out domains that are Deleted already. From dbc730834c77e698e68db7ea226abc2135524020 Mon Sep 17 00:00:00 2001 From: Kit Ewbank Date: Wed, 20 Sep 2023 15:34:56 -0400 Subject: [PATCH 03/15] r/aws_opensearch_domain: Only sweep OpenSearch domains. --- internal/service/opensearch/sweep.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/internal/service/opensearch/sweep.go b/internal/service/opensearch/sweep.go index 5de01631b4d..ae08ab20a20 100644 --- a/internal/service/opensearch/sweep.go +++ b/internal/service/opensearch/sweep.go @@ -65,6 +65,11 @@ func sweepDomains(region string) error { name := aws.StringValue(domainInfo.DomainName) + if engineType := aws.StringValue(domainInfo.EngineType); engineType != opensearchservice.EngineTypeOpenSearch { + log.Printf("[WARN] Skipping OpenSearch Domain %s: EngineType = %s", name, engineType) + continue + } + // OpenSearch Domains have regularly gotten stuck in a "being deleted" state // e.g. Deleted and Processing are both true for days in the API // Filter out domains that are Deleted already. From 3c405ce591e063689d9b7568cab951d000ac768b Mon Sep 17 00:00:00 2001 From: Kit Ewbank Date: Wed, 20 Sep 2023 16:06:23 -0400 Subject: [PATCH 04/15] opensearch: Sweep inbound and outbound connections. --- .../opensearch/inbound_connection_accepter.go | 7 +- .../service/opensearch/outbound_connection.go | 7 +- internal/service/opensearch/sweep.go | 112 +++++++++++++++++- 3 files changed, 116 insertions(+), 10 deletions(-) diff --git a/internal/service/opensearch/inbound_connection_accepter.go b/internal/service/opensearch/inbound_connection_accepter.go index ccb578d682a..07276cbeaec 100644 --- a/internal/service/opensearch/inbound_connection_accepter.go +++ b/internal/service/opensearch/inbound_connection_accepter.go @@ -98,11 +98,10 @@ func resourceInboundConnectionRead(ctx context.Context, d *schema.ResourceData, func resourceInboundConnectionDelete(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics { conn := meta.(*conns.AWSClient).OpenSearchConn(ctx) - req := &opensearchservice.DeleteInboundConnectionInput{ + log.Printf("[DEBUG] Deleting OpenSearch Inbound Connection: %s", d.Id()) + _, err := conn.DeleteInboundConnectionWithContext(ctx, &opensearchservice.DeleteInboundConnectionInput{ ConnectionId: aws.String(d.Id()), - } - - _, err := conn.DeleteInboundConnectionWithContext(ctx, req) + }) if tfawserr.ErrCodeEquals(err, "ResourceNotFoundException") { return nil diff --git a/internal/service/opensearch/outbound_connection.go b/internal/service/opensearch/outbound_connection.go index 471044ba02b..f3970861265 100644 --- a/internal/service/opensearch/outbound_connection.go +++ b/internal/service/opensearch/outbound_connection.go @@ -108,11 +108,10 @@ func resourceOutboundConnectionRead(ctx context.Context, d *schema.ResourceData, func resourceOutboundConnectionDelete(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics { conn := meta.(*conns.AWSClient).OpenSearchConn(ctx) - req := &opensearchservice.DeleteOutboundConnectionInput{ + log.Printf("[DEBUG] Deleting OpenSearch Outbound Connection: %s", d.Id()) + _, err := conn.DeleteOutboundConnectionWithContext(ctx, &opensearchservice.DeleteOutboundConnectionInput{ ConnectionId: aws.String(d.Id()), - } - - _, err := conn.DeleteOutboundConnectionWithContext(ctx, req) + }) if tfawserr.ErrCodeEquals(err, "ResourceNotFoundException") { return nil diff --git a/internal/service/opensearch/sweep.go b/internal/service/opensearch/sweep.go index ae08ab20a20..5fa7c53b06a 100644 --- a/internal/service/opensearch/sweep.go +++ b/internal/service/opensearch/sweep.go @@ -21,17 +21,29 @@ func init() { resource.AddTestSweepers("aws_opensearch_domain", &resource.Sweeper{ Name: "aws_opensearch_domain", F: sweepDomains, + Dependencies: []string{ + "aws_opensearch_inbound_connection_accepter", + "aws_opensearch_outbound_connection", + }, + }) + + resource.AddTestSweepers("aws_opensearch_inbound_connection_accepter", &resource.Sweeper{ + Name: "aws_opensearch_inbound_connection_accepter", + F: sweepInboundConnections, + }) + + resource.AddTestSweepers("aws_opensearch_outbound_connection", &resource.Sweeper{ + Name: "aws_opensearch_outbound_connection", + F: sweepOutboundConnections, }) } func sweepDomains(region string) error { ctx := sweep.Context(region) client, err := sweep.SharedRegionalSweepClient(ctx, region) - if err != nil { return fmt.Errorf("error getting client: %w", err) } - conn := client.OpenSearchConn(ctx) sweepResources := make([]sweep.Sweepable, 0) var errs *multierror.Error @@ -106,3 +118,99 @@ func sweepDomains(region string) error { return errs.ErrorOrNil() } + +func sweepInboundConnections(region string) error { + ctx := sweep.Context(region) + client, err := sweep.SharedRegionalSweepClient(ctx, region) + if err != nil { + return fmt.Errorf("error getting client: %w", err) + } + conn := client.OpenSearchConn(ctx) + input := &opensearchservice.DescribeInboundConnectionsInput{} + sweepResources := make([]sweep.Sweepable, 0) + + err = conn.DescribeInboundConnectionsPagesWithContext(ctx, input, func(page *opensearchservice.DescribeInboundConnectionsOutput, lastPage bool) bool { + if page == nil { + return !lastPage + } + + for _, v := range page.Connections { + if aws.StringValue(v.ConnectionStatus.StatusCode) != opensearchservice.InboundConnectionStatusCodeDeleted { + continue + } + + r := ResourceInboundConnectionAccepter() + d := r.Data(nil) + d.SetId(aws.StringValue(v.ConnectionId)) + + sweepResources = append(sweepResources, sweep.NewSweepResource(r, d, client)) + } + + return !lastPage + }) + + if sweep.SkipSweepError(err) { + log.Printf("[WARN] Skipping OpenSearch Inbound Connection sweep for %s: %s", region, err) + return nil + } + + if err != nil { + return fmt.Errorf("error listing OpenSearch Inbound Connections: %w", err) + } + + err = sweep.SweepOrchestrator(ctx, sweepResources) + + if err != nil { + return fmt.Errorf("error sweeping OpenSearch Inbound Connections (%s): %w", region, err) + } + + return nil +} + +func sweepOutboundConnections(region string) error { + ctx := sweep.Context(region) + client, err := sweep.SharedRegionalSweepClient(ctx, region) + if err != nil { + return fmt.Errorf("error getting client: %w", err) + } + conn := client.OpenSearchConn(ctx) + input := &opensearchservice.DescribeOutboundConnectionsInput{} + sweepResources := make([]sweep.Sweepable, 0) + + err = conn.DescribeOutboundConnectionsPagesWithContext(ctx, input, func(page *opensearchservice.DescribeOutboundConnectionsOutput, lastPage bool) bool { + if page == nil { + return !lastPage + } + + for _, v := range page.Connections { + if aws.StringValue(v.ConnectionStatus.StatusCode) != opensearchservice.OutboundConnectionStatusCodeDeleted { + continue + } + + r := ResourceOutboundConnection() + d := r.Data(nil) + d.SetId(aws.StringValue(v.ConnectionId)) + + sweepResources = append(sweepResources, sweep.NewSweepResource(r, d, client)) + } + + return !lastPage + }) + + if sweep.SkipSweepError(err) { + log.Printf("[WARN] Skipping OpenSearch Outbound Connection sweep for %s: %s", region, err) + return nil + } + + if err != nil { + return fmt.Errorf("error listing OpenSearch Outbound Connections: %w", err) + } + + err = sweep.SweepOrchestrator(ctx, sweepResources) + + if err != nil { + return fmt.Errorf("error sweeping OpenSearch Outbound Connections (%s): %w", region, err) + } + + return nil +} From 237fd8e0de367f5257bb67d923f960ee427fd306 Mon Sep 17 00:00:00 2001 From: Kit Ewbank Date: Thu, 21 Sep 2023 07:56:19 -0400 Subject: [PATCH 05/15] r/aws_emrserverless_application: Call 'awsv2.SkipSweepError'. --- internal/service/emrserverless/sweep.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/internal/service/emrserverless/sweep.go b/internal/service/emrserverless/sweep.go index 3c1eeab3315..2eae27540d5 100644 --- a/internal/service/emrserverless/sweep.go +++ b/internal/service/emrserverless/sweep.go @@ -15,6 +15,7 @@ import ( "github.com/aws/aws-sdk-go-v2/service/emrserverless/types" "github.com/hashicorp/terraform-plugin-testing/helper/resource" "github.com/hashicorp/terraform-provider-aws/internal/sweep" + "github.com/hashicorp/terraform-provider-aws/internal/sweep/awsv2" ) func init() { @@ -38,7 +39,7 @@ func sweepApplications(region string) error { for pages.HasMorePages() { page, err := pages.NextPage(ctx) - if sweep.SkipSweepError(err) { + if awsv2.SkipSweepError(err) { log.Printf("[WARN] Skipping EMR Serverless Application sweep for %s: %s", region, err) return nil } From a1145275bff7198e87c0d1b7f55c5219fc542a47 Mon Sep 17 00:00:00 2001 From: Kit Ewbank Date: Thu, 21 Sep 2023 07:57:06 -0400 Subject: [PATCH 06/15] codestarconnections: Suppress sweepers in US GovCloud. --- internal/service/codestarconnections/sweep.go | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/internal/service/codestarconnections/sweep.go b/internal/service/codestarconnections/sweep.go index 92e31cf9765..6390c9a965d 100644 --- a/internal/service/codestarconnections/sweep.go +++ b/internal/service/codestarconnections/sweep.go @@ -15,6 +15,7 @@ import ( "github.com/hashicorp/terraform-plugin-testing/helper/resource" "github.com/hashicorp/terraform-provider-aws/internal/sweep" "github.com/hashicorp/terraform-provider-aws/internal/sweep/awsv2" + "github.com/hashicorp/terraform-provider-aws/names" ) func init() { @@ -34,6 +35,10 @@ func init() { func sweepConnections(region string) error { ctx := sweep.Context(region) + if region == names.USGovEast1RegionID || region == names.USGovWest1RegionID { + log.Printf("[WARN] Skipping CodeStar Connections Connection sweep for region: %s", region) + return nil + } client, err := sweep.SharedRegionalSweepClient(ctx, region) if err != nil { return fmt.Errorf("error getting client: %w", err) @@ -75,6 +80,10 @@ func sweepConnections(region string) error { func sweepHosts(region string) error { ctx := sweep.Context(region) + if region == names.USGovEast1RegionID || region == names.USGovWest1RegionID { + log.Printf("[WARN] Skipping CodeStar Connections Host sweep for region: %s", region) + return nil + } client, err := sweep.SharedRegionalSweepClient(ctx, region) if err != nil { return fmt.Errorf("error getting client: %w", err) From 58736d7a8cbec11adf822705a2b8f0725bd51b3d Mon Sep 17 00:00:00 2001 From: Kit Ewbank Date: Thu, 21 Sep 2023 07:57:38 -0400 Subject: [PATCH 07/15] route53: Suppress Traffic Policy sweepers in US GovCloud. --- internal/service/route53/sweep.go | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/internal/service/route53/sweep.go b/internal/service/route53/sweep.go index f4cf2be036d..3d32bf73f97 100644 --- a/internal/service/route53/sweep.go +++ b/internal/service/route53/sweep.go @@ -19,6 +19,7 @@ import ( "github.com/hashicorp/terraform-plugin-testing/helper/resource" "github.com/hashicorp/terraform-provider-aws/internal/sweep" "github.com/hashicorp/terraform-provider-aws/internal/tfresource" + "github.com/hashicorp/terraform-provider-aws/names" ) func init() { @@ -243,6 +244,10 @@ func sweepQueryLogs(region string) error { func sweepTrafficPolicies(region string) error { ctx := sweep.Context(region) + if region == names.USGovEast1RegionID || region == names.USGovWest1RegionID { + log.Printf("[WARN] Skipping Route 53 Traffic Policy sweep for region: %s", region) + return nil + } client, err := sweep.SharedRegionalSweepClient(ctx, region) if err != nil { return fmt.Errorf("getting client: %w", err) @@ -287,6 +292,10 @@ func sweepTrafficPolicies(region string) error { func sweepTrafficPolicyInstances(region string) error { ctx := sweep.Context(region) + if region == names.USGovEast1RegionID || region == names.USGovWest1RegionID { + log.Printf("[WARN] Skipping Route 53 Traffic Policy Instance sweep for region: %s", region) + return nil + } client, err := sweep.SharedRegionalSweepClient(ctx, region) if err != nil { return fmt.Errorf("getting client: %w", err) From c8d331576c26ac422ca6dd8263d1f773af5b2b16 Mon Sep 17 00:00:00 2001 From: Kit Ewbank Date: Thu, 21 Sep 2023 07:58:29 -0400 Subject: [PATCH 08/15] r/aws_codestarnotifications_notification_rule: Call 'awsv2.SkipSweepError'. --- internal/service/codestarnotifications/sweep.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/internal/service/codestarnotifications/sweep.go b/internal/service/codestarnotifications/sweep.go index 1097a19937d..1718b3dd3c5 100644 --- a/internal/service/codestarnotifications/sweep.go +++ b/internal/service/codestarnotifications/sweep.go @@ -14,6 +14,7 @@ import ( "github.com/aws/aws-sdk-go-v2/service/codestarnotifications" "github.com/hashicorp/terraform-plugin-testing/helper/resource" "github.com/hashicorp/terraform-provider-aws/internal/sweep" + "github.com/hashicorp/terraform-provider-aws/internal/sweep/awsv2" ) func init() { @@ -37,7 +38,7 @@ func sweepNotificationRules(region string) error { for pages.HasMorePages() { page, err := pages.NextPage(ctx) - if sweep.SkipSweepError(err) { + if awsv2.SkipSweepError(err) { log.Printf("[WARN] Skipping CodeStar Notification Rule sweep for %s: %s", region, err) return nil } From ef3660d940fe9cb07380be2ee0f213e68eb000fe Mon Sep 17 00:00:00 2001 From: Kit Ewbank Date: Thu, 21 Sep 2023 08:27:02 -0400 Subject: [PATCH 09/15] r/aws_route53_health_check: Skip sweeping Health Checks created by another service. --- internal/service/elasticsearch/sweep.go | 2 +- internal/service/opensearch/sweep.go | 2 +- internal/service/route53/sweep.go | 33 ++++++++++++------------- 3 files changed, 18 insertions(+), 19 deletions(-) diff --git a/internal/service/elasticsearch/sweep.go b/internal/service/elasticsearch/sweep.go index d500a737bcf..d915fc0d820 100644 --- a/internal/service/elasticsearch/sweep.go +++ b/internal/service/elasticsearch/sweep.go @@ -66,7 +66,7 @@ func sweepDomains(region string) error { name := aws.StringValue(domainInfo.DomainName) if engineType := aws.StringValue(domainInfo.EngineType); engineType != elasticsearchservice.EngineTypeElasticsearch { - log.Printf("[WARN] Skipping Elasticsearch Domain %s: EngineType = %s", name, engineType) + log.Printf("[INFO] Skipping Elasticsearch Domain %s: EngineType = %s", name, engineType) continue } diff --git a/internal/service/opensearch/sweep.go b/internal/service/opensearch/sweep.go index 5fa7c53b06a..901d48a4bcf 100644 --- a/internal/service/opensearch/sweep.go +++ b/internal/service/opensearch/sweep.go @@ -78,7 +78,7 @@ func sweepDomains(region string) error { name := aws.StringValue(domainInfo.DomainName) if engineType := aws.StringValue(domainInfo.EngineType); engineType != opensearchservice.EngineTypeOpenSearch { - log.Printf("[WARN] Skipping OpenSearch Domain %s: EngineType = %s", name, engineType) + log.Printf("[INFO] Skipping OpenSearch Domain %s: EngineType = %s", name, engineType) continue } diff --git a/internal/service/route53/sweep.go b/internal/service/route53/sweep.go index 3d32bf73f97..ebb6df7c918 100644 --- a/internal/service/route53/sweep.go +++ b/internal/service/route53/sweep.go @@ -68,29 +68,26 @@ func init() { func sweepHealthChecks(region string) error { ctx := sweep.Context(region) client, err := sweep.SharedRegionalSweepClient(ctx, region) - if err != nil { return fmt.Errorf("getting client: %s", err) } - conn := client.Route53Conn(ctx) - sweepResources := make([]sweep.Sweepable, 0) - var errs *multierror.Error - input := &route53.ListHealthChecksInput{} + sweepResources := make([]sweep.Sweepable, 0) err = conn.ListHealthChecksPagesWithContext(ctx, input, func(page *route53.ListHealthChecksOutput, lastPage bool) bool { if page == nil { return !lastPage } - for _, detail := range page.HealthChecks { - if detail == nil { + for _, v := range page.HealthChecks { + id := aws.StringValue(v.Id) + + if v.LinkedService != nil { + log.Printf("[INFO] Skipping Route 53 Health Check %s: %s", id, aws.StringValue(v.LinkedService.Description)) continue } - id := aws.StringValue(detail.Id) - r := ResourceHealthCheck() d := r.Data(nil) d.SetId(id) @@ -101,20 +98,22 @@ func sweepHealthChecks(region string) error { return !lastPage }) - if err != nil { - errs = multierror.Append(errs, fmt.Errorf("describing Route53 Health Checks for %s: %w", region, err)) + if sweep.SkipSweepError(err) { + log.Printf("[WARN] Skipping Route 53 Health Check sweep for %s: %s", region, err) + return nil } - if err = sweep.SweepOrchestrator(ctx, sweepResources, tfresource.WithDelayRand(1*time.Minute), tfresource.WithMinPollInterval(10*time.Second), tfresource.WithPollInterval(18*time.Second)); err != nil { - errs = multierror.Append(errs, fmt.Errorf("sweeping Route53 Health Checks for %s: %w", region, err)) + if err != nil { + return fmt.Errorf("listing Route 53 Health Checks (%s): %w", region, err) } - if sweep.SkipSweepError(errs.ErrorOrNil()) { - log.Printf("[WARN] Skipping Route53 Health Checks sweep for %s: %s", region, errs) - return nil + err = sweep.SweepOrchestrator(ctx, sweepResources) + + if err != nil { + return fmt.Errorf("sweeping Route 53 Health Checks (%s): %w", region, err) } - return errs.ErrorOrNil() + return nil } func sweepKeySigningKeys(region string) error { From 5f64fbddd7f27b23a856bda96f47a51f923df948 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 21 Sep 2023 10:08:09 -0400 Subject: [PATCH 10/15] build(deps): bump github.com/aws/aws-sdk-go in /.ci/providerlint (#33561) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.45.13 to 1.45.14. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](https://github.com/aws/aws-sdk-go/compare/v1.45.13...v1.45.14) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .ci/providerlint/go.mod | 2 +- .ci/providerlint/go.sum | 4 ++-- .../aws/aws-sdk-go/aws/endpoints/defaults.go | 19 +++++++++++++++++++ .ci/providerlint/vendor/modules.txt | 2 +- 4 files changed, 23 insertions(+), 4 deletions(-) diff --git a/.ci/providerlint/go.mod b/.ci/providerlint/go.mod index 5bc33a15b04..79467de1eaf 100644 --- a/.ci/providerlint/go.mod +++ b/.ci/providerlint/go.mod @@ -3,7 +3,7 @@ module github.com/hashicorp/terraform-provider-aws/ci/providerlint go 1.20 require ( - github.com/aws/aws-sdk-go v1.45.13 + github.com/aws/aws-sdk-go v1.45.14 github.com/bflad/tfproviderlint v0.29.0 github.com/hashicorp/terraform-plugin-sdk/v2 v2.29.0 golang.org/x/tools v0.8.0 diff --git a/.ci/providerlint/go.sum b/.ci/providerlint/go.sum index 70dd8685cc6..46756d0d7d3 100644 --- a/.ci/providerlint/go.sum +++ b/.ci/providerlint/go.sum @@ -8,8 +8,8 @@ github.com/agext/levenshtein v1.2.2/go.mod h1:JEDfjyjHDjOF/1e4FlBE/PkbqA9OfWu2ki github.com/apparentlymart/go-textseg/v12 v12.0.0/go.mod h1:S/4uRK2UtaQttw1GenVJEynmyUenKwP++x/+DdGV/Ec= github.com/apparentlymart/go-textseg/v15 v15.0.0 h1:uYvfpb3DyLSCGWnctWKGj857c6ew1u1fNQOlOtuGxQY= github.com/apparentlymart/go-textseg/v15 v15.0.0/go.mod h1:K8XmNZdhEBkdlyDdvbmmsvpAG721bKi0joRfFdHIWJ4= -github.com/aws/aws-sdk-go v1.45.13 h1:LwD/G+PX7FQnbU8wXekx12e90i1GuKJQC2+pl4IlPAs= -github.com/aws/aws-sdk-go v1.45.13/go.mod h1:aVsgQcEevwlmQ7qHE9I3h+dtQgpqhFB+i8Phjh7fkwI= +github.com/aws/aws-sdk-go v1.45.14 h1:/IPMEh9oelbK7506fdMHkbV9mq4a6f5aeiy9OT0PRKw= +github.com/aws/aws-sdk-go v1.45.14/go.mod h1:aVsgQcEevwlmQ7qHE9I3h+dtQgpqhFB+i8Phjh7fkwI= github.com/bflad/gopaniccheck v0.1.0 h1:tJftp+bv42ouERmUMWLoUn/5bi/iQZjHPznM00cP/bU= github.com/bflad/gopaniccheck v0.1.0/go.mod h1:ZCj2vSr7EqVeDaqVsWN4n2MwdROx1YL+LFo47TSWtsA= github.com/bflad/tfproviderlint v0.29.0 h1:zxKYAAM6IZ4ace1a3LX+uzMRIMP8L+iOtEc+FP2Yoow= diff --git a/.ci/providerlint/vendor/github.com/aws/aws-sdk-go/aws/endpoints/defaults.go b/.ci/providerlint/vendor/github.com/aws/aws-sdk-go/aws/endpoints/defaults.go index 2b7bdca86cf..5ea860c6b11 100644 --- a/.ci/providerlint/vendor/github.com/aws/aws-sdk-go/aws/endpoints/defaults.go +++ b/.ci/providerlint/vendor/github.com/aws/aws-sdk-go/aws/endpoints/defaults.go @@ -21192,6 +21192,9 @@ var awsPartition = partition{ endpointKey{ Region: "ap-south-1", }: endpoint{}, + endpointKey{ + Region: "ap-south-2", + }: endpoint{}, endpointKey{ Region: "ap-southeast-1", }: endpoint{}, @@ -21207,12 +21210,18 @@ var awsPartition = partition{ endpointKey{ Region: "eu-central-1", }: endpoint{}, + endpointKey{ + Region: "eu-central-2", + }: endpoint{}, endpointKey{ Region: "eu-north-1", }: endpoint{}, endpointKey{ Region: "eu-south-1", }: endpoint{}, + endpointKey{ + Region: "eu-south-2", + }: endpoint{}, endpointKey{ Region: "eu-west-1", }: endpoint{}, @@ -33685,6 +33694,16 @@ var awscnPartition = partition{ }: endpoint{}, }, }, + "sso": service{ + Endpoints: serviceEndpoints{ + endpointKey{ + Region: "cn-north-1", + }: endpoint{}, + endpointKey{ + Region: "cn-northwest-1", + }: endpoint{}, + }, + }, "states": service{ Endpoints: serviceEndpoints{ endpointKey{ diff --git a/.ci/providerlint/vendor/modules.txt b/.ci/providerlint/vendor/modules.txt index fcd635a48ef..e59d2a93549 100644 --- a/.ci/providerlint/vendor/modules.txt +++ b/.ci/providerlint/vendor/modules.txt @@ -24,7 +24,7 @@ github.com/agext/levenshtein # github.com/apparentlymart/go-textseg/v15 v15.0.0 ## explicit; go 1.16 github.com/apparentlymart/go-textseg/v15/textseg -# github.com/aws/aws-sdk-go v1.45.13 +# github.com/aws/aws-sdk-go v1.45.14 ## explicit; go 1.11 github.com/aws/aws-sdk-go/aws/awserr github.com/aws/aws-sdk-go/aws/endpoints From 9150c2674fa3349d6a81a3db92e0e777b8f895be Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 21 Sep 2023 10:09:34 -0400 Subject: [PATCH 11/15] build(deps): bump the aws-sdk-go group with 6 updates (#33562) Bumps the aws-sdk-go group with 6 updates: | Package | From | To | | --- | --- | --- | | [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) | `1.45.13` | `1.45.14` | | [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) | `1.18.40` | `1.18.41` | | [github.com/aws/aws-sdk-go-v2/feature/s3/manager](https://github.com/aws/aws-sdk-go-v2) | `1.11.84` | `1.11.85` | | [github.com/aws/aws-sdk-go-v2/service/appconfig](https://github.com/aws/aws-sdk-go-v2) | `1.19.0` | `1.20.0` | | [github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs](https://github.com/aws/aws-sdk-go-v2) | `1.23.5` | `1.24.0` | | [github.com/aws/aws-sdk-go-v2/service/pipes](https://github.com/aws/aws-sdk-go-v2) | `1.4.0` | `1.4.1` | Updates `github.com/aws/aws-sdk-go` from 1.45.13 to 1.45.14 - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](https://github.com/aws/aws-sdk-go/compare/v1.45.13...v1.45.14) Updates `github.com/aws/aws-sdk-go-v2/config` from 1.18.40 to 1.18.41 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](https://github.com/aws/aws-sdk-go-v2/compare/config/v1.18.40...config/v1.18.41) Updates `github.com/aws/aws-sdk-go-v2/feature/s3/manager` from 1.11.84 to 1.11.85 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](https://github.com/aws/aws-sdk-go-v2/compare/feature/s3/manager/v1.11.84...feature/s3/manager/v1.11.85) Updates `github.com/aws/aws-sdk-go-v2/service/appconfig` from 1.19.0 to 1.20.0 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/v1.20.0/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-go-v2/compare/v1.19.0...v1.20.0) Updates `github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs` from 1.23.5 to 1.24.0 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/service/s3/v1.24.0/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-go-v2/compare/service/ecs/v1.23.5...service/s3/v1.24.0) Updates `github.com/aws/aws-sdk-go-v2/service/pipes` from 1.4.0 to 1.4.1 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/config/v1.4.1/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-go-v2/compare/v1.4.0...config/v1.4.1) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch dependency-group: aws-sdk-go - dependency-name: github.com/aws/aws-sdk-go-v2/config dependency-type: direct:production update-type: version-update:semver-patch dependency-group: aws-sdk-go - dependency-name: github.com/aws/aws-sdk-go-v2/feature/s3/manager dependency-type: direct:production update-type: version-update:semver-patch dependency-group: aws-sdk-go - dependency-name: github.com/aws/aws-sdk-go-v2/service/appconfig dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-sdk-go - dependency-name: github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-sdk-go - dependency-name: github.com/aws/aws-sdk-go-v2/service/pipes dependency-type: direct:production update-type: version-update:semver-patch dependency-group: aws-sdk-go ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- go.mod | 18 +++++++++--------- go.sum | 36 ++++++++++++++++++------------------ 2 files changed, 27 insertions(+), 27 deletions(-) diff --git a/go.mod b/go.mod index d013f10c719..49665be6ae6 100644 --- a/go.mod +++ b/go.mod @@ -5,19 +5,19 @@ go 1.20 require ( github.com/ProtonMail/go-crypto v0.0.0-20230717121422-5aa5874ade95 github.com/YakDriver/regexache v0.23.0 - github.com/aws/aws-sdk-go v1.45.13 + github.com/aws/aws-sdk-go v1.45.14 github.com/aws/aws-sdk-go-v2 v1.21.0 - github.com/aws/aws-sdk-go-v2/config v1.18.40 + github.com/aws/aws-sdk-go-v2/config v1.18.41 github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.13.11 - github.com/aws/aws-sdk-go-v2/feature/s3/manager v1.11.84 + github.com/aws/aws-sdk-go-v2/feature/s3/manager v1.11.85 github.com/aws/aws-sdk-go-v2/service/accessanalyzer v1.21.0 github.com/aws/aws-sdk-go-v2/service/account v1.11.5 github.com/aws/aws-sdk-go-v2/service/acm v1.19.0 - github.com/aws/aws-sdk-go-v2/service/appconfig v1.19.0 + github.com/aws/aws-sdk-go-v2/service/appconfig v1.20.0 github.com/aws/aws-sdk-go-v2/service/auditmanager v1.26.5 github.com/aws/aws-sdk-go-v2/service/cleanrooms v1.4.0 github.com/aws/aws-sdk-go-v2/service/cloudcontrol v1.12.5 - github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs v1.23.5 + github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs v1.24.0 github.com/aws/aws-sdk-go-v2/service/codecatalyst v1.5.5 github.com/aws/aws-sdk-go-v2/service/codestarconnections v1.15.5 github.com/aws/aws-sdk-go-v2/service/codestarnotifications v1.16.0 @@ -46,7 +46,7 @@ require ( github.com/aws/aws-sdk-go-v2/service/mediapackage v1.23.3 github.com/aws/aws-sdk-go-v2/service/oam v1.3.0 github.com/aws/aws-sdk-go-v2/service/opensearchserverless v1.5.0 - github.com/aws/aws-sdk-go-v2/service/pipes v1.4.0 + github.com/aws/aws-sdk-go-v2/service/pipes v1.4.1 github.com/aws/aws-sdk-go-v2/service/pricing v1.21.6 github.com/aws/aws-sdk-go-v2/service/qldb v1.16.5 github.com/aws/aws-sdk-go-v2/service/rbin v1.10.0 @@ -55,7 +55,7 @@ require ( github.com/aws/aws-sdk-go-v2/service/resourceexplorer2 v1.4.0 github.com/aws/aws-sdk-go-v2/service/rolesanywhere v1.3.5 github.com/aws/aws-sdk-go-v2/service/route53domains v1.17.3 - github.com/aws/aws-sdk-go-v2/service/s3 v1.38.5 + github.com/aws/aws-sdk-go-v2/service/s3 v1.39.0 github.com/aws/aws-sdk-go-v2/service/s3control v1.33.0 github.com/aws/aws-sdk-go-v2/service/scheduler v1.3.0 github.com/aws/aws-sdk-go-v2/service/securitylake v1.7.0 @@ -116,7 +116,7 @@ require ( github.com/apparentlymart/go-textseg/v15 v15.0.0 // indirect github.com/armon/go-radix v1.0.0 // indirect github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream v1.4.13 // indirect - github.com/aws/aws-sdk-go-v2/credentials v1.13.38 // indirect + github.com/aws/aws-sdk-go-v2/credentials v1.13.39 // indirect github.com/aws/aws-sdk-go-v2/internal/configsources v1.1.41 // indirect github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.4.35 // indirect github.com/aws/aws-sdk-go-v2/internal/ini v1.3.42 // indirect @@ -128,7 +128,7 @@ require ( github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.9.35 // indirect github.com/aws/aws-sdk-go-v2/service/internal/s3shared v1.15.4 // indirect github.com/aws/aws-sdk-go-v2/service/sso v1.14.0 // indirect - github.com/aws/aws-sdk-go-v2/service/ssooidc v1.16.0 // indirect + github.com/aws/aws-sdk-go-v2/service/ssooidc v1.17.0 // indirect github.com/aws/aws-sdk-go-v2/service/sts v1.22.0 // indirect github.com/aws/smithy-go v1.14.2 // indirect github.com/bgentry/speakeasy v0.1.0 // indirect diff --git a/go.sum b/go.sum index d5e64034dd5..34a30545f4b 100644 --- a/go.sum +++ b/go.sum @@ -22,20 +22,20 @@ github.com/apparentlymart/go-textseg/v15 v15.0.0/go.mod h1:K8XmNZdhEBkdlyDdvbmms github.com/armon/go-radix v0.0.0-20180808171621-7fddfc383310/go.mod h1:ufUuZ+zHj4x4TnLV4JWEpy2hxWSpsRywHrMgIH9cCH8= github.com/armon/go-radix v1.0.0 h1:F4z6KzEeeQIMeLFa97iZU6vupzoecKdU5TX24SNppXI= github.com/armon/go-radix v1.0.0/go.mod h1:ufUuZ+zHj4x4TnLV4JWEpy2hxWSpsRywHrMgIH9cCH8= -github.com/aws/aws-sdk-go v1.45.13 h1:LwD/G+PX7FQnbU8wXekx12e90i1GuKJQC2+pl4IlPAs= -github.com/aws/aws-sdk-go v1.45.13/go.mod h1:aVsgQcEevwlmQ7qHE9I3h+dtQgpqhFB+i8Phjh7fkwI= +github.com/aws/aws-sdk-go v1.45.14 h1:/IPMEh9oelbK7506fdMHkbV9mq4a6f5aeiy9OT0PRKw= +github.com/aws/aws-sdk-go v1.45.14/go.mod h1:aVsgQcEevwlmQ7qHE9I3h+dtQgpqhFB+i8Phjh7fkwI= github.com/aws/aws-sdk-go-v2 v1.21.0 h1:gMT0IW+03wtYJhRqTVYn0wLzwdnK9sRMcxmtfGzRdJc= github.com/aws/aws-sdk-go-v2 v1.21.0/go.mod h1:/RfNgGmRxI+iFOB1OeJUyxiU+9s88k3pfHvDagGEp0M= github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream v1.4.13 h1:OPLEkmhXf6xFPiz0bLeDArZIDx1NNS4oJyG4nv3Gct0= github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream v1.4.13/go.mod h1:gpAbvyDGQFozTEmlTFO8XcQKHzubdq0LzRyJpG6MiXM= -github.com/aws/aws-sdk-go-v2/config v1.18.40 h1:dbu1llI/nTIL+r6sYHMeVLl99DM8J8/o1I4EPurnhLg= -github.com/aws/aws-sdk-go-v2/config v1.18.40/go.mod h1:JjrCZQwSPGCoZRQzKHyZNNueaKO+kFaEy2sR6mCzd90= -github.com/aws/aws-sdk-go-v2/credentials v1.13.38 h1:gDAuCdVlA4lmmgQhvpZlscwicloCqH44vkxLklGkQLA= -github.com/aws/aws-sdk-go-v2/credentials v1.13.38/go.mod h1:sD4G/Ybgp6s89mWIES3Xn97CsRLpxvz9uVSdv0UxY8I= +github.com/aws/aws-sdk-go-v2/config v1.18.41 h1:Go7z97YDsBJVNAaL7pDPKB6LeHEsAkHmFe+CeK30fUQ= +github.com/aws/aws-sdk-go-v2/config v1.18.41/go.mod h1:+yR45+A0LIMKT8bWOKo90Hy9rSrovEmEKoPKLmmVec8= +github.com/aws/aws-sdk-go-v2/credentials v1.13.39 h1:UnwBXDIHKDaejSXaRzKR57IdGCizk+z1DEhnsFpus7Q= +github.com/aws/aws-sdk-go-v2/credentials v1.13.39/go.mod h1:OJ9P239A90TnglJEF3qofKiNeEM6PCV/m+aNGV5WC24= github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.13.11 h1:uDZJF1hu0EVT/4bogChk8DyjSF6fof6uL/0Y26Ma7Fg= github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.13.11/go.mod h1:TEPP4tENqBGO99KwVpV9MlOX4NSrSLP8u3KRy2CDwA8= -github.com/aws/aws-sdk-go-v2/feature/s3/manager v1.11.84 h1:LENrVcqnWTyI8fbIUCvxAMe+fXbREIaXzcR8WPwco1U= -github.com/aws/aws-sdk-go-v2/feature/s3/manager v1.11.84/go.mod h1:LHxCiYAStsgps4srke7HujyADd504MSkNXjLpOtICTc= +github.com/aws/aws-sdk-go-v2/feature/s3/manager v1.11.85 h1:PH1OSkrdY8X+ENBz8ZhgWhR/975S05gcFPM4PxpAFrI= +github.com/aws/aws-sdk-go-v2/feature/s3/manager v1.11.85/go.mod h1:4X3OaVfB/ZjZsB9eHpFLnNT00sw+ZE81kQ2E9FysTaU= github.com/aws/aws-sdk-go-v2/internal/configsources v1.1.41 h1:22dGT7PneFMx4+b3pz7lMTRyN8ZKH7M2cW4GP9yUS2g= github.com/aws/aws-sdk-go-v2/internal/configsources v1.1.41/go.mod h1:CrObHAuPneJBlfEJ5T3szXOUkLEThaGfvnhTf33buas= github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.4.35 h1:SijA0mgjV8E+8G45ltVHs0fvKpTj8xmZJ3VwhGKtUSI= @@ -50,16 +50,16 @@ github.com/aws/aws-sdk-go-v2/service/account v1.11.5 h1:UX7HDdPZwTmrr1zu1j8e9QNI github.com/aws/aws-sdk-go-v2/service/account v1.11.5/go.mod h1:lyM7ulqjV86x2XF9eaul8Q8eulyScl+2cinCZ6nXmAo= github.com/aws/aws-sdk-go-v2/service/acm v1.19.0 h1:WVTc4Z8EKSF6vWq5oAUmKxhVPRqyYKK3P2/DT1dveMk= github.com/aws/aws-sdk-go-v2/service/acm v1.19.0/go.mod h1:3jqJmuasOx2V/CD5tQd3TNYZb1dMmXKh1F+cl8hDlYs= -github.com/aws/aws-sdk-go-v2/service/appconfig v1.19.0 h1:CNDTWNKKK55mvXXrLcnud7UR7FpNNGl0epAQc8y1ykE= -github.com/aws/aws-sdk-go-v2/service/appconfig v1.19.0/go.mod h1:zk3+CYtLFK+Yo83oc+rARhvajxgM3rmxPRmoFpHTsNw= +github.com/aws/aws-sdk-go-v2/service/appconfig v1.20.0 h1:bRmFz6sBl9wp0PHlhcZnEdTHaci25HXk3Milyw73Dz4= +github.com/aws/aws-sdk-go-v2/service/appconfig v1.20.0/go.mod h1:zk3+CYtLFK+Yo83oc+rARhvajxgM3rmxPRmoFpHTsNw= github.com/aws/aws-sdk-go-v2/service/auditmanager v1.26.5 h1:nAZnFygNPs3I3LR9AR7rud21ESTiTTHXuLQ4KW4tO+0= github.com/aws/aws-sdk-go-v2/service/auditmanager v1.26.5/go.mod h1:EwlbwoKCPpH81bmlIVk6XD91fh9fF7CKQlp8uxlndXE= github.com/aws/aws-sdk-go-v2/service/cleanrooms v1.4.0 h1:wDRpDU1x+xSKfezFyMUA96wzwXDVN/TbBKr6EED6Muo= github.com/aws/aws-sdk-go-v2/service/cleanrooms v1.4.0/go.mod h1:MrKI9BOSn2qulUfYxligb7ZKrYB1FtxjP5kcK3VxFoY= github.com/aws/aws-sdk-go-v2/service/cloudcontrol v1.12.5 h1:u0OiSC//5remFN6t5U9iYPemlKsEQ9qeC9bzF0JaJHo= github.com/aws/aws-sdk-go-v2/service/cloudcontrol v1.12.5/go.mod h1:Jg/MLglEy39ieHbPCeU5SwPITQRSxqNDPU4S+46U0fg= -github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs v1.23.5 h1:/rXnxd9VGnTc5fLuSFKkWCy+kDP6CxXAIMvfJQEfx8U= -github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs v1.23.5/go.mod h1:5v2ZNXCSwG73rx0k3sCuB1Ju8sbEbG0iUlxCA7D8sV8= +github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs v1.24.0 h1:6LRil7J+uh2SZ58Wkm/5aVRpBOZbTtwi8p8gdsix94c= +github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs v1.24.0/go.mod h1:5v2ZNXCSwG73rx0k3sCuB1Ju8sbEbG0iUlxCA7D8sV8= github.com/aws/aws-sdk-go-v2/service/codecatalyst v1.5.5 h1:0UjYGDcARG0Y71avF9WJpu6S9LGcHnI3ZjQgsXv7xG8= github.com/aws/aws-sdk-go-v2/service/codecatalyst v1.5.5/go.mod h1:WjivOf36Wi6bPHKCDOIu4FgUlEEQr4tOdf3mAS5Xtbw= github.com/aws/aws-sdk-go-v2/service/codestarconnections v1.15.5 h1:dqRzOxvFswTYI7IU+Pn2vgApSfAh+r22hbnBDP3t2ao= @@ -128,8 +128,8 @@ github.com/aws/aws-sdk-go-v2/service/oam v1.3.0 h1:yN7gae0RLYIT4NDptCV9wnuY2Srow github.com/aws/aws-sdk-go-v2/service/oam v1.3.0/go.mod h1:4lD6a0zq+rWEL4Ba3d9n0JZp+tCAm1Bk9Ky5WX2tTmI= github.com/aws/aws-sdk-go-v2/service/opensearchserverless v1.5.0 h1:iuVPMMbv8SGrKv7yCePAKW3Klvrs3g0XbkQlCyyTBtg= github.com/aws/aws-sdk-go-v2/service/opensearchserverless v1.5.0/go.mod h1:q4vucelgv/GslFK1qpKfH+40n9K73M2a0OHyjgcGDB8= -github.com/aws/aws-sdk-go-v2/service/pipes v1.4.0 h1:5XdPn7pVHY95HyNTaXIFvIjB32lbG51jeezP8qoKszE= -github.com/aws/aws-sdk-go-v2/service/pipes v1.4.0/go.mod h1:bElGVvs4CdPbb7iYex87vwut+9WQ75L0jhlV6JiZMjo= +github.com/aws/aws-sdk-go-v2/service/pipes v1.4.1 h1:1MvAMuJjRPOKLIq8HUy/hg6NxoH7mtuvek07ovJlIBc= +github.com/aws/aws-sdk-go-v2/service/pipes v1.4.1/go.mod h1:bElGVvs4CdPbb7iYex87vwut+9WQ75L0jhlV6JiZMjo= github.com/aws/aws-sdk-go-v2/service/pricing v1.21.6 h1:k/f3T13s7wx/By6aKovlVsjdNkRVT0QRR2RlZEvaTGg= github.com/aws/aws-sdk-go-v2/service/pricing v1.21.6/go.mod h1:9n3tkRCngy3+Iw/8vK3C69iXh22SCGsy3yn16nTxH+s= github.com/aws/aws-sdk-go-v2/service/qldb v1.16.5 h1:mmCoa7WmiISEuCOwNU63Mq9NnfuSlNx7UKmiG4Co3Dk= @@ -146,8 +146,8 @@ github.com/aws/aws-sdk-go-v2/service/rolesanywhere v1.3.5 h1:tfmJZFDrma1cgraLRuE github.com/aws/aws-sdk-go-v2/service/rolesanywhere v1.3.5/go.mod h1:vXPkNV5GGPdMjRRNzO45nX3qsNTgB5lP19Tk4Go30xQ= github.com/aws/aws-sdk-go-v2/service/route53domains v1.17.3 h1:aaHlZb06fyEQ3uqEVJiN3hLt8syCzX+tWZiz40S4c0Y= github.com/aws/aws-sdk-go-v2/service/route53domains v1.17.3/go.mod h1:SK+5R1cYgVgSfBGi9T/gPGNIuLInF3eIRYNruia62rg= -github.com/aws/aws-sdk-go-v2/service/s3 v1.38.5 h1:A42xdtStObqy7NGvzZKpnyNXvoOmm+FENobZ0/ssHWk= -github.com/aws/aws-sdk-go-v2/service/s3 v1.38.5/go.mod h1:rDGMZA7f4pbmTtPOk5v5UM2lmX6UAbRnMDJeDvnH7AM= +github.com/aws/aws-sdk-go-v2/service/s3 v1.39.0 h1:VZ2WMkKLio5tVjYfThcy5+pb6YHGd6B6egq75FfM6hU= +github.com/aws/aws-sdk-go-v2/service/s3 v1.39.0/go.mod h1:rDGMZA7f4pbmTtPOk5v5UM2lmX6UAbRnMDJeDvnH7AM= github.com/aws/aws-sdk-go-v2/service/s3control v1.33.0 h1:f4qHghGTcns4L4F7u8AHH6pcVLwgtTMNkNZeRJZ5xlA= github.com/aws/aws-sdk-go-v2/service/s3control v1.33.0/go.mod h1:YSdqo9knBVm5H3JVmWDhx9Wts9828nColUJzL3OKXDk= github.com/aws/aws-sdk-go-v2/service/scheduler v1.3.0 h1:uzCEL2ILopsOcWvbmeMmmy3Sc0ybVh+nHMg5knnA0Rg= @@ -166,8 +166,8 @@ github.com/aws/aws-sdk-go-v2/service/ssmincidents v1.23.0 h1:JkzoHb2bl5y7guwjKrs github.com/aws/aws-sdk-go-v2/service/ssmincidents v1.23.0/go.mod h1:11Z2L2mDhJbRZo5rwRs1NPz1Vi37U5N1EiaazEoBGag= github.com/aws/aws-sdk-go-v2/service/sso v1.14.0 h1:AR/hlTsCyk1CwlyKnPFvIMvnONydRjDDRT9OGb0i+/g= github.com/aws/aws-sdk-go-v2/service/sso v1.14.0/go.mod h1:fIAwKQKBFu90pBxx07BFOMJLpRUGu8VOzLJakeY+0K4= -github.com/aws/aws-sdk-go-v2/service/ssooidc v1.16.0 h1:vbgiXuhtn49+erlPrgIvQ+J32rg1HseaPf8lEpKbkxQ= -github.com/aws/aws-sdk-go-v2/service/ssooidc v1.16.0/go.mod h1:yygr8ACQRY2PrEcy3xsUI357stq2AxnFM6DIsR9lij4= +github.com/aws/aws-sdk-go-v2/service/ssooidc v1.17.0 h1:UniOmlPJelksyP5dGjfRoFTmLDy4/o0HH1lK2Op7zC8= +github.com/aws/aws-sdk-go-v2/service/ssooidc v1.17.0/go.mod h1:yygr8ACQRY2PrEcy3xsUI357stq2AxnFM6DIsR9lij4= github.com/aws/aws-sdk-go-v2/service/sts v1.22.0 h1:s4bioTgjSFRwOoyEFzAVCmFmoowBgjTR8gkrF/sQ4wk= github.com/aws/aws-sdk-go-v2/service/sts v1.22.0/go.mod h1:VC7JDqsqiwXukYEDjoHh9U0fOJtNWh04FPQz4ct4GGU= github.com/aws/aws-sdk-go-v2/service/swf v1.17.3 h1:E2i7UVmrS7D+RqvOHdv/6pag549LNrR+W8x8z+fwFWo= From 062d724cb1f3a330b0f5d59e416f9406a08b35a7 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 21 Sep 2023 10:11:38 -0400 Subject: [PATCH 12/15] build(deps): bump actions/setup-java from 3.11.0 to 3.13.0 (#33560) Bumps [actions/setup-java](https://github.com/actions/setup-java) from 3.11.0 to 3.13.0. - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](https://github.com/actions/setup-java/compare/5ffc13f4174014e2d4d4572b3d74c3fa61aeb2c2...0ab4596768b603586c0de567f2430c30f5b0d2b0) --- updated-dependencies: - dependency-name: actions/setup-java dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/gen-teamcity.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/gen-teamcity.yml b/.github/workflows/gen-teamcity.yml index 7e38f2bfb7c..3a0486ba82c 100644 --- a/.github/workflows/gen-teamcity.yml +++ b/.github/workflows/gen-teamcity.yml @@ -14,7 +14,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4.0.0 - - uses: actions/setup-java@5ffc13f4174014e2d4d4572b3d74c3fa61aeb2c2 # v3.11.0 + - uses: actions/setup-java@0ab4596768b603586c0de567f2430c30f5b0d2b0 # v3.13.0 with: distribution: adopt java-version: 17 From 589425d8b7d16f81dbb89a5940f8d0fe11501a98 Mon Sep 17 00:00:00 2001 From: changelogbot Date: Thu, 21 Sep 2023 14:14:36 +0000 Subject: [PATCH 13/15] Update CHANGELOG.md for #33560 --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 662a5d128b2..cf8167c00e4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,7 @@ FEATURES: * **New Data Source:** `aws_fsx_ontap_file_system` ([#32503](https://github.com/hashicorp/terraform-provider-aws/issues/32503)) * **New Data Source:** `aws_fsx_ontap_storage_virtual_machine` ([#32621](https://github.com/hashicorp/terraform-provider-aws/issues/32621)) +* **New Data Source:** `aws_fsx_ontap_storage_virtual_machines` ([#32624](https://github.com/hashicorp/terraform-provider-aws/issues/32624)) * **New Data Source:** `aws_organizations_organizational_unit` ([#33408](https://github.com/hashicorp/terraform-provider-aws/issues/33408)) * **New Resource:** `aws_opensearch_package` ([#33227](https://github.com/hashicorp/terraform-provider-aws/issues/33227)) * **New Resource:** `aws_opensearch_package_association` ([#33227](https://github.com/hashicorp/terraform-provider-aws/issues/33227)) From 4d8c4542f08e6520d669ffa14b2f446be6e36164 Mon Sep 17 00:00:00 2001 From: Kit Ewbank Date: Thu, 21 Sep 2023 10:44:50 -0400 Subject: [PATCH 14/15] r/aws_quicksight_group: Add sweeper. --- internal/service/quicksight/sweep.go | 56 ++++++++++++++++++++++++++++ 1 file changed, 56 insertions(+) diff --git a/internal/service/quicksight/sweep.go b/internal/service/quicksight/sweep.go index 362b1315000..68f16e92b12 100644 --- a/internal/service/quicksight/sweep.go +++ b/internal/service/quicksight/sweep.go @@ -35,6 +35,10 @@ func init() { Name: "aws_quicksight_folder", F: sweepFolders, }) + resource.AddTestSweepers("aws_quicksight_group", &resource.Sweeper{ + Name: "aws_quicksight_group", + F: sweepGroups, + }) resource.AddTestSweepers("aws_quicksight_template", &resource.Sweeper{ Name: "aws_quicksight_template", F: sweepTemplates, @@ -42,6 +46,9 @@ func init() { resource.AddTestSweepers("aws_quicksight_user", &resource.Sweeper{ Name: "aws_quicksight_user", F: sweepUsers, + Dependencies: []string{ + "aws_quicksight_group", + }, }) } @@ -50,6 +57,10 @@ const ( acctestResourcePrefix = "tf-acc-test" ) +// TODO +// TODO Use paginated listers. +// TODO + func sweepDashboards(region string) error { ctx := sweep.Context(region) client, err := sweep.SharedRegionalSweepClient(ctx, region) @@ -248,7 +259,52 @@ func sweepFolders(region string) error { } return nil +} + +func sweepGroups(region string) error { + ctx := sweep.Context(region) + client, err := sweep.SharedRegionalSweepClient(ctx, region) + + if err != nil { + return fmt.Errorf("getting client: %w", err) + } + + conn := client.QuickSightConn(ctx) + awsAccountId := client.AccountID + sweepResources := make([]sweep.Sweepable, 0) + + input := &quicksight.ListGroupsInput{ + AwsAccountId: aws.String(awsAccountId), + Namespace: aws.String(DefaultUserNamespace), + } + out, err := conn.ListGroupsWithContext(ctx, input) + for _, user := range out.GroupList { + groupname := aws.StringValue(user.GroupName) + if !strings.HasPrefix(groupname, acctestResourcePrefix) { + continue + } + + r := ResourceGroup() + d := r.Data(nil) + d.SetId(fmt.Sprintf("%s/%s/%s", awsAccountId, DefaultUserNamespace, groupname)) + + sweepResources = append(sweepResources, sweep.NewSweepResource(r, d, client)) + } + + if skipSweepUserError(err) { + log.Printf("[WARN] Skipping QuickSight Group sweep for %s: %s", region, err) + return nil + } + if err != nil { + return fmt.Errorf("listing QuickSight Groups: %w", err) + } + + if err := sweep.SweepOrchestrator(ctx, sweepResources); err != nil { + return fmt.Errorf("sweeping QuickSight Groups for %s: %w", region, err) + } + + return nil } func sweepTemplates(region string) error { From 408c4fc8b99f11c6cf0a4a49f14e02f45f275283 Mon Sep 17 00:00:00 2001 From: Kit Ewbank Date: Thu, 21 Sep 2023 10:45:39 -0400 Subject: [PATCH 15/15] r/aws_iam_policy: Skip sweeping Policies with attached entiries. --- internal/service/iam/sweep.go | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/internal/service/iam/sweep.go b/internal/service/iam/sweep.go index 4b5a5583764..429f4fce184 100644 --- a/internal/service/iam/sweep.go +++ b/internal/service/iam/sweep.go @@ -53,6 +53,8 @@ func init() { "aws_iam_group", "aws_iam_role", "aws_iam_user", + "aws_quicksight_group", + "aws_quicksight_user", }, }) @@ -430,6 +432,12 @@ func sweepPolicies(region string) error { for _, v := range page.Policies { arn := aws.StringValue(v.Arn) + + if n := aws.Int64Value(v.AttachmentCount); n > 0 { + log.Printf("[INFO] Skipping IAM Policy %s: AttachmentCount=%d", arn, n) + continue + } + r := ResourcePolicy() d := r.Data(nil) d.SetId(arn)