From 1114f4dc682ffc3af7174e5089fb723b6bd6c7d9 Mon Sep 17 00:00:00 2001 From: Abd-allah khateeb <55080308+akhateeb22@users.noreply.github.com> Date: Wed, 27 Sep 2023 21:15:15 +0300 Subject: [PATCH 1/4] Fix README.md in docs folder --- docs/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/README.md b/docs/README.md index 0d265fef628..58b8d8d5307 100644 --- a/docs/README.md +++ b/docs/README.md @@ -1,6 +1,6 @@ # Documentation -This directory contains documentation for the [Terraform AWS Provider Contributor Guide](https://hashicorp.github.io/terraform-provider-aws/). Resource and data source documentation is located in the [`website`](../website/) directory and available in the [Terraform Registry](https://registry.terraform.io/providers/hashicorp/aws/latest/docs). +This directory contains documentation for the [Terraform AWS Provider Contributor Guide](https://hashicorp.github.io/terraform-provider-aws/). Resource and data source documentation are located in the [`website`](../website/) directory and available in the [Terraform Registry](https://registry.terraform.io/providers/hashicorp/aws/latest/docs). ## Local Development From 8c1bd06c6341161d532f7b67440611860e342496 Mon Sep 17 00:00:00 2001 From: Abd-allah khateeb <55080308+akhateeb22@users.noreply.github.com> Date: Thu, 28 Sep 2023 00:18:56 +0300 Subject: [PATCH 2/4] Fixing grammers and verb omission in terraform-plugin-versions.md --- docs/terraform-plugin-versions.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/terraform-plugin-versions.md b/docs/terraform-plugin-versions.md index c3e7f679024..c2b77cf5413 100644 --- a/docs/terraform-plugin-versions.md +++ b/docs/terraform-plugin-versions.md @@ -2,7 +2,7 @@ The Terraform AWS Provider is constructed with HashiCorp-maintained packages for building plugins. Most existing resources are implemented with [Terraform Plugin SDKv2](https://developer.hashicorp.com/terraform/plugin/sdkv2), while newer resources may use [Terraform Plugin Framework](https://developer.hashicorp.com/terraform/plugin/framework). A thorough comparison of the packages can be found [here](https://developer.hashicorp.com/terraform/plugin/framework-benefits). -At this time community contributions in either package will be accepted. The AWS Provider is [muxed](https://developer.hashicorp.com/terraform/plugin/framework/migrating/mux) to allow resources and data sources implemented in both packages. As AWS Provider tooling around Plugin Framework (and the library itself) matures, we will being requiring all net-new resources be implemented with it. [`skaff`](skaff.md) currently supports generating Plugin Framework based resources using the optional `-p`/`--plugin-framework` flag. Factors to consider when choosing between packages are: +At this time community contributions in either package will be accepted. The AWS Provider is [muxed](https://developer.hashicorp.com/terraform/plugin/framework/migrating/mux) to allow resources and data sources to be implemented in both packages. As AWS Provider tooling around Plugin Framework (and the library itself) matures, we will being requiring all net-new resources to be implemented with it. [`skaff`](skaff.md) currently supports generating Plugin Framework based resources using the optional `-p`/`--plugin-framework` flag. Factors to consider when choosing between packages are: 1. What other resources in a given service use 2. Level of comfort with the new idioms introduced in Plugin Framework From c880d5914c0e48e4857af025ef58da66d925ad82 Mon Sep 17 00:00:00 2001 From: Graham Davison Date: Fri, 29 Sep 2023 10:35:37 -0700 Subject: [PATCH 3/4] Updates phrasing --- docs/README.md | 2 +- docs/terraform-plugin-versions.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/README.md b/docs/README.md index 58b8d8d5307..0d265fef628 100644 --- a/docs/README.md +++ b/docs/README.md @@ -1,6 +1,6 @@ # Documentation -This directory contains documentation for the [Terraform AWS Provider Contributor Guide](https://hashicorp.github.io/terraform-provider-aws/). Resource and data source documentation are located in the [`website`](../website/) directory and available in the [Terraform Registry](https://registry.terraform.io/providers/hashicorp/aws/latest/docs). +This directory contains documentation for the [Terraform AWS Provider Contributor Guide](https://hashicorp.github.io/terraform-provider-aws/). Resource and data source documentation is located in the [`website`](../website/) directory and available in the [Terraform Registry](https://registry.terraform.io/providers/hashicorp/aws/latest/docs). ## Local Development diff --git a/docs/terraform-plugin-versions.md b/docs/terraform-plugin-versions.md index c2b77cf5413..e48797c3264 100644 --- a/docs/terraform-plugin-versions.md +++ b/docs/terraform-plugin-versions.md @@ -2,7 +2,7 @@ The Terraform AWS Provider is constructed with HashiCorp-maintained packages for building plugins. Most existing resources are implemented with [Terraform Plugin SDKv2](https://developer.hashicorp.com/terraform/plugin/sdkv2), while newer resources may use [Terraform Plugin Framework](https://developer.hashicorp.com/terraform/plugin/framework). A thorough comparison of the packages can be found [here](https://developer.hashicorp.com/terraform/plugin/framework-benefits). -At this time community contributions in either package will be accepted. The AWS Provider is [muxed](https://developer.hashicorp.com/terraform/plugin/framework/migrating/mux) to allow resources and data sources to be implemented in both packages. As AWS Provider tooling around Plugin Framework (and the library itself) matures, we will being requiring all net-new resources to be implemented with it. [`skaff`](skaff.md) currently supports generating Plugin Framework based resources using the optional `-p`/`--plugin-framework` flag. Factors to consider when choosing between packages are: +At this time, we accept community contributions implemented using either package. The AWS Provider is [muxed](https://developer.hashicorp.com/terraform/plugin/framework/migrating/mux), so that resources and data sources can be implemented using either package. As AWS Provider tooling around Plugin Framework (and the library itself) matures, we will require that all net-new resources are implemented using the Plugin Framework. [`skaff`](skaff.md) currently supports generating Plugin Framework based resources using the optional `-p`/`--plugin-framework` flag. Factors to consider when choosing between packages are: 1. What other resources in a given service use 2. Level of comfort with the new idioms introduced in Plugin Framework From 183efdd597f58fa12c579cbe712ff0aedd0deaaa Mon Sep 17 00:00:00 2001 From: Graham Davison Date: Fri, 29 Sep 2023 10:39:07 -0700 Subject: [PATCH 4/4] Semantic line breaks --- docs/terraform-plugin-versions.md | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/docs/terraform-plugin-versions.md b/docs/terraform-plugin-versions.md index e48797c3264..b84e6e35732 100644 --- a/docs/terraform-plugin-versions.md +++ b/docs/terraform-plugin-versions.md @@ -1,8 +1,14 @@ # Terraform Plugin Versions -The Terraform AWS Provider is constructed with HashiCorp-maintained packages for building plugins. Most existing resources are implemented with [Terraform Plugin SDKv2](https://developer.hashicorp.com/terraform/plugin/sdkv2), while newer resources may use [Terraform Plugin Framework](https://developer.hashicorp.com/terraform/plugin/framework). A thorough comparison of the packages can be found [here](https://developer.hashicorp.com/terraform/plugin/framework-benefits). +The Terraform AWS Provider is constructed with HashiCorp-maintained packages for building plugins. +Most existing resources are implemented with [Terraform Plugin SDKv2](https://developer.hashicorp.com/terraform/plugin/sdkv2), while newer resources may use [Terraform Plugin Framework](https://developer.hashicorp.com/terraform/plugin/framework). +A thorough comparison of the packages can be found [here](https://developer.hashicorp.com/terraform/plugin/framework-benefits). -At this time, we accept community contributions implemented using either package. The AWS Provider is [muxed](https://developer.hashicorp.com/terraform/plugin/framework/migrating/mux), so that resources and data sources can be implemented using either package. As AWS Provider tooling around Plugin Framework (and the library itself) matures, we will require that all net-new resources are implemented using the Plugin Framework. [`skaff`](skaff.md) currently supports generating Plugin Framework based resources using the optional `-p`/`--plugin-framework` flag. Factors to consider when choosing between packages are: +At this time, we accept community contributions implemented using either package. +The AWS Provider is [muxed](https://developer.hashicorp.com/terraform/plugin/framework/migrating/mux), so that resources and data sources can be implemented using either package. +As AWS Provider tooling around Plugin Framework (and the library itself) matures, we will require that all net-new resources are implemented using the Plugin Framework. +[`skaff`](skaff.md) currently supports generating Plugin Framework based resources using the optional `-p`/`--plugin-framework` flag. +Factors to consider when choosing between packages are: 1. What other resources in a given service use 2. Level of comfort with the new idioms introduced in Plugin Framework