Improve rendering approach in the verification package. #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashant3286
changed the title
Signed-off-by: Prashant Bhandari <[email protected]>
Signed-off-by: Prashant Bhandari <[email protected]>
Yantrio
requested changes
Jan 2, 2024
There was a problem hiding this comment.
Thank you for the contribution, however it seems this this is non-functional
I'm not quite sure what is attempted here with regards to go templates.
This code also does not complile, doesn't pass unit tests, and doesn't even print anything as far as I can tell.
Would you mind shedding some light on why you chose to do this in the way that you did?
ghost
marked this pull request as draft
|
Closing as invalid / incomplete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93