Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPG Key Validation incorrectly reports that user is NOT a member of an org #794

Closed
Yantrio opened this issue Aug 7, 2024 · 2 comments
Closed

Comments

@Yantrio
Copy link
Member

Yantrio commented Aug 7, 2024

For some reason, the detection logic is failing. For an example see this PR: #792

If we manually hit the github api endpoint, it returns a 204 so the membership should be detected just fine.

@diofeher
Copy link

diofeher commented Jan 2, 2025

Hey @Yantrio, I just checked this issue on the latest main and it seems to be working as expected. I think we can close this issue.

(base) ➜  src git:(main) go run ./cmd/verify-gpg-key -key-file=/tmp/nspadaccino-pgp-key -username=nspadaccino -org=VinylDNS
## Validate GPG key
### Key is a valid PGP key
✅ **Success**
### Key is not expired
✅ **Success**
### Key is not revoked
✅ **Success**
### Key can be used for signing
✅ **Success**
### Key has a valid identity and email. (Email is preferable but optional)
✅ **Success**

## Validate Github user
### User is a member of the organization VinylDNS
> [!NOTE]
> If this is incorrect, please ensure that your organization membership is public. For more information, see [Github Docs - Publicizing or hiding organization membership](https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-your-membership-in-organizations/publicizing-or-hiding-organization-membership)

✅ **Success**

@cam72cam
Copy link
Member

cam72cam commented Jan 2, 2025

Could have been a transient issue, perhaps it took a bit for the membership public status to propagate to different API nodes? Thanks for checking @diofeher!

@cam72cam cam72cam closed this as completed Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants