-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle git ls-remote asking for authentication #48
Comments
One question, AFAICS, git ls-remote is called directly using |
@Yantrio had used it extensively in similar work recently and was running into some extremely odd issues and inconsistencies. |
I did use it and it was extremely flakey for no reason at all. It was not stable enough for me to be confident with using it here. However I'm happy if we re-visit this in the future. |
Alternatively we could try using https://api.github.com/repos/:org/:repo/git/refs/tags ex: https://api.github.com/repos/eda-dev-test/terraform-aws-test/git/refs/tags |
With the overhead of the fork/dup/etc.. this might actually be faster. |
It's also worth noting that this is not a problem for github actions. git ls-remote is unable to poll the term for user input and fails. It's mostly an issue when running it locally. |
If a repository is removed or made private, git ls-remote will hang asking for user authentication and break the bumper.
The text was updated successfully, but these errors were encountered: