Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for valid JSON on PRs #152

Closed
ghost opened this issue Jan 8, 2024 · 3 comments · Fixed by #174
Closed

Check for valid JSON on PRs #152

ghost opened this issue Jan 8, 2024 · 3 comments · Fixed by #174
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ghost
Copy link

ghost commented Jan 8, 2024

Description of the feature you are looking for.

On auto-generated PRs we still should check for valid JSON in case manual edits were necessary, see #147

@ghost ghost added the enhancement New feature or request label Jan 8, 2024
@ghost ghost added good first issue Good for newcomers help wanted Extra attention is needed labels Jan 17, 2024
@kislerdm
Copy link
Contributor

@janosdebugs Hey Janos, I'd be happy to give a hand with this issue this week. Are there any particular implementation restrictions to be mindful about?

@ghost
Copy link
Author

ghost commented Jan 17, 2024

Hey @kislerdm this should check if the JSON is formally valid, as well as being readable by the registry. The main intent is that if we manually need to edit the JSON (artisanal JSON), we should be prevented from merging a broken JSON as it would cause further issues.

@kislerdm
Copy link
Contributor

kislerdm commented Jan 17, 2024

@janosdebugs thanks for clarification! What is the condition for "being readable by the registry", does it mean validation against specific json schemas?

Also, are there any specific conditions to trigger the validation? For example, trigger only if changes are pushed to the branches which are prefixed with module-submission_*, or provider-submission_*?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant