Fix for hotkeyAimbotEnabled and mitigateDamage #2592
Conversation
Mitigate damage function no longer change the block type to armor
Fixed not being able to manually use runes on players with hotkeyAimbotEnabled option set on false.
|
Nice! But I'm not sure about the mitigation change. The block type is defined as |
When you block with a shield you always recieve 0 or less damage then is converted to block armor but it should not because you did not mitigated any damage. As you said the block type is important enough to not be randomly changed. Without this change is like you cannot block with a shield because you will always block with your armor. Imo the block type should never be changed. |
|
Good observation. Studying more here I agree. |
Not allow to use items from action bars.
| uint16_t itemId = msg.get<uint16_t>(); | ||
| uint8_t tier = msg.get<uint8_t>(); | ||
| g_game().playerEquipItem(player->getID(), itemId, Item::items[itemId].upgradeClassification > 0, tier); | ||
| player->sendCancelMessage("You cannot equip items by using a hotkey."); |
There was a problem hiding this comment.
Like this? These modifications don't seem to make sense. Won't this make the functionality stop working?
There was a problem hiding this comment.
I am sorry but I didn't wanted to pull this to your repository. Totally my bad, delete this. Only the initial pull is what I wanted.
Description
When having hotkeyAimbotEnabled set to false you cannot manually use runes on players.
MitigateDamage function was changing the block type to armor.
Behaviour
Actual
With hotkeyAimbotEnabled set to off when trying to manually use an Ultimate Healing Rune to a player you will get the message "You cannot shot directly on players".
Any damage that is pass through the mitigateDamage function will get it's block type to armor.
Expected
With hotkeyAimbotEnabled set to off when trying to manually use an Ultimate Healing Rune to a player will work correctly.
Any damage that is pass through the mitigateDamage function do not get it's block type changed..
Fixes #2542
Type of change
How Has This Been Tested
-Download everything fresh and test it, said bugs happen.
-Do small changes to the c++ source, it work as expected.
Checklist