Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo run should run the node #977

Open
ales-otf opened this issue Nov 13, 2024 · 2 comments · May be fixed by #1008
Open

cargo run should run the node #977

ales-otf opened this issue Nov 13, 2024 · 2 comments · May be fixed by #1008
Assignees
@ales-otf

Comments

@ales-otf
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The only executable we have is the node. And when we cargo run in our repo, the node should start without additional cargo flags.

Describe the solution you'd like

Configure the project the way, cargo run will run the node.

Describe alternatives you've considered

No response

Additional context

No response
@ales-otf
Copy link
Contributor Author

ales-otf commented Nov 18, 2024 •
edited
Loading

This could be done by converting the project structure to a flat workspace, but we need the library crate at the root as its build.rs runs lint checks in CI. discussed it with @sam0x17. We can encapsulate the library into a separate crate and just adapt paths in build.rs. Also, after the change the command to run the linter will be cargo build -p <crate-name> instead of cargo build.

A comment is added to the root library and fast-blocks feature added for the node (to run it with fast-blocks using cargo run) in this PR.

@ales-otf ales-otf self-assigned this Nov 18, 2024
@ales-otf ales-otf mentioned this issue Nov 18, 2024
Merged
13 tasks
@ales-otf
Copy link
Contributor Author

ales-otf commented Dec 5, 2024

Done in this PR #1008

@gztensor gztensor linked a pull request Dec 5, 2024 that will close this issue
Code coverage suite (rebased #848 with workspace restructure) #1008
Draft
25 tasks
@gztensor gztensor linked a pull request Dec 5, 2024 that will close this issue
Draft
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ales-otf ales-otf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Code coverage suite (rebased #848 with workspace restructure) opentensor/subtensor
1 participant
@ales-otf