Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Improve reconnection logic (sync subtensor) #2444

Closed
roman-opentensor opened this issue Nov 20, 2024 · 3 comments
Closed

[SDK] Improve reconnection logic (sync subtensor) #2444

roman-opentensor opened this issue Nov 20, 2024 · 3 comments
Assignees
Labels
bittensor enhancement New feature or request

Comments

@roman-opentensor
Copy link
Contributor

No description provided.

@roman-opentensor roman-opentensor added bittensor enhancement New feature or request labels Nov 20, 2024
@roman-opentensor roman-opentensor self-assigned this Nov 20, 2024
@roman-opentensor
Copy link
Contributor Author

PR #2442

@thewhaleking
Copy link
Contributor

Issue regarding reconnection. Eclipse Vortex in Discord pointed out that he was randomly having validators freeze up. Total freeze. He narrowed this down to this call in bittensor.core.extrinsics.utils:

response = substrate.submit_extrinsic(
    extrinsic,
    wait_for_inclusion=wait_for_inclusion,
    wait_for_finalization=wait_for_finalization,
)

Running v8.3.1, with wait_for_inclusion=True

I believe what is happening is that a subscription handler is created due to submitting the extrinsic with wait_for_inclusion=True, and then there is a connection interrupt. We are reconnecting, but due to how websockets work, our websocket connection will never receive the result of the subscription indicating success/failure. Thus, it is stuck in an infinite loop of polling.

@thewhaleking thewhaleking self-assigned this Nov 21, 2024
@thewhaleking
Copy link
Contributor

Relates to #2454 and #2448

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bittensor enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants