Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storing screenshot/images from diary on osm.org server #3434

Open
Stefal opened this issue Jan 22, 2022 · 12 comments
Open

Storing screenshot/images from diary on osm.org server #3434

Stefal opened this issue Jan 22, 2022 · 12 comments
Labels
diaries Related to the User Diaries feature enhancement Improvements and new feature requests

Comments

@Stefal
Copy link

Stefal commented Jan 22, 2022

Description

Hi!

When you want to include some screenshots/images inside a diary, you have to find an external service to host these files. It could be difficult to find, and no matter what you do, this service will close in a few years. The result is that you lost your time to include a screenshot, and we will lost some informations in the future.

It will be easier if we could store these images directly on the osm.org servers when we write our diary. It could be a "add image" button or a copy/paste like discourse/gitlab/github/...

I'd like to have the same feature on changeset discussions too.

Screenshots

No response

@tomhughes
Copy link
Member

Sure it would be lovely but implementing it would be a lot of work and there are significant operational questions around providing the actual storage and serving the images.

As to changeset comments I don't think those are rich text are they, so they don't support images?

@Stefal
Copy link
Author

Stefal commented Jan 22, 2022

If I had the skills I could try to help with some patches but unfortunately this is not the case.

You're right, we can't include an image in a changeset discussion, only a link. If it became possible to store images on osm.org it would be wonderful to have the same feature on changeset discussions. It could be only a link. Displaying this image is another point, see #844.

@tomhughes
Copy link
Member

Changeset discussions are deliberately text only because there isn't really space for complex rich text and images where they are displayed in the sidebar.

To be honest we kind of assumed changeset comments would be short - we never really anticipated threads running to dozens of messages some of essay length which are already pretty unreadable to my mind.

@simonpoole
Copy link
Contributor

simonpoole commented Jan 22, 2022

When you want to include some screenshots/images inside a diary, you have to find an external service to host these files.

If of general interest to the OSM community (which should be a given for a diary entry) you can store images on the OSM wiki and reference them from the diary.

@mmd-osm
Copy link
Contributor

mmd-osm commented Jan 22, 2022

It could be a "add image" button or a copy/paste like discourse/gitlab/github/...

Although Discourse is still in testing phase, we might use it for diary publishing and abandon the current diary feature on the Rails port.

@tomhughes
Copy link
Member

I was wondering much the same things, or even for changeset discussions if we integrated it so you could start a discussion from the main site and the database just remembered the thread and provided a link to it and maybe a summary.

@gravitystorm
Copy link
Collaborator

Although Discourse is still in testing phase, we might use it for diary publishing and abandon the current diary feature on the Rails port.

That's the first I've heard of this idea. Where is this being discussed?

@simonpoole
Copy link
Contributor

simonpoole commented Jan 22, 2022

That's the first I've heard of this idea. Where is this being discussed?

I've seen it being bandied around before (not that I think it is a good idea, as it is clearly distinct functionality from what Discourse offers and it implies throwing away even more of our historic content and work than is already planned), the discussion, if any, would be on slack (for obvious reasons).

@tomhughes
Copy link
Member

I'm not aware of it being discussed, from my point of view it was an idea that crossed my mind this morning. I actually think it fits changeset discussions better than it does diaries.

@mmd-osm
Copy link
Contributor

mmd-osm commented Jan 22, 2022

I'm not sure if there's any discussion on this topic anywhere else. I believe Discourse would support both a community forum & news/blog space. A quick search turned up something like this: https://www.elektronauts.com/news (mentioned on meta.discourse.org as an example).

One advantage I see is that moderation, search, commenting, community interaction all happens on one platform.

it implies throwing away even more of our historic content and work than is already planned)

Migrating old content is at least technically feasible, see https://forum.openstreetmap.fr as an example.

@HolgerJeromin
Copy link
Contributor

Storing images has the downside people will upload unwanted (copyrighted?) stuff which results in unfriendly emails from lawyers and co.

@tuckerrc tuckerrc added diaries Related to the User Diaries feature enhancement Improvements and new feature requests labels Jan 24, 2022
@samwilson
Copy link

I've always assumed the wiki was the place to host images for diary entries. For more generally-useful ones, I put them on Wikimedia Commons (from where they're also usable on the OSM wiki). That said, shifting to Discourse sounds great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diaries Related to the User Diaries feature enhancement Improvements and new feature requests
Projects
None yet
Development

No branches or pull requests

8 participants