Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

traffic_sign=variable_message has two direction fields #1306

Open
Dimitar5555 opened this issue Aug 4, 2024 · 2 comments
Open

traffic_sign=variable_message has two direction fields #1306

Dimitar5555 opened this issue Aug 4, 2024 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Dimitar5555
Copy link
Contributor

Describe the bug
traffic_sign=variable_message has two direction fields (one for direction and one for traffic_sign:direction.

To Reproduce

  1. Go to https://www.openstreetmap.org/edit#map=19/43.79918/25.91882
  2. Select node/12089459546

Expected behavior
Only one field should show up. Possibly direction since it used on 1.8k elements with traffic_sign=variable_message (compared ~1k for traffic_sign:direction).

Screenshots
I've entered values for the fields, to show that two tags are applied.
image

@Dimitar5555 Dimitar5555 added the bug Something isn't working label Aug 4, 2024
@tordans
Copy link
Collaborator

tordans commented Aug 10, 2024

Some research

The issue is that data/presets/traffic_sign/variable_message.json has two direction fields

  1. the explicit field https://github.com/openstreetmap/id-tagging-schema/blob/main/data/fields/direction_vertex.json
  2. the inherited/referenced field from https://github.com/openstreetmap/id-tagging-schema/blob/main/data/presets/traffic_sign.json which is https://github.com/openstreetmap/id-tagging-schema/blob/main/data/fields/traffic_sign/direction.json for vertex (https://github.com/openstreetmap/id-tagging-schema/blob/main/data/fields/direction_point.json for points)

The fields/direction_vertex is there from the start – History.
So is the fields/traffic_sign/direction – History

The fields/direction_vertex is used a lot – List
The fields/traffic_sign/direction is used only once – List

Proposed solution

Given that research, I think the way to solve this is to remove the fields/traffic_sign/direction field and reference fields/direction_vertex for presets/traffic_sign/variable_message.

I will add a label "good first issue" to this.

@raghav3615
Copy link

raghav3615 commented Sep 30, 2024

@Dimitar5555 @tordans open a new PR for this issue. kindly review it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants