Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed upgrade-charm to alias refresh #660

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

UtkarshBhatthere
Copy link
Contributor

According to juju 2.9 docs, upgrade-charm is an alias for refresh and supports the required call in our life-cycle test. The same nomenclature is used by juju3 so switching to refresh syntax makes this juju version agnostic.

# juju version 
2.9.49-ubuntu-amd64

# juju refresh --help
Usage: juju refresh [options] <application>

Summary:
Refresh an application's charm.
...
--path (= "")
    Refresh to a charm located at path
...
Aliases: upgrade-charm
utkarsh@workbook:~$ juju version
3.5.1-genericlinux-amd64

utkarsh@workbook:~$ juju refresh --help
Usage: juju refresh [options] <application>

Summary:
Refresh an application's charm.
...
--path (= "")
    Refresh to a charm located at path
...

@UtkarshBhatthere
Copy link
Contributor Author

Can someone trigger the failed tests again ? I am seeing: Applications in error state: ntp

@ajkavanagh
Copy link
Collaborator

Can someone trigger the failed tests again ? I am seeing: Applications in error state: ntp

I've re-triggered the failed jobs; let's see what happens.

Signed-off-by: Utkarsh Bhatt <[email protected]>
Copy link
Contributor

@sabaini sabaini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@sabaini sabaini merged commit d960b29 into openstack-charmers:master Jul 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants