Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some elements in the original IFC model cannot be displayed after uploading to Bimserver #1334

Open
Billy8424 opened this issue Oct 29, 2024 · 16 comments

Comments

@Billy8424
Copy link

Hello, we tried to upload a IFC model to BIMserver, but some equipment elements cannot be displayed after uploading to BIMserver, these elements can be displayed in the original IFC model. Please check the screenshots below, could you please have a check and let us know the reason? Thanks a lot.

Below is the original IFC model, we can see the equipment in the hall.
Original IFC model

This is the model after uploading to BIMserver, it's empty in the hall, the equipment is missing.
IFC model in Bimserver

@hlg
Copy link
Member

hlg commented Oct 29, 2024

It is not possible to tell where the elements are lost from those two screenshots. The IFC data undergoes a couple of steps until the final display: upload to BIMserver and deserialization, storage in the database, potentially creation of triangulated geometry, storage of the geometry, download from BIMserver, potentially filter by a query, serialization to IFC or a viewer-specific format, parsing in the viewer, potentially mapping to a scene graph or other viewer model, rendering. Please narrow down where the issue appears so that we can see whether this is actually a BIMserver issue and hopefully help solving it. Here are some questions to aid you:

  • Which BIMserver version are you using? How do you check-in? Via BIMvie.ws GUI? With which deserializer? If applicable: which API method?
  • Is the data complete after checking it into the BIMserver? Can you find the elements that are missing later?
  • Which viewer are you using? I can't recognize it from the screenshot.
  • Which data is the viewer taking from the BIMserver? The original IFC only or also the triangulated geometry? And in which format? Which serializer? With a query?
  • If relevant: Which render engine and implementation version are you using? Is the geometry complete after triangulation or do elements fail to triangulate?
  • Is the data complete after download and before display in the viewer?

@hlg
Copy link
Member

hlg commented Nov 5, 2024

Thank you for providing the IFC data. With a current BIMserver (1.5.186-SNAPSHOT) and IfcOpenShell (v0.7.0-c7830e9) version, and using BIMvie.ws as a viewer, I cannot reproduce the issue. See below, where you can see the machinery with and without its housing.

housing-on-s housing-off-s

@hlg
Copy link
Member

hlg commented Nov 12, 2024

Are you aware that your email replies are visible in the Github issue tracker and clutter the discussion? Please go to the Github web interface and cleanup your comments.

Snapshot versions cannot be downloaded. You can build it yourself or wait for the next release. For now, you can also try the latest released BIMserver version (1.5.185) with the last IfcOpenShell v0.6.0 version: 721fe47.

@Billy8424
Copy link
Author

Billy8424 commented Nov 15, 2024 via email

@zaqifathis
Copy link
Collaborator

zaqifathis commented Nov 15, 2024

Have you also tried using the latest IfcOpenShell v0.6.0 version: 721fe47 as hlg mentioned? The default version of IfcOpenShell is 2f3c79a. You can change it from the Server tab by navigating to Installed Plugin Bundles > IfcOpenShell-BIMserver-plugin, and changing the commit SHA

@Billy8424
Copy link
Author

Billy8424 commented Nov 18, 2024 via email

@zaqifathis
Copy link
Collaborator

You are correct; the default IfcOpenShell for BIMserver 1.5.185 is version 0.5.91.

I successfully built the IfcOpenShell plugin. It worked well for me. You can build from this commit 94ece7c and change the version to 721fe47here

@hlg
Copy link
Member

hlg commented Nov 18, 2024

For BIMserver 1.5.185, the last compatible IfcOpenShell plugin version is 0.5.94 which uses the IfcOpenShell build with commit SHA 2f3c79a (from the v0.6.0 branch) by default. You don't have to build neither IfcOpenShell itself nor the IfcOpenShell plugin. Just change the commit SHA to 721fe47 in the plugin settings. This has been explained multiple times in previous issues. However, even that is not necessary. As far as I can see, IfcOpenShell build 2f3c79a works just as fine for your sample. Have you really tried BIMserver 1.5.185 with the default plugins and checked in BIMvie.ws?

Note that we don't provide individual email support here, but we are having a public discussion around a potential issue in Github. Please keep the discussion readable. Don't delete your comments in the Github web interface, but remove the email headers, footers and quotes or directly participate in the discussion via Github web interface instead of email reply. If you want to send confidential test data or disclose any other information useful for BIMserver development, but not meant for the general public, then you can email to [email protected].

@Billy8424
Copy link
Author

Billy8424 commented Nov 25, 2024 via email

@Billy8424
Copy link
Author

Billy8424 commented Nov 25, 2024 via email

@zaqifathis
Copy link
Collaborator

Please remove the email header, etc.. from Github web interface as it hard to follow the discussion.

As explained before, to change the commit SHA, you just need to go to Server Setting tab > Installed Plugin Bundle > select IfcOpenShell-BIMserver-plugin > select IfcOpenShell.

Screenshot 2024-11-27 111934

@hlg
Copy link
Member

hlg commented Nov 27, 2024

I repeat: For both BIMserver 1.5.185 and 1.5.186 and the compatible IfcOpenShell plugins with their default IfcOpenShell commit sha settings, I cannot reproduce your issue - I can see the engine geometries in BIMvie.ws with the included older BIMsurfer version. There should be no need to change the commit sha or anything else in the setup.

If the issue persists for you, but we can not reproduce it, we need more information to find the cause. Please look at my first comment to this issue with a list of questions. Most importantly: Are you trying to see the geometry in BIMvie.ws or with a different viewer? Your screenshot in the original post does not look like BIMvie.ws, but something else with the grey background and the navigation controls.

@Billy8424
Copy link
Author

Billy8424 commented Dec 3, 2024 via email

@hlg
Copy link
Member

hlg commented Dec 3, 2024

Sorry, I cannot see any screenshots. For further investigation, you can follow the steps of the data from upload to the final visualization as outlined in the first reply already: 1. verify that the missing elements are there in BIMserver, for example search for a GUID using the "Browse" tab in BIMvie.ws, 2. check the geometry generation report for errors ("Extended data" tab), 3. make sure your viewer is capable, functioning with errors and not ignoring or hiding any elements.

@Billy8424
Copy link
Author

hello, thanks for your feedback.
From another BIM viewer, I got the GUID of this equipment, see below screenshot
another viewer
And in BIMvie.ws, I followed your instruction, search this GUID in the Browse tab, can find this element.
GUID in BIMvie
But in the BIMvie.ws viewer, I still cannot see the equipment, even in the structure seems I can also find this element, please see the screenshot below
No equipment in BIMvie
We have already upgraded the BIM server to 186 and the IfcOpenShell to v0.7.0-c7830e9. As you suggested in the last email, could you please let me know how to 'make sure your viewer is capable, functioning with errors and not ignoring or hiding any elements'?
By the way, is it possible for you to have a remote check to our environment or we can have a MS Teams meeting to review it together?
Thank you very much for your support.

@hlg
Copy link
Member

hlg commented Dec 4, 2024

The first step shows us that this is not a core BIMserver error or basic issue with the IFC file. The second step - check geometry generation report - is the next important now, because it will tell us whether the geometry for these elements was processed correctly. The third step I mentioned pertained to you possibly using a different viewer, for which I could not give any advise. With the BIMsurfer in BIMvie.ws this step is obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants