-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NMSM Pipeline muscle model for use in Moco #3908
Open
SpencerTWilliams
wants to merge
17
commits into
opensim-org:main
Choose a base branch
from
SpencerTWilliams:MeyerFregly2016Muscle
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add NMSM Pipeline muscle model for use in Moco #3908
SpencerTWilliams
wants to merge
17
commits into
opensim-org:main
from
SpencerTWilliams:MeyerFregly2016Muscle
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #<issue_number>
Brief summary of changes
This fork includes the new
MeyerFregly2016Muscle
, previously described in #3877.Testing I've completed
I've successfully compiled OpenSim on Ubuntu with these changes. However, I have not been able to test using the new elements.
Looking for feedback on...
As previously said in #3877:
I ran into an error while trying to compile a test for the
MeyerFregly2016Muscle
by modifyingtestMocoActuators.cpp
:I had the same error if I replaced the
auto
withMeyerFregly2016Muscle
, so I think there may be an issue with including the new muscle as a type, even though the code files for the muscle compile correctly. Are there any issues with how I included the muscle in linking or registering the type in 2063d6f?CHANGELOG.md (choose one)
This change is