Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] AGENT-1035: extend abi jobs with add-nodes workflow #59335

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

andfasano
Copy link
Contributor

@andfasano andfasano commented Nov 28, 2024

This patch extends the agent-e2e-compact-ipv4 CI workflow with the new add-nodes behavior.
All the CI repos referencing it have been updated/cleaned up - except for openshift/release, it will be updated in a different PR.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 28, 2024

@andfasano: This pull request references AGENT-1035 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 28, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 28, 2024
Copy link
Contributor

openshift-ci bot commented Nov 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@andfasano: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-agent-installer-utils-main-e2e-agent-compact-ipv4 openshift/agent-installer-utils presubmit Registry content changed
pull-ci-openshift-agent-installer-utils-release-4.20-e2e-agent-compact-ipv4 openshift/agent-installer-utils presubmit Registry content changed
pull-ci-openshift-agent-installer-utils-release-4.19-e2e-agent-compact-ipv4 openshift/agent-installer-utils presubmit Registry content changed
pull-ci-openshift-agent-installer-utils-release-4.18-e2e-agent-compact-ipv4 openshift/agent-installer-utils presubmit Registry content changed
pull-ci-openshift-agent-installer-utils-release-4.17-e2e-agent-compact-ipv4 openshift/agent-installer-utils presubmit Registry content changed
pull-ci-openshift-agent-installer-utils-release-4.16-e2e-agent-compact-ipv4 openshift/agent-installer-utils presubmit Registry content changed
pull-ci-openshift-agent-installer-utils-release-4.15-e2e-agent-compact-ipv4 openshift/agent-installer-utils presubmit Registry content changed
pull-ci-openshift-agent-installer-utils-release-4.14-e2e-agent-compact-ipv4 openshift/agent-installer-utils presubmit Registry content changed
pull-ci-openshift-metal3-dev-scripts-master-e2e-agent-compact-ipv4 openshift-metal3/dev-scripts presubmit Registry content changed
pull-ci-openshift-metal3-dev-scripts-master-e2e-agent-compact-ipv4-add-nodes openshift-metal3/dev-scripts presubmit Registry content changed
pull-ci-openshift-assisted-installer-master-e2e-agent-compact-ipv4 openshift/assisted-installer presubmit Registry content changed
pull-ci-openshift-assisted-installer-release-4.20-e2e-agent-compact-ipv4 openshift/assisted-installer presubmit Registry content changed
pull-ci-openshift-assisted-installer-release-4.19-e2e-agent-compact-ipv4 openshift/assisted-installer presubmit Registry content changed
pull-ci-openshift-assisted-installer-release-4.18-e2e-agent-compact-ipv4 openshift/assisted-installer presubmit Registry content changed
pull-ci-openshift-assisted-installer-release-4.17-e2e-agent-compact-ipv4 openshift/assisted-installer presubmit Registry content changed
pull-ci-openshift-assisted-installer-release-4.16-e2e-agent-compact-ipv4 openshift/assisted-installer presubmit Registry content changed
pull-ci-openshift-assisted-installer-release-4.15-e2e-agent-compact-ipv4 openshift/assisted-installer presubmit Registry content changed
pull-ci-openshift-assisted-installer-release-4.14-e2e-agent-compact-ipv4 openshift/assisted-installer presubmit Registry content changed
pull-ci-openshift-assisted-installer-release-4.13-e2e-agent-compact-ipv4 openshift/assisted-installer presubmit Registry content changed
pull-ci-openshift-assisted-installer-release-4.12-e2e-agent-compact-ipv4 openshift/assisted-installer presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-master-e2e-agent-compact-ipv4 openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.20-e2e-agent-compact-ipv4 openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.19-e2e-agent-compact-ipv4 openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.18-e2e-agent-compact-ipv4 openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.17-e2e-agent-compact-ipv4 openshift/ovn-kubernetes presubmit Registry content changed

A total of 79 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@andfasano
Copy link
Contributor Author

/pj-reharse

@andfasano
Copy link
Contributor Author

/pj-rehearse more

@openshift-ci-robot
Copy link
Contributor

@andfasano: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 28, 2024

@andfasano: This pull request references AGENT-1035 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

This patch extends the agent-e2e-compact-ipv4 CI workflow with the new add-nodes behavior.
All the CI repos referencing it have been updated/cleaned up - except for openshift/release, it will be updated in a different PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Nov 28, 2024

@andfasano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.14-e2e-agent-compact-ipv4 0a252cc link unknown /pj-rehearse periodic-ci-openshift-release-master-nightly-4.14-e2e-agent-compact-ipv4
ci/rehearse/openshift/agent-installer-utils/release-4.15/e2e-agent-compact-ipv4 0a252cc link unknown /pj-rehearse pull-ci-openshift-agent-installer-utils-release-4.15-e2e-agent-compact-ipv4
ci/rehearse/openshift/agent-installer-utils/release-4.14/e2e-agent-compact-ipv4 0a252cc link unknown /pj-rehearse pull-ci-openshift-agent-installer-utils-release-4.14-e2e-agent-compact-ipv4
ci/rehearse/openshift/assisted-installer/release-4.20/e2e-agent-compact-ipv4 0a252cc link unknown /pj-rehearse pull-ci-openshift-assisted-installer-release-4.20-e2e-agent-compact-ipv4

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants