Skip to content

Commit

Permalink
Merge pull request #1102 from grzpiotrowski/ocpbugs-31664-ingresscont…
Browse files Browse the repository at this point in the history
…roller-status

OCPBUGS-31664: Fix SyncLoadBalancerFailed status message of IngressController
  • Loading branch information
openshift-merge-bot[bot] authored Jul 11, 2024
2 parents f072291 + a2f440d commit defe53f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pkg/operator/controller/ingress/load_balancer_service.go
Original file line number Diff line number Diff line change
Expand Up @@ -751,7 +751,7 @@ func loadBalancerServiceIsProgressing(ic *operatorv1.IngressController, service
err := fmt.Errorf("The IngressController scope was changed from %q to %q.", haveScope, wantScope)
switch platform.Type {
case configv1.AWSPlatformType, configv1.IBMCloudPlatformType:
err = fmt.Errorf("%[1]s To effectuate this change, you must delete the service: `oc -n %[2]s delete svc/%[3]s`; the service load-balancer will then be deprovisioned and a new one created. This will most likely cause the new load-balancer to have a different host name and IP address from the old one's. Alternatively, you can revert the change to the IngressController: `oc -n openshift-ingress-operator patch ingresscontrollers/%[4]s --type=merge --patch='{\"spec\":{\"endpointPublishingStrategy\":{\"loadBalancer\":{\"scope\":\"%[5]s\"}}}}'", err.Error(), service.Namespace, service.Name, ic.Name, haveScope)
err = fmt.Errorf("%[1]s To effectuate this change, you must delete the service: `oc -n %[2]s delete svc/%[3]s`; the service load-balancer will then be deprovisioned and a new one created. This will most likely cause the new load-balancer to have a different host name and IP address from the old one's. Alternatively, you can revert the change to the IngressController: `oc -n openshift-ingress-operator patch ingresscontrollers/%[4]s --type=merge --patch='{\"spec\":{\"endpointPublishingStrategy\":{\"loadBalancer\":{\"scope\":\"%[5]s\"}}}}'`", err.Error(), service.Namespace, service.Name, ic.Name, haveScope)
}
errs = append(errs, err)
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/operator/controller/ingress/status.go
Original file line number Diff line number Diff line change
Expand Up @@ -871,7 +871,7 @@ func computeLoadBalancerStatus(ic *operatorv1.IngressController, service *corev1
if involved.Kind == "Service" && involved.Namespace == service.Namespace && involved.Name == service.Name && involved.UID == service.UID {
reason = "SyncLoadBalancerFailed"
message = fmt.Sprintf("The %s component is reporting SyncLoadBalancerFailed events like: %s\n%s",
event.Source.Component, event.Message, "The kube-controller-manager logs may contain more details.")
event.Source.Component, event.Message, "The cloud-controller-manager logs may contain more details.")
break
}
}
Expand Down

0 comments on commit defe53f

Please sign in to comment.